From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 885FBC3F2CE for ; Mon, 16 Mar 2020 15:47:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5AFB320679 for ; Mon, 16 Mar 2020 15:47:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oh5r2acF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731860AbgCPPrb (ORCPT ); Mon, 16 Mar 2020 11:47:31 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:35377 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731796AbgCPPrb (ORCPT ); Mon, 16 Mar 2020 11:47:31 -0400 Received: by mail-wm1-f66.google.com with SMTP id m3so18638571wmi.0 for ; Mon, 16 Mar 2020 08:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3QMtJyHMdj2d3NlJHtXdRPjzJsxucKLnz+qn2QRFOx0=; b=oh5r2acFcKirM1Z60N97UiPELuL4YbxB+3thPoKh00c2cXA7zBnMrcg9MocIgrcoCL U05LP/VCBy/GD0AL9aNluQa4QCsCZCtQYprWO7EIyPc9RAWGZvVCsle+UbSRXH9Gkm/0 KZJWytpT98u58L3kNWY/rNnStqJF3aq2+Ox1CNzi2Q+F03eOgvegXRb9TavYC+TyVBSt M/gQ9g1WL/OSC5hfVtxCTgHT3DFmQq6BKeS3Jv0oNCkzSq7i3fPAW/GtZOnFeBw5AIHa v49KMqeOlQX7Wl2sfbU7w4LmNqG13XIFmu88aXgH/xPUBruIR9N3LVcA+UxWR9+MtlzO N1gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3QMtJyHMdj2d3NlJHtXdRPjzJsxucKLnz+qn2QRFOx0=; b=U1epgpYeQNU/E4EjUdcWQstlh9AOD3JgwTEVW4uDORhTnlgdUoJ2ilwFRwBtjvdFiY Ug4C2MlsoeDtBo1/np8ODjOO/QeKEX8Y5N+02p4KCzdzgLmQmPP2klF0e1Hza/KCABtp 9MMBV0bY7Ida38eh3K7iMip88yYWoBdHSztJwKKiGoifhVKgrkKr3AWlqLKdxSLOpxTQ pftzkckkTUzq43552usqHb7GjxUckiC+Lmrrxhnpmoc8lE+hCUk2c/yghwAtLTMbHUkV Oe5QAhsZUnnztgJh4NV6FUYfLD6t//cvV32MrGKeM0NIRV/Kt4HsrnXi0LIxTzdpM4U2 n6zQ== X-Gm-Message-State: ANhLgQ2qLNpDLOomlJZUDg9f5/xjkGR1125xNIpOp/hUzy+MWNzOUdDv 7HFAVZMf6dKQsxTWrbtEr4Oyxw== X-Google-Smtp-Source: ADFU+vubP0XZlLxNsPBJjbPqoRh9Fj10FSwYOvdazGAIlTLv21y5ghlreopBsVqOhrzi4VW31nde8w== X-Received: by 2002:a7b:cd97:: with SMTP id y23mr28196696wmj.161.1584373650045; Mon, 16 Mar 2020 08:47:30 -0700 (PDT) Received: from myrica ([2001:171b:226b:54a0:116c:c27a:3e7f:5eaf]) by smtp.gmail.com with ESMTPSA id z4sm460593wrr.6.2020.03.16.08.47.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2020 08:47:29 -0700 (PDT) Date: Mon, 16 Mar 2020 16:47:22 +0100 From: Jean-Philippe Brucker To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, virtualization@lists.linux-foundation.org, Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Rob Clark , Sean Paul , Will Deacon , Robin Murphy , Matthias Brugger , Thierry Reding , Andy Gross , Bjorn Andersson , Joerg Roedel Subject: Re: [PATCH 07/15] iommu/arm-smmu: Fix uninitilized variable warning Message-ID: <20200316154722.GH304669@myrica> References: <20200310091229.29830-1-joro@8bytes.org> <20200310091229.29830-8-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200310091229.29830-8-joro@8bytes.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Mar 10, 2020 at 10:12:21AM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > Some unrelated changes in the iommu code caused a new warning to > appear in the arm-smmu driver: > > CC drivers/iommu/arm-smmu.o > drivers/iommu/arm-smmu.c: In function 'arm_smmu_add_device': > drivers/iommu/arm-smmu.c:1441:2: warning: 'smmu' may be used uninitialized in this function [-Wmaybe-uninitialized] > arm_smmu_rpm_put(smmu); > ^~~~~~~~~~~~~~~~~~~~~~ > > The warning is a false positive, but initialize the variable to NULL > to get rid of it. > > Tested-by: Will Deacon # arm-smmu > Signed-off-by: Joerg Roedel Reviewed-by: Jean-Philippe Brucker > --- > drivers/iommu/arm-smmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index 16c4b87af42b..980aae73b45b 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -1383,7 +1383,7 @@ struct arm_smmu_device *arm_smmu_get_by_fwnode(struct fwnode_handle *fwnode) > > static int arm_smmu_add_device(struct device *dev) > { > - struct arm_smmu_device *smmu; > + struct arm_smmu_device *smmu = NULL; > struct arm_smmu_master_cfg *cfg; > struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev); > int i, ret; > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C8E8C0044D for ; Mon, 16 Mar 2020 15:47:35 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E57D520679 for ; Mon, 16 Mar 2020 15:47:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oh5r2acF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E57D520679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id B544E220A2; Mon, 16 Mar 2020 15:47:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0ED9Q7fqzEvJ; Mon, 16 Mar 2020 15:47:34 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 322BF21FAD; Mon, 16 Mar 2020 15:47:34 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 20DA2C1D7C; Mon, 16 Mar 2020 15:47:34 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 32013C013E for ; Mon, 16 Mar 2020 15:47:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 210408879D for ; Mon, 16 Mar 2020 15:47:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qCNTjI1LO1Wz for ; Mon, 16 Mar 2020 15:47:32 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by hemlock.osuosl.org (Postfix) with ESMTPS id BF5B38886E for ; Mon, 16 Mar 2020 15:47:31 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id x3so13612261wmj.1 for ; Mon, 16 Mar 2020 08:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3QMtJyHMdj2d3NlJHtXdRPjzJsxucKLnz+qn2QRFOx0=; b=oh5r2acFcKirM1Z60N97UiPELuL4YbxB+3thPoKh00c2cXA7zBnMrcg9MocIgrcoCL U05LP/VCBy/GD0AL9aNluQa4QCsCZCtQYprWO7EIyPc9RAWGZvVCsle+UbSRXH9Gkm/0 KZJWytpT98u58L3kNWY/rNnStqJF3aq2+Ox1CNzi2Q+F03eOgvegXRb9TavYC+TyVBSt M/gQ9g1WL/OSC5hfVtxCTgHT3DFmQq6BKeS3Jv0oNCkzSq7i3fPAW/GtZOnFeBw5AIHa v49KMqeOlQX7Wl2sfbU7w4LmNqG13XIFmu88aXgH/xPUBruIR9N3LVcA+UxWR9+MtlzO N1gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3QMtJyHMdj2d3NlJHtXdRPjzJsxucKLnz+qn2QRFOx0=; b=Rc3EfKq79Pxk2iCuLQ+y3kA2wJ2YNZeKFiWYmaNqYYFw1sTlmMH13EXHBzE1YcrQ0C 0idXA5hnMF+meKnwrNFx4rgtek7wi3KNqLKX0Dg33wpYrSt5yxx7SmltqRvskE7eh1+l kQmeLKmcLxjaAGFQ3tnTgP09xYn4wZGv3gHTy+hvmOrX5WUENYI3JIOqlFZoyGGBj++K Xd/TzOVJkCa1aVUIAJcq8i4JSfVaVj9I+/OdDFoaDTTrm+NL8kppAdErXilKAzLpHmAN bvAP1NLisjjCz0lOyKDsap9wb/E0NX9BHgKXfmVnQqSlPFuZGwmP3M7A5mOyi56YHCQs XBBw== X-Gm-Message-State: ANhLgQ0AaC7DJTFT23rSsaXSQIOdUJ6FGgMMSRg7D6Lrj8bk10pA6XWF LqwaM5H5etadhjX0zi3IlC4z9A== X-Google-Smtp-Source: ADFU+vubP0XZlLxNsPBJjbPqoRh9Fj10FSwYOvdazGAIlTLv21y5ghlreopBsVqOhrzi4VW31nde8w== X-Received: by 2002:a7b:cd97:: with SMTP id y23mr28196696wmj.161.1584373650045; Mon, 16 Mar 2020 08:47:30 -0700 (PDT) Received: from myrica ([2001:171b:226b:54a0:116c:c27a:3e7f:5eaf]) by smtp.gmail.com with ESMTPSA id z4sm460593wrr.6.2020.03.16.08.47.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2020 08:47:29 -0700 (PDT) Date: Mon, 16 Mar 2020 16:47:22 +0100 From: Jean-Philippe Brucker To: Joerg Roedel Subject: Re: [PATCH 07/15] iommu/arm-smmu: Fix uninitilized variable warning Message-ID: <20200316154722.GH304669@myrica> References: <20200310091229.29830-1-joro@8bytes.org> <20200310091229.29830-8-joro@8bytes.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200310091229.29830-8-joro@8bytes.org> Cc: Will Deacon , linux-arm-msm@vger.kernel.org, Sudeep Holla , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, iommu@lists.linux-foundation.org, Thierry Reding , linux-mediatek@lists.infradead.org, Andy Gross , Joerg Roedel , Hanjun Guo , Matthias Brugger , Bjorn Andersson , Sean Paul , Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, Mar 10, 2020 at 10:12:21AM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > Some unrelated changes in the iommu code caused a new warning to > appear in the arm-smmu driver: > > CC drivers/iommu/arm-smmu.o > drivers/iommu/arm-smmu.c: In function 'arm_smmu_add_device': > drivers/iommu/arm-smmu.c:1441:2: warning: 'smmu' may be used uninitialized in this function [-Wmaybe-uninitialized] > arm_smmu_rpm_put(smmu); > ^~~~~~~~~~~~~~~~~~~~~~ > > The warning is a false positive, but initialize the variable to NULL > to get rid of it. > > Tested-by: Will Deacon # arm-smmu > Signed-off-by: Joerg Roedel Reviewed-by: Jean-Philippe Brucker > --- > drivers/iommu/arm-smmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index 16c4b87af42b..980aae73b45b 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -1383,7 +1383,7 @@ struct arm_smmu_device *arm_smmu_get_by_fwnode(struct fwnode_handle *fwnode) > > static int arm_smmu_add_device(struct device *dev) > { > - struct arm_smmu_device *smmu; > + struct arm_smmu_device *smmu = NULL; > struct arm_smmu_master_cfg *cfg; > struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev); > int i, ret; > -- > 2.17.1 > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC81BC18E5B for ; Mon, 16 Mar 2020 15:47:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B026620679 for ; Mon, 16 Mar 2020 15:47:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cvj+7T3W"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oh5r2acF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B026620679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1o3sLFJez2kqQUf3/vO5KsIb81poaBF1OiUYbhUOn38=; b=cvj+7T3WoRFwm3 98qupKTut4Fx7yD4ytxs/x5OIrsSMFDiL2HyBYX/KdWQC2+lejqr3PjzzwCSe7NqTFKozOS3IDnY5 W9RFL1F+3Y9bLG2bhOyEGAb7l3exImx6CulDuM+HEijHc3N7ZdPli5WcaP07Jk1XKWnlDwcS6ehfu EoihF4Nyzbdtm0gfPS8ly/tAGc5yTVFYmd8VNEEWBziz3AtqpqY/RktZQ6fufdsv8iBqcvi93Yi/9 mxF88uCb+cHyIjo8pXMXQH5P5q1mTic8FfdDWHMO0fxNnS6A3wtSbkZmM9KsZXL49i5br0FlB1jFh s3EnmSLoWT8mFAeOQRUA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDrxn-0002nm-1J; Mon, 16 Mar 2020 15:47:35 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDrxj-0002mf-QW for linux-mediatek@lists.infradead.org; Mon, 16 Mar 2020 15:47:33 +0000 Received: by mail-wm1-x341.google.com with SMTP id z13so2172429wml.0 for ; Mon, 16 Mar 2020 08:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3QMtJyHMdj2d3NlJHtXdRPjzJsxucKLnz+qn2QRFOx0=; b=oh5r2acFcKirM1Z60N97UiPELuL4YbxB+3thPoKh00c2cXA7zBnMrcg9MocIgrcoCL U05LP/VCBy/GD0AL9aNluQa4QCsCZCtQYprWO7EIyPc9RAWGZvVCsle+UbSRXH9Gkm/0 KZJWytpT98u58L3kNWY/rNnStqJF3aq2+Ox1CNzi2Q+F03eOgvegXRb9TavYC+TyVBSt M/gQ9g1WL/OSC5hfVtxCTgHT3DFmQq6BKeS3Jv0oNCkzSq7i3fPAW/GtZOnFeBw5AIHa v49KMqeOlQX7Wl2sfbU7w4LmNqG13XIFmu88aXgH/xPUBruIR9N3LVcA+UxWR9+MtlzO N1gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3QMtJyHMdj2d3NlJHtXdRPjzJsxucKLnz+qn2QRFOx0=; b=VBhkHwIK/LQDwmHQWxiS+cIimKkqZw7j/QmrMUkrTU2B4JAbMGtqQbsJdufavLN8c4 WQu2AFpMwumFvdhtxlJsSzMwQbjfjiLSQEe+/6vQbOfPRqsbm1CHnxLYeInhyeJ0vsFy ep+YrqNnlJSQJ7wTF+8X2UVeCbBYzsp88SxRX10HsaNCeiTWKARDKJdYbzU7xvdSvfrr N3YXpGSSbz/A0vmaUsNAl9kCn21vhvNGwle0V/RClocckMdwVEiYF7kdxptkN9tL1FQo RHijc/hi+H2oTSz6x3nsMkxDWFJOesm+HPNRHDA8RtXQg2U1ccshqJ+qFRpcSEc6qOrh cN9g== X-Gm-Message-State: ANhLgQ0oGUpriaVMrcRZUbM+3OmbLCB6DXbKgaJoQzieGX3uhDfZP2wA t9NqTWg8gdO8DyANPe415hxhPA== X-Google-Smtp-Source: ADFU+vubP0XZlLxNsPBJjbPqoRh9Fj10FSwYOvdazGAIlTLv21y5ghlreopBsVqOhrzi4VW31nde8w== X-Received: by 2002:a7b:cd97:: with SMTP id y23mr28196696wmj.161.1584373650045; Mon, 16 Mar 2020 08:47:30 -0700 (PDT) Received: from myrica ([2001:171b:226b:54a0:116c:c27a:3e7f:5eaf]) by smtp.gmail.com with ESMTPSA id z4sm460593wrr.6.2020.03.16.08.47.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2020 08:47:29 -0700 (PDT) Date: Mon, 16 Mar 2020 16:47:22 +0100 From: Jean-Philippe Brucker To: Joerg Roedel Subject: Re: [PATCH 07/15] iommu/arm-smmu: Fix uninitilized variable warning Message-ID: <20200316154722.GH304669@myrica> References: <20200310091229.29830-1-joro@8bytes.org> <20200310091229.29830-8-joro@8bytes.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200310091229.29830-8-joro@8bytes.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200316_084732_304687_4934F676 X-CRM114-Status: GOOD ( 16.40 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Lorenzo Pieralisi , Will Deacon , linux-arm-msm@vger.kernel.org, Sudeep Holla , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, iommu@lists.linux-foundation.org, Thierry Reding , linux-mediatek@lists.infradead.org, Andy Gross , Joerg Roedel , Hanjun Guo , Matthias Brugger , Bjorn Andersson , Sean Paul , Robin Murphy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Mar 10, 2020 at 10:12:21AM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > Some unrelated changes in the iommu code caused a new warning to > appear in the arm-smmu driver: > > CC drivers/iommu/arm-smmu.o > drivers/iommu/arm-smmu.c: In function 'arm_smmu_add_device': > drivers/iommu/arm-smmu.c:1441:2: warning: 'smmu' may be used uninitialized in this function [-Wmaybe-uninitialized] > arm_smmu_rpm_put(smmu); > ^~~~~~~~~~~~~~~~~~~~~~ > > The warning is a false positive, but initialize the variable to NULL > to get rid of it. > > Tested-by: Will Deacon # arm-smmu > Signed-off-by: Joerg Roedel Reviewed-by: Jean-Philippe Brucker > --- > drivers/iommu/arm-smmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index 16c4b87af42b..980aae73b45b 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -1383,7 +1383,7 @@ struct arm_smmu_device *arm_smmu_get_by_fwnode(struct fwnode_handle *fwnode) > > static int arm_smmu_add_device(struct device *dev) > { > - struct arm_smmu_device *smmu; > + struct arm_smmu_device *smmu = NULL; > struct arm_smmu_master_cfg *cfg; > struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev); > int i, ret; > -- > 2.17.1 > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek