Hi Can, Thank you for the patch! Yet something to improve: [auto build test ERROR on scsi/for-next] [also build test ERROR on mkp-scsi/for-next v5.6-rc7 next-20200325] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Can-Guo/UFS-driver-general-fixes-bundle-2/20200326-143749 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=9.2.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): In file included from include/linux/timer.h:6, from include/linux/workqueue.h:9, from include/linux/rhashtable-types.h:15, from include/linux/ipc.h:7, from include/uapi/linux/sem.h:5, from include/linux/sem.h:5, from include/linux/sched.h:15, from include/linux/ratelimit.h:6, from include/linux/dev_printk.h:16, from include/linux/device.h:15, from include/linux/async.h:14, from drivers/scsi/ufs/ufshcd.c:40: drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_scale_clks': >> drivers/scsi/ufs/ufshcd.c:949:39: error: 'start' undeclared (first use in this function); did you mean 'stat'? 949 | ktime_to_us(ktime_sub(ktime_get(), start)), ret); | ^~~~~ include/linux/ktime.h:46:39: note: in definition of macro 'ktime_sub' 46 | #define ktime_sub(lhs, rhs) ((lhs) - (rhs)) | ^~~ drivers/scsi/ufs/ufshcd.c:949:39: note: each undeclared identifier is reported only once for each function it appears in 949 | ktime_to_us(ktime_sub(ktime_get(), start)), ret); | ^~~~~ include/linux/ktime.h:46:39: note: in definition of macro 'ktime_sub' 46 | #define ktime_sub(lhs, rhs) ((lhs) - (rhs)) | ^~~ vim +949 drivers/scsi/ufs/ufshcd.c a67142dac16542 Subhash Jadavani 2020-03-25 920 a67142dac16542 Subhash Jadavani 2020-03-25 921 /** a67142dac16542 Subhash Jadavani 2020-03-25 922 * ufshcd_scale_clks - scale up or scale down UFS controller clocks a67142dac16542 Subhash Jadavani 2020-03-25 923 * @hba: per adapter instance a67142dac16542 Subhash Jadavani 2020-03-25 924 * @scale_up: True if scaling up and false if scaling down a67142dac16542 Subhash Jadavani 2020-03-25 925 * a67142dac16542 Subhash Jadavani 2020-03-25 926 * Returns 0 if successful a67142dac16542 Subhash Jadavani 2020-03-25 927 * Returns < 0 for any other errors a67142dac16542 Subhash Jadavani 2020-03-25 928 */ a67142dac16542 Subhash Jadavani 2020-03-25 929 static int ufshcd_scale_clks(struct ufs_hba *hba, bool scale_up) a67142dac16542 Subhash Jadavani 2020-03-25 930 { a67142dac16542 Subhash Jadavani 2020-03-25 931 int ret = 0; a67142dac16542 Subhash Jadavani 2020-03-25 932 a67142dac16542 Subhash Jadavani 2020-03-25 933 ret = ufshcd_vops_clk_scale_notify(hba, scale_up, PRE_CHANGE); a67142dac16542 Subhash Jadavani 2020-03-25 934 if (ret) a67142dac16542 Subhash Jadavani 2020-03-25 935 return ret; a67142dac16542 Subhash Jadavani 2020-03-25 936 a67142dac16542 Subhash Jadavani 2020-03-25 937 ret = ufshcd_set_clk_freq(hba, scale_up); a67142dac16542 Subhash Jadavani 2020-03-25 938 if (ret) a67142dac16542 Subhash Jadavani 2020-03-25 939 return ret; a67142dac16542 Subhash Jadavani 2020-03-25 940 a3cd5ec55f6c72 Subhash Jadavani 2017-02-03 941 ret = ufshcd_vops_clk_scale_notify(hba, scale_up, POST_CHANGE); a67142dac16542 Subhash Jadavani 2020-03-25 942 if (ret) { a67142dac16542 Subhash Jadavani 2020-03-25 943 ufshcd_set_clk_freq(hba, !scale_up); a67142dac16542 Subhash Jadavani 2020-03-25 944 return ret; a67142dac16542 Subhash Jadavani 2020-03-25 945 } a3cd5ec55f6c72 Subhash Jadavani 2017-02-03 946 a3cd5ec55f6c72 Subhash Jadavani 2017-02-03 947 trace_ufshcd_profile_clk_scaling(dev_name(hba->dev), a3cd5ec55f6c72 Subhash Jadavani 2017-02-03 948 (scale_up ? "up" : "down"), a3cd5ec55f6c72 Subhash Jadavani 2017-02-03 @949 ktime_to_us(ktime_sub(ktime_get(), start)), ret); a67142dac16542 Subhash Jadavani 2020-03-25 950 a3cd5ec55f6c72 Subhash Jadavani 2017-02-03 951 return ret; a3cd5ec55f6c72 Subhash Jadavani 2017-02-03 952 } a3cd5ec55f6c72 Subhash Jadavani 2017-02-03 953 :::::: The code at line 949 was first introduced by commit :::::: a3cd5ec55f6c72834f812f9150deb38ddc019782 scsi: ufs: add load based scaling of UFS gear :::::: TO: subhashj@codeaurora.org :::::: CC: Martin K. Petersen --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org