From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
USB list <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Felipe Balbi <balbi@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH USB 1/2] usb: raw-gadget: fix return value of ep read ioctls
Date: Fri, 24 Apr 2020 20:35:36 +0300 [thread overview]
Message-ID: <20200424173536.GS2682@kadam> (raw)
In-Reply-To: <CAAeHK+zS3WcmPEr9+hYGTMrZUwXyn5489Ke4f1zpdvTa-U-s9Q@mail.gmail.com>
On Fri, Apr 24, 2020 at 03:16:35PM +0200, Andrey Konovalov wrote:
> On Fri, Apr 24, 2020 at 10:43 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > On Fri, Apr 24, 2020 at 03:09:58AM +0200, Andrey Konovalov wrote:
> > > They must return the number of bytes transferred during the data stage.
> > >
> > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
> >
> > This was my mistake. Please add a Fixes tag.
> >
> > Fixes: 068fbff4f860 ("usb: raw-gadget: Fix copy_to/from_user() checks")
> >
> > I should have seen that bug... I thought I was being careful and I
> > even singled out that part of the commit and mentioned it in the
> > commit message but I messed up. Sorry.
>
> No worries, the bug was actually present before your change, but in a
> slightly different form. So FWIW we can also add:
>
> Fixes: f2c2e717642c ("usb: gadget: add raw-gadget interface")
>
> However raw-gadget is not present in any released kernel yet, so need
> of backporting AFAIU.
The Fixes: tag lets scripts know that it's not required to back port it.
regards,
dan carpenter
prev parent reply other threads:[~2020-04-24 17:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 1:09 [PATCH USB 1/2] usb: raw-gadget: fix return value of ep read ioctls Andrey Konovalov
2020-04-24 1:09 ` [PATCH USB 2/2] usb: raw-gadget: fix typo in uapi headers Andrey Konovalov
2020-04-24 5:43 ` Greg Kroah-Hartman
2020-05-05 7:50 ` Felipe Balbi
2020-05-05 12:11 ` Andrey Konovalov
2020-05-05 12:17 ` Greg Kroah-Hartman
2020-04-24 5:43 ` [PATCH USB 1/2] usb: raw-gadget: fix return value of ep read ioctls Greg Kroah-Hartman
2020-04-24 8:43 ` Dan Carpenter
2020-04-24 13:16 ` Andrey Konovalov
2020-04-24 17:35 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424173536.GS2682@kadam \
--to=dan.carpenter@oracle.com \
--cc=andreyknvl@google.com \
--cc=balbi@kernel.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.