Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on next-20200423] [cannot apply to tip/locking/core rcu/dev linus/master tip/x86/core v5.7-rc2 v5.7-rc1 v5.6 v5.7-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/drm-shmobile-Reduce-include-dependencies/20200424-044529 base: aefe184e814492e36b2ca350c1522bd71b09b520 config: powerpc-allnoconfig (attached as .config) compiler: powerpc-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All error/warnings (new ones prefixed by >>): arch/powerpc/kernel/setup-common.c: In function 'setup_panic': >> arch/powerpc/kernel/setup-common.c:737:35: error: 'panic_notifier_list' undeclared (first use in this function); did you mean 'reboot_notifier_list'? 737 | atomic_notifier_chain_register(&panic_notifier_list, | ^~~~~~~~~~~~~~~~~~~ | reboot_notifier_list arch/powerpc/kernel/setup-common.c:737:35: note: each undeclared identifier is reported only once for each function it appears in -- In file included from arch/powerpc/include/asm/atomic.h:11, from include/linux/atomic.h:7, from include/linux/jump_label.h:249, from arch/powerpc/lib/feature-fixups.c:12: arch/powerpc/include/asm/cmpxchg.h: In function '__xchg_u8_local': >> arch/powerpc/include/asm/cmpxchg.h:12:61: error: 'BITS_PER_BYTE' undeclared (first use in this function); did you mean 'BITS_PER_LONG'? 12 | #define BITOFF_CAL(size, off) ((sizeof(u32) - size - off) * BITS_PER_BYTE) | ^~~~~~~~~~~~~ >> arch/powerpc/include/asm/cmpxchg.h:23:11: note: in expansion of macro 'BITOFF_CAL' 23 | bitoff = BITOFF_CAL(sizeof(type), off); \ | ^~~~~~~~~~ >> arch/powerpc/include/asm/cmpxchg.h:83:1: note: in expansion of macro 'XCHG_GEN' 83 | XCHG_GEN(u8, _local, "memory"); | ^~~~~~~~ arch/powerpc/include/asm/cmpxchg.h:12:61: note: each undeclared identifier is reported only once for each function it appears in 12 | #define BITOFF_CAL(size, off) ((sizeof(u32) - size - off) * BITS_PER_BYTE) | ^~~~~~~~~~~~~ >> arch/powerpc/include/asm/cmpxchg.h:23:11: note: in expansion of macro 'BITOFF_CAL' 23 | bitoff = BITOFF_CAL(sizeof(type), off); \ | ^~~~~~~~~~ >> arch/powerpc/include/asm/cmpxchg.h:83:1: note: in expansion of macro 'XCHG_GEN' 83 | XCHG_GEN(u8, _local, "memory"); | ^~~~~~~~ arch/powerpc/include/asm/cmpxchg.h: In function '__xchg_u8_relaxed': >> arch/powerpc/include/asm/cmpxchg.h:12:61: error: 'BITS_PER_BYTE' undeclared (first use in this function); did you mean 'BITS_PER_LONG'? 12 | #define BITOFF_CAL(size, off) ((sizeof(u32) - size - off) * BITS_PER_BYTE) | ^~~~~~~~~~~~~ >> arch/powerpc/include/asm/cmpxchg.h:23:11: note: in expansion of macro 'BITOFF_CAL' 23 | bitoff = BITOFF_CAL(sizeof(type), off); \ | ^~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h:84:1: note: in expansion of macro 'XCHG_GEN' 84 | XCHG_GEN(u8, _relaxed, "cc"); | ^~~~~~~~ arch/powerpc/include/asm/cmpxchg.h: In function '__xchg_u16_local': >> arch/powerpc/include/asm/cmpxchg.h:12:61: error: 'BITS_PER_BYTE' undeclared (first use in this function); did you mean 'BITS_PER_LONG'? 12 | #define BITOFF_CAL(size, off) ((sizeof(u32) - size - off) * BITS_PER_BYTE) | ^~~~~~~~~~~~~ >> arch/powerpc/include/asm/cmpxchg.h:23:11: note: in expansion of macro 'BITOFF_CAL' 23 | bitoff = BITOFF_CAL(sizeof(type), off); \ | ^~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h:85:1: note: in expansion of macro 'XCHG_GEN' 85 | XCHG_GEN(u16, _local, "memory"); | ^~~~~~~~ arch/powerpc/include/asm/cmpxchg.h: In function '__xchg_u16_relaxed': >> arch/powerpc/include/asm/cmpxchg.h:12:61: error: 'BITS_PER_BYTE' undeclared (first use in this function); did you mean 'BITS_PER_LONG'? 12 | #define BITOFF_CAL(size, off) ((sizeof(u32) - size - off) * BITS_PER_BYTE) | ^~~~~~~~~~~~~ >> arch/powerpc/include/asm/cmpxchg.h:23:11: note: in expansion of macro 'BITOFF_CAL' 23 | bitoff = BITOFF_CAL(sizeof(type), off); \ | ^~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h:86:1: note: in expansion of macro 'XCHG_GEN' 86 | XCHG_GEN(u16, _relaxed, "cc"); | ^~~~~~~~ arch/powerpc/include/asm/cmpxchg.h: In function '__cmpxchg_u8': >> arch/powerpc/include/asm/cmpxchg.h:12:61: error: 'BITS_PER_BYTE' undeclared (first use in this function); did you mean 'BITS_PER_LONG'? 12 | #define BITOFF_CAL(size, off) ((sizeof(u32) - size - off) * BITS_PER_BYTE) | ^~~~~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h:49:11: note: in expansion of macro 'BITOFF_CAL' 49 | bitoff = BITOFF_CAL(sizeof(type), off); \ | ^~~~~~~~~~ >> arch/powerpc/include/asm/cmpxchg.h:213:1: note: in expansion of macro 'CMPXCHG_GEN' 213 | CMPXCHG_GEN(u8, , PPC_ATOMIC_ENTRY_BARRIER, PPC_ATOMIC_EXIT_BARRIER, "memory"); | ^~~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h: In function '__cmpxchg_u8_local': >> arch/powerpc/include/asm/cmpxchg.h:12:61: error: 'BITS_PER_BYTE' undeclared (first use in this function); did you mean 'BITS_PER_LONG'? 12 | #define BITOFF_CAL(size, off) ((sizeof(u32) - size - off) * BITS_PER_BYTE) | ^~~~~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h:49:11: note: in expansion of macro 'BITOFF_CAL' 49 | bitoff = BITOFF_CAL(sizeof(type), off); \ | ^~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h:214:1: note: in expansion of macro 'CMPXCHG_GEN' 214 | CMPXCHG_GEN(u8, _local, , , "memory"); | ^~~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h: In function '__cmpxchg_u8_acquire': >> arch/powerpc/include/asm/cmpxchg.h:12:61: error: 'BITS_PER_BYTE' undeclared (first use in this function); did you mean 'BITS_PER_LONG'? 12 | #define BITOFF_CAL(size, off) ((sizeof(u32) - size - off) * BITS_PER_BYTE) | ^~~~~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h:49:11: note: in expansion of macro 'BITOFF_CAL' 49 | bitoff = BITOFF_CAL(sizeof(type), off); \ | ^~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h:215:1: note: in expansion of macro 'CMPXCHG_GEN' 215 | CMPXCHG_GEN(u8, _acquire, , PPC_ACQUIRE_BARRIER, "memory"); | ^~~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h: In function '__cmpxchg_u8_relaxed': >> arch/powerpc/include/asm/cmpxchg.h:12:61: error: 'BITS_PER_BYTE' undeclared (first use in this function); did you mean 'BITS_PER_LONG'? 12 | #define BITOFF_CAL(size, off) ((sizeof(u32) - size - off) * BITS_PER_BYTE) | ^~~~~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h:49:11: note: in expansion of macro 'BITOFF_CAL' 49 | bitoff = BITOFF_CAL(sizeof(type), off); \ | ^~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h:216:1: note: in expansion of macro 'CMPXCHG_GEN' 216 | CMPXCHG_GEN(u8, _relaxed, , , "cc"); | ^~~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h: In function '__cmpxchg_u16': >> arch/powerpc/include/asm/cmpxchg.h:12:61: error: 'BITS_PER_BYTE' undeclared (first use in this function); did you mean 'BITS_PER_LONG'? 12 | #define BITOFF_CAL(size, off) ((sizeof(u32) - size - off) * BITS_PER_BYTE) | ^~~~~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h:49:11: note: in expansion of macro 'BITOFF_CAL' 49 | bitoff = BITOFF_CAL(sizeof(type), off); \ | ^~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h:217:1: note: in expansion of macro 'CMPXCHG_GEN' 217 | CMPXCHG_GEN(u16, , PPC_ATOMIC_ENTRY_BARRIER, PPC_ATOMIC_EXIT_BARRIER, "memory"); | ^~~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h: In function '__cmpxchg_u16_local': >> arch/powerpc/include/asm/cmpxchg.h:12:61: error: 'BITS_PER_BYTE' undeclared (first use in this function); did you mean 'BITS_PER_LONG'? 12 | #define BITOFF_CAL(size, off) ((sizeof(u32) - size - off) * BITS_PER_BYTE) | ^~~~~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h:49:11: note: in expansion of macro 'BITOFF_CAL' 49 | bitoff = BITOFF_CAL(sizeof(type), off); \ | ^~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h:218:1: note: in expansion of macro 'CMPXCHG_GEN' 218 | CMPXCHG_GEN(u16, _local, , , "memory"); | ^~~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h: In function '__cmpxchg_u16_acquire': >> arch/powerpc/include/asm/cmpxchg.h:12:61: error: 'BITS_PER_BYTE' undeclared (first use in this function); did you mean 'BITS_PER_LONG'? 12 | #define BITOFF_CAL(size, off) ((sizeof(u32) - size - off) * BITS_PER_BYTE) | ^~~~~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h:49:11: note: in expansion of macro 'BITOFF_CAL' 49 | bitoff = BITOFF_CAL(sizeof(type), off); \ | ^~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h:219:1: note: in expansion of macro 'CMPXCHG_GEN' 219 | CMPXCHG_GEN(u16, _acquire, , PPC_ACQUIRE_BARRIER, "memory"); | ^~~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h: In function '__cmpxchg_u16_relaxed': >> arch/powerpc/include/asm/cmpxchg.h:12:61: error: 'BITS_PER_BYTE' undeclared (first use in this function); did you mean 'BITS_PER_LONG'? 12 | #define BITOFF_CAL(size, off) ((sizeof(u32) - size - off) * BITS_PER_BYTE) | ^~~~~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h:49:11: note: in expansion of macro 'BITOFF_CAL' 49 | bitoff = BITOFF_CAL(sizeof(type), off); \ | ^~~~~~~~~~ arch/powerpc/include/asm/cmpxchg.h:220:1: note: in expansion of macro 'CMPXCHG_GEN' 220 | CMPXCHG_GEN(u16, _relaxed, , , "cc"); | ^~~~~~~~~~~ vim +737 arch/powerpc/kernel/setup-common.c 921a79b7802078 Jason Yan 2019-09-20 733 ab9dbf771ff9b6 David Gibson 2017-12-04 734 void __init setup_panic(void) ab9dbf771ff9b6 David Gibson 2017-12-04 735 { 921a79b7802078 Jason Yan 2019-09-20 736 if (IS_ENABLED(CONFIG_RANDOMIZE_BASE) && kaslr_offset() > 0) 921a79b7802078 Jason Yan 2019-09-20 @737 atomic_notifier_chain_register(&panic_notifier_list, 921a79b7802078 Jason Yan 2019-09-20 738 &kernel_offset_notifier); 921a79b7802078 Jason Yan 2019-09-20 739 855b6232dda2b6 Nicholas Piggin 2018-05-19 740 /* PPC64 always does a hard irq disable in its panic handler */ 855b6232dda2b6 Nicholas Piggin 2018-05-19 741 if (!IS_ENABLED(CONFIG_PPC64) && !ppc_md.panic) ab9dbf771ff9b6 David Gibson 2017-12-04 742 return; ab9dbf771ff9b6 David Gibson 2017-12-04 743 atomic_notifier_chain_register(&panic_notifier_list, &ppc_panic_block); ab9dbf771ff9b6 David Gibson 2017-12-04 744 } ab9dbf771ff9b6 David Gibson 2017-12-04 745 :::::: The code at line 737 was first introduced by commit :::::: 921a79b7802078fab3787c7eae561536906cb8f3 powerpc/fsl_booke/kaslr: dump out kernel offset information on panic :::::: TO: Jason Yan :::::: CC: Michael Ellerman --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org