From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v1 4/9] tests/tcg: drop inferior.was_attached() test
Date: Thu, 30 Apr 2020 20:01:17 +0100 [thread overview]
Message-ID: <20200430190122.4592-5-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200430190122.4592-1-alex.bennee@linaro.org>
This test seems flaky and reports attachment even when we failed to
negotiate the architecture. However the fetching of the guest
architecture will fail tripping up the gdb AttributeError which will
trigger our early no error status exit from the test
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/tcg/aarch64/gdbstub/test-sve-ioctl.py | 3 ---
tests/tcg/aarch64/gdbstub/test-sve.py | 3 ---
2 files changed, 6 deletions(-)
diff --git a/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py b/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
index 387b2fc20a..972cf73c31 100644
--- a/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
+++ b/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
@@ -58,9 +58,6 @@ def run_test():
#
try:
inferior = gdb.selected_inferior()
- if inferior.was_attached == False:
- print("SKIPPING (failed to attach)", file=sys.stderr)
- exit(0)
arch = inferior.architecture()
report(arch.name() == "aarch64", "connected to aarch64")
except (gdb.error, AttributeError):
diff --git a/tests/tcg/aarch64/gdbstub/test-sve.py b/tests/tcg/aarch64/gdbstub/test-sve.py
index 5995689625..b96bdbb99a 100644
--- a/tests/tcg/aarch64/gdbstub/test-sve.py
+++ b/tests/tcg/aarch64/gdbstub/test-sve.py
@@ -59,9 +59,6 @@ def run_test():
#
try:
inferior = gdb.selected_inferior()
- if inferior.was_attached == False:
- print("SKIPPING (failed to attach)", file=sys.stderr)
- exit(0)
arch = inferior.architecture()
report(arch.name() == "aarch64", "connected to aarch64")
except (gdb.error, AttributeError):
--
2.20.1
next prev parent reply other threads:[~2020-04-30 19:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 19:01 [PATCH v1 0/9] gdbstub/next Alex Bennée
2020-04-30 19:01 ` [PATCH v1 1/9] configure: favour gdb-multiarch if we have it Alex Bennée
2020-05-01 12:25 ` Philippe Mathieu-Daudé
2020-05-01 13:22 ` Alex Bennée
2020-04-30 19:01 ` [PATCH v1 2/9] gdbstub: Introduce gdb_get_float64() to get 64-bit float registers Alex Bennée
2020-05-01 14:34 ` Richard Henderson
2020-04-30 19:01 ` [PATCH v1 3/9] tests/tcg: better trap gdb failures Alex Bennée
2020-04-30 19:01 ` Alex Bennée [this message]
2020-04-30 19:01 ` [PATCH v1 5/9] gdbstub: eliminate gdbserver_fd global Alex Bennée
2020-05-01 12:28 ` Philippe Mathieu-Daudé
2020-05-01 14:35 ` Richard Henderson
2020-04-30 19:01 ` [PATCH v1 6/9] gdbstub/linux-user: support debugging over a unix socket Alex Bennée
2020-05-01 14:43 ` Richard Henderson
2020-04-30 19:01 ` [PATCH v1 7/9] tests/guest-debug: use the unix socket for linux-user tests Alex Bennée
2020-05-01 14:46 ` Richard Henderson
2020-05-01 14:59 ` Alex Bennée
2020-04-30 19:01 ` [PATCH v1 8/9] tests/tcg: add a multiarch linux-user gdb test Alex Bennée
2020-05-01 14:47 ` Richard Henderson
2020-04-30 19:01 ` [PATCH v1 9/9] target/m68k: fix gdb for m68xxx Alex Bennée
2020-05-01 14:45 ` Richard Henderson
2020-05-01 14:46 ` Laurent Vivier
2020-05-01 7:01 ` [PATCH v1 0/9] gdbstub/next no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430190122.4592-5-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.