Hi Qiuxu, I love your patch! Yet something to improve: [auto build test ERROR on ras/edac-for-next] [also build test ERROR on next-20200508] [cannot apply to v5.7-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Qiuxu-Zhuo/EDAC-skx-i10nm-Use-CPU-stepping-macro-to-pass-configurations/20200509-114154 base: https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git edac-for-next config: x86_64-lkp (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> drivers/edac/skx_base.c:167:2: error: implicit declaration of function 'X86_MATCH_INTEL_FAM6_MODEL_STEPPINGS'; did you mean 'X86_MATCH_INTEL_FAM6_MODEL'? [-Werror=implicit-function-declaration] X86_MATCH_INTEL_FAM6_MODEL_STEPPINGS(SKYLAKE_X, X86_STEPPINGS(0x0, 0xf), &skx_cfg), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ X86_MATCH_INTEL_FAM6_MODEL drivers/edac/skx_base.c:167:39: error: 'SKYLAKE_X' undeclared here (not in a function) X86_MATCH_INTEL_FAM6_MODEL_STEPPINGS(SKYLAKE_X, X86_STEPPINGS(0x0, 0xf), &skx_cfg), ^~~~~~~~~ >> drivers/edac/skx_base.c:167:50: error: implicit declaration of function 'X86_STEPPINGS'; did you mean 'CPU_STEPPING_MASK'? [-Werror=implicit-function-declaration] X86_MATCH_INTEL_FAM6_MODEL_STEPPINGS(SKYLAKE_X, X86_STEPPINGS(0x0, 0xf), &skx_cfg), ^~~~~~~~~~~~~ CPU_STEPPING_MASK cc1: some warnings being treated as errors vim +167 drivers/edac/skx_base.c 165 166 static const struct x86_cpu_id skx_cpuids[] = { > 167 X86_MATCH_INTEL_FAM6_MODEL_STEPPINGS(SKYLAKE_X, X86_STEPPINGS(0x0, 0xf), &skx_cfg), 168 { } 169 }; 170 MODULE_DEVICE_TABLE(x86cpu, skx_cpuids); 171 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org