From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Date: Mon, 11 May 2020 07:51:15 +0000 Subject: Re: [PATCH 02/31] arm64: fix the flush_icache_range arguments in machine_kexec Message-Id: <20200511075115.GA16134@willie-the-truck> List-Id: References: <20200510075510.987823-1-hch@lst.de> <20200510075510.987823-3-hch@lst.de> In-Reply-To: <20200510075510.987823-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig , james.morse@arm.com, catalin.marinas@arm.com Cc: Andrew Morton , Arnd Bergmann , Roman Zippel , Jessica Yu , Michal Simek , x86@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linux-fsdevel@vger.kernel.org [+James and Catalin] On Sun, May 10, 2020 at 09:54:41AM +0200, Christoph Hellwig wrote: > The second argument is the end "pointer", not the length. > > Signed-off-by: Christoph Hellwig > --- > arch/arm64/kernel/machine_kexec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c > index 8e9c924423b4e..a0b144cfaea71 100644 > --- a/arch/arm64/kernel/machine_kexec.c > +++ b/arch/arm64/kernel/machine_kexec.c > @@ -177,6 +177,7 @@ void machine_kexec(struct kimage *kimage) > * the offline CPUs. Therefore, we must use the __* variant here. > */ > __flush_icache_range((uintptr_t)reboot_code_buffer, > + (uintptr_t)reboot_code_buffer + > arm64_relocate_new_kernel_size); Urgh, well spotted. It's annoyingly different from __flush_dcache_area(). But now I'm wondering what this code actually does... the loop condition in invalidate_icache_by_line works with 64-bit arithmetic, so we could spend a /very/ long time here afaict. It's also a bit annoying that we do a bunch of redundant D-cache maintenance too. Should we use invalidate_icache_range() here instead? (and why does that thing need to toggle uaccess)? Argh, too many questions! Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C6D3C47255 for ; Mon, 11 May 2020 07:51:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 073B82192A for ; Mon, 11 May 2020 07:51:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589183486; bh=ujV3u+dsl5PKS0aIWtuPo2XlUIWTrnZfhH9932lJ3Ck=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=avpQeyyAMEvvjubvxTG6JO4AUadsDyi3+P4roOcvcFneG9pNWXDeEe/PHXM4xajOv BRa9SEhZ1fh8ykeYY2Cn9sHzbKhWd0Ob64yeJhIE0hllk3EFeTiPR2O4kEZ5D6Le8r e7P8+FNuXMYw9IuIdk9IIMyOZFrpVVYMjLdywQ3Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728408AbgEKHvZ (ORCPT ); Mon, 11 May 2020 03:51:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:50784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726173AbgEKHvY (ORCPT ); Mon, 11 May 2020 03:51:24 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 15B2F20735; Mon, 11 May 2020 07:51:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589183483; bh=ujV3u+dsl5PKS0aIWtuPo2XlUIWTrnZfhH9932lJ3Ck=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0mQ7t5as8jZps7eSFkQLnwLtzVeQdo1iP3qe/Hftt/g3zJxfzwQVDrNcWnrxBfusE WGRRbC87hk6tU7Y02J552JkiWyPKHGmHG8/2xNIIubv0rRSCeTtP6ug62nSc345L3i YbZ4edSRI7cSRvmZAntksnLnC8c2Z4vBB1WMY+EY= Date: Mon, 11 May 2020 08:51:15 +0100 From: Will Deacon To: Christoph Hellwig , james.morse@arm.com, catalin.marinas@arm.com Cc: Andrew Morton , Arnd Bergmann , Roman Zippel , Jessica Yu , Michal Simek , x86@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 02/31] arm64: fix the flush_icache_range arguments in machine_kexec Message-ID: <20200511075115.GA16134@willie-the-truck> References: <20200510075510.987823-1-hch@lst.de> <20200510075510.987823-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200510075510.987823-3-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+James and Catalin] On Sun, May 10, 2020 at 09:54:41AM +0200, Christoph Hellwig wrote: > The second argument is the end "pointer", not the length. > > Signed-off-by: Christoph Hellwig > --- > arch/arm64/kernel/machine_kexec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c > index 8e9c924423b4e..a0b144cfaea71 100644 > --- a/arch/arm64/kernel/machine_kexec.c > +++ b/arch/arm64/kernel/machine_kexec.c > @@ -177,6 +177,7 @@ void machine_kexec(struct kimage *kimage) > * the offline CPUs. Therefore, we must use the __* variant here. > */ > __flush_icache_range((uintptr_t)reboot_code_buffer, > + (uintptr_t)reboot_code_buffer + > arm64_relocate_new_kernel_size); Urgh, well spotted. It's annoyingly different from __flush_dcache_area(). But now I'm wondering what this code actually does... the loop condition in invalidate_icache_by_line works with 64-bit arithmetic, so we could spend a /very/ long time here afaict. It's also a bit annoying that we do a bunch of redundant D-cache maintenance too. Should we use invalidate_icache_range() here instead? (and why does that thing need to toggle uaccess)? Argh, too many questions! Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D30CC54E8D for ; Mon, 11 May 2020 07:51:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3319820735 for ; Mon, 11 May 2020 07:51:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q5MzzTin"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0mQ7t5as" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3319820735 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OPtQblVL9ZwbDtBF8oJtgHZYbfhgtkq+dSfLTuZ81AY=; b=q5MzzTin7zkB6CrRATTfg/OHC w7bwp6LHv47Dbd4rZtHOln1AURW6vda8JHsObJ2xNkh/40T1+OVIFJG8EzKj4Z9wNKagTQH0CwiAa RT7A8hL5xN0XHuuN6GivW3X+rOvnKnpmhoki2To2XMPq/y2Nm26f+HMfpMIUtpJA0pDNSGjd9NggH NMT/Qu2QTEvqbuwIrVw4/9wA7YpwIL83j0vHVlrHcrqd1CjIWJ4Wb+UwCm6NHlP02qivL5h5eEKJz YRx+I4Rdmz5Q8CkI5/4epLgq+mR8gGMurAGzxzNv0N40YlYv111v8VUVFhc2ekwnEe+EbjC5LYvCU YoyY2NEaA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY3Do-0007Kh-MH; Mon, 11 May 2020 07:51:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY3Dg-0007Be-8j; Mon, 11 May 2020 07:51:25 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 15B2F20735; Mon, 11 May 2020 07:51:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589183483; bh=ujV3u+dsl5PKS0aIWtuPo2XlUIWTrnZfhH9932lJ3Ck=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0mQ7t5as8jZps7eSFkQLnwLtzVeQdo1iP3qe/Hftt/g3zJxfzwQVDrNcWnrxBfusE WGRRbC87hk6tU7Y02J552JkiWyPKHGmHG8/2xNIIubv0rRSCeTtP6ug62nSc345L3i YbZ4edSRI7cSRvmZAntksnLnC8c2Z4vBB1WMY+EY= Date: Mon, 11 May 2020 08:51:15 +0100 From: Will Deacon To: Christoph Hellwig , james.morse@arm.com, catalin.marinas@arm.com Subject: Re: [PATCH 02/31] arm64: fix the flush_icache_range arguments in machine_kexec Message-ID: <20200511075115.GA16134@willie-the-truck> References: <20200510075510.987823-1-hch@lst.de> <20200510075510.987823-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200510075510.987823-3-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200511_005124_323286_125698CE X-CRM114-Status: GOOD ( 15.34 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Roman Zippel , linux-mips@vger.kernel.org, linux-mm@kvack.org, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, x86@kernel.org, linux-xtensa@linux-xtensa.org, Arnd Bergmann , Jessica Yu , linux-um@lists.infradead.org, linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, linux-arm-kernel@lists.infradead.org, Michal Simek , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org [+James and Catalin] On Sun, May 10, 2020 at 09:54:41AM +0200, Christoph Hellwig wrote: > The second argument is the end "pointer", not the length. > > Signed-off-by: Christoph Hellwig > --- > arch/arm64/kernel/machine_kexec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c > index 8e9c924423b4e..a0b144cfaea71 100644 > --- a/arch/arm64/kernel/machine_kexec.c > +++ b/arch/arm64/kernel/machine_kexec.c > @@ -177,6 +177,7 @@ void machine_kexec(struct kimage *kimage) > * the offline CPUs. Therefore, we must use the __* variant here. > */ > __flush_icache_range((uintptr_t)reboot_code_buffer, > + (uintptr_t)reboot_code_buffer + > arm64_relocate_new_kernel_size); Urgh, well spotted. It's annoyingly different from __flush_dcache_area(). But now I'm wondering what this code actually does... the loop condition in invalidate_icache_by_line works with 64-bit arithmetic, so we could spend a /very/ long time here afaict. It's also a bit annoying that we do a bunch of redundant D-cache maintenance too. Should we use invalidate_icache_range() here instead? (and why does that thing need to toggle uaccess)? Argh, too many questions! Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4B00C54E8D for ; Mon, 11 May 2020 07:51:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8565A20735 for ; Mon, 11 May 2020 07:51:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WR0qqVcu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0mQ7t5as" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8565A20735 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hRPL9v5uOi7/oZnPelurlajdWni6bOc67jZy780P99s=; b=WR0qqVcuZOr75z XuGr3k7r6Ya7sj4dHqEg5sP5WsvXXnVDiH6vSqj8nGgzdU3H0a176ndA14cW9Wpjvb1lDzr5N9/Fu ayPMIFvMlwJqr7IY316z7th/iNPLZZM6SLJhUWxfPtVnUErzXx2um7LSL/SzJDhKkcB1Lt8mXaJU+ vIFugeNuQin5cctToP5fheH9fmziCYzdKqj1LDcAF9euhIT+0kVAz6exdGEPdmJDKLZ3txPLDxV+J yw4jEmVVfez+JijstXhRJKimlL1JA5cH5VYsN4QgLh4LpwJa+/RHKz3OSQtf0ng1e8wRZgj6VQRca 7eEE+hPnpXTbRKzZqzlw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY3Di-0007CI-Rd; Mon, 11 May 2020 07:51:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY3Dg-0007Be-8j; Mon, 11 May 2020 07:51:25 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 15B2F20735; Mon, 11 May 2020 07:51:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589183483; bh=ujV3u+dsl5PKS0aIWtuPo2XlUIWTrnZfhH9932lJ3Ck=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0mQ7t5as8jZps7eSFkQLnwLtzVeQdo1iP3qe/Hftt/g3zJxfzwQVDrNcWnrxBfusE WGRRbC87hk6tU7Y02J552JkiWyPKHGmHG8/2xNIIubv0rRSCeTtP6ug62nSc345L3i YbZ4edSRI7cSRvmZAntksnLnC8c2Z4vBB1WMY+EY= Date: Mon, 11 May 2020 08:51:15 +0100 From: Will Deacon To: Christoph Hellwig , james.morse@arm.com, catalin.marinas@arm.com Subject: Re: [PATCH 02/31] arm64: fix the flush_icache_range arguments in machine_kexec Message-ID: <20200511075115.GA16134@willie-the-truck> References: <20200510075510.987823-1-hch@lst.de> <20200510075510.987823-3-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200510075510.987823-3-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200511_005124_323286_125698CE X-CRM114-Status: GOOD ( 15.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Roman Zippel , linux-mips@vger.kernel.org, linux-mm@kvack.org, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, x86@kernel.org, linux-xtensa@linux-xtensa.org, Arnd Bergmann , Jessica Yu , linux-um@lists.infradead.org, linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, linux-arm-kernel@lists.infradead.org, Michal Simek , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org [+James and Catalin] On Sun, May 10, 2020 at 09:54:41AM +0200, Christoph Hellwig wrote: > The second argument is the end "pointer", not the length. > > Signed-off-by: Christoph Hellwig > --- > arch/arm64/kernel/machine_kexec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c > index 8e9c924423b4e..a0b144cfaea71 100644 > --- a/arch/arm64/kernel/machine_kexec.c > +++ b/arch/arm64/kernel/machine_kexec.c > @@ -177,6 +177,7 @@ void machine_kexec(struct kimage *kimage) > * the offline CPUs. Therefore, we must use the __* variant here. > */ > __flush_icache_range((uintptr_t)reboot_code_buffer, > + (uintptr_t)reboot_code_buffer + > arm64_relocate_new_kernel_size); Urgh, well spotted. It's annoyingly different from __flush_dcache_area(). But now I'm wondering what this code actually does... the loop condition in invalidate_icache_by_line works with 64-bit arithmetic, so we could spend a /very/ long time here afaict. It's also a bit annoying that we do a bunch of redundant D-cache maintenance too. Should we use invalidate_icache_range() here instead? (and why does that thing need to toggle uaccess)? Argh, too many questions! Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Date: Mon, 11 May 2020 08:51:15 +0100 Subject: [OpenRISC] [PATCH 02/31] arm64: fix the flush_icache_range arguments in machine_kexec In-Reply-To: <20200510075510.987823-3-hch@lst.de> References: <20200510075510.987823-1-hch@lst.de> <20200510075510.987823-3-hch@lst.de> Message-ID: <20200511075115.GA16134@willie-the-truck> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: openrisc@lists.librecores.org [+James and Catalin] On Sun, May 10, 2020 at 09:54:41AM +0200, Christoph Hellwig wrote: > The second argument is the end "pointer", not the length. > > Signed-off-by: Christoph Hellwig > --- > arch/arm64/kernel/machine_kexec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c > index 8e9c924423b4e..a0b144cfaea71 100644 > --- a/arch/arm64/kernel/machine_kexec.c > +++ b/arch/arm64/kernel/machine_kexec.c > @@ -177,6 +177,7 @@ void machine_kexec(struct kimage *kimage) > * the offline CPUs. Therefore, we must use the __* variant here. > */ > __flush_icache_range((uintptr_t)reboot_code_buffer, > + (uintptr_t)reboot_code_buffer + > arm64_relocate_new_kernel_size); Urgh, well spotted. It's annoyingly different from __flush_dcache_area(). But now I'm wondering what this code actually does... the loop condition in invalidate_icache_by_line works with 64-bit arithmetic, so we could spend a /very/ long time here afaict. It's also a bit annoying that we do a bunch of redundant D-cache maintenance too. Should we use invalidate_icache_range() here instead? (and why does that thing need to toggle uaccess)? Argh, too many questions! Will