All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Kamal Heib <kamalheib1@gmail.com>
Cc: Leon Romanovsky <leon@kernel.org>,
	linux-rdma@vger.kernel.org, Doug Ledford <dledford@redhat.com>,
	Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH for-rc] RDMA/srpt: Fix disabling device management
Date: Wed, 13 May 2020 09:43:34 -0300	[thread overview]
Message-ID: <20200513124334.GA29989@ziepe.ca> (raw)
In-Reply-To: <20200513123837.GA123854@kheib-workstation>

On Wed, May 13, 2020 at 03:38:37PM +0300, Kamal Heib wrote:
> > > Correct me if I'm wrong, Do you mean check the return value from
> > > rdma_cap_ib_mad()?
> > 
> > I think so.
> > 
> > Thanks
> 
> Well, this function will not help in the case of VFs, because the flag
> that is checked in rdma_cap_ib_mad() is RDMA_CORE_CAP_IB_MAD which is
> set almost for each create IB device as part of RDMA_CORE_PORT_IBA_IB or
> RDMA_CORE_PORT_IBA_ROCE or RDMA_CORE_PORT_IBA_ROCE_UDP_ENCAP.

AFAIK this case only happens for mlx4 devices that use the GUID table
to emulate virtual IB ports. In this case there is no bit to control.

I didn't quite understand why srpt has this stuff, does it mean it is
broken on mlx4 vports? Why allow the failure?

Jason

  reply	other threads:[~2020-05-13 12:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11 22:29 [PATCH for-rc] RDMA/srpt: Fix disabling device management Kamal Heib
2020-05-13  7:22 ` Leon Romanovsky
2020-05-13 10:02   ` Kamal Heib
2020-05-13 10:21     ` Leon Romanovsky
2020-05-13 10:45       ` Kamal Heib
2020-05-13 10:50         ` Leon Romanovsky
2020-05-13 11:14           ` Kamal Heib
2020-05-13 11:31             ` Leon Romanovsky
2020-05-13 12:38               ` Kamal Heib
2020-05-13 12:43                 ` Jason Gunthorpe [this message]
2020-05-13 15:25                   ` Bart Van Assche
2020-05-13 18:02                     ` Jason Gunthorpe
2020-05-13 18:07                       ` Bart Van Assche
2020-05-13 18:08                         ` Jason Gunthorpe
2020-05-13 11:59         ` Gal Pressman
2020-05-13 12:54           ` Kamal Heib
2020-05-13 12:48 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200513124334.GA29989@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=bvanassche@acm.org \
    --cc=dledford@redhat.com \
    --cc=kamalheib1@gmail.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.