From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21EEFC433DF for ; Mon, 1 Jun 2020 14:56:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED12D20738 for ; Mon, 1 Jun 2020 14:56:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="xJ3jMVda" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726667AbgFAO43 (ORCPT ); Mon, 1 Jun 2020 10:56:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726067AbgFAO42 (ORCPT ); Mon, 1 Jun 2020 10:56:28 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30843C05BD43 for ; Mon, 1 Jun 2020 07:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=nDf9cvm/ZefW9y6efpBbORsXzUNCnvBktxgDSUJOFe0=; b=xJ3jMVdaSmg2Ny7iJI06PVpl7 SCS6f+oZDfUj0tkfF5DLpvqlKPdRpf1oDCW6w2N4xY8LHAMKQ27jM3FruT0cBSJGsF0iUMXZ5gz4l Frfyv4n59QLbmn9BqF/9v8aFUg8QZknM3BGdSEw8eklEHRwu/UMk00KY8muN3FPe+5MJNJmvyFYDW P7GutIGYA6/jn37IhfdMUzZYgM0zLD1U1BARdCSNYFMDnHAMJ0bnxiTj3d5hyfI5TIE5xV3fOm0OH WLUcluznY6uGxGFu3ZuNvly1dphT7bh0apG/41hfx4vv1vtaLxEBbxvM/co/7H6x2cMIluUzYpJbF tUn9zw3cw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:39986) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jflrL-0000Zg-2t; Mon, 01 Jun 2020 15:56:15 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jflrK-0003Or-Gl; Mon, 01 Jun 2020 15:56:14 +0100 Date: Mon, 1 Jun 2020 15:56:14 +0100 From: Russell King - ARM Linux admin To: =?utf-8?Q?=C5=81ukasz?= Stelmach Cc: Masahiro Yamada , Nick Desaulniers , Thomas Gleixner , Enrico Weigelt , Kees Cook , Ingo Molnar , Ben Dooks , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, AKASHI Takahiro , Bartlomiej Zolnierkiewicz , Marek Szyprowski Subject: Re: [PATCH 4/5] arm: Add kexec_image_info Message-ID: <20200601145614.GK1551@shell.armlinux.org.uk> References: <20200601142754.26139-1-l.stelmach@samsung.com> <20200601142754.26139-5-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200601142754.26139-5-l.stelmach@samsung.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 01, 2020 at 04:27:53PM +0200, Łukasz Stelmach wrote: > Add kexec_image_info to print detailed information about a kexec image. Isn't this already visible through kexec debugging? Why do we need to duplicate the same output in the kernel? Do we think that the kexec interfaces are that fragile that they don't work? > > Signed-off-by: Łukasz Stelmach > --- > arch/arm/kernel/machine_kexec.c | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c > index 76300f3813e8..c10a2dfd53d1 100644 > --- a/arch/arm/kernel/machine_kexec.c > +++ b/arch/arm/kernel/machine_kexec.c > @@ -31,6 +31,32 @@ extern unsigned long kexec_boot_atags; > > static atomic_t waiting_for_crash_ipi; > > +/** > + * kexec_image_info - For debugging output. > + */ > +#define kexec_image_info(_i) _kexec_image_info(__func__, __LINE__, _i) > +static void _kexec_image_info(const char *func, int line, > + const struct kimage *kimage) > +{ > + unsigned long i; > + > + pr_debug("%s:%d:\n", func, line); > + pr_debug(" kexec kimage info:\n"); > + pr_debug(" type: %d\n", kimage->type); > + pr_debug(" start: %lx\n", kimage->start); > + pr_debug(" head: %lx\n", kimage->head); > + pr_debug(" nr_segments: %lu\n", kimage->nr_segments); > + > + for (i = 0; i < kimage->nr_segments; i++) { > + pr_debug(" segment[%lu]: %08lx - %08lx, 0x%x bytes, %lu pages\n", > + i, > + kimage->segment[i].mem, > + kimage->segment[i].mem + kimage->segment[i].memsz, > + kimage->segment[i].memsz, > + kimage->segment[i].memsz / PAGE_SIZE); > + } > +} > + > /* > * Provide a dummy crash_notes definition while crash dump arrives to arm. > * This prevents breakage of crash_notes attribute in kernel/ksysfs.c. > @@ -42,6 +68,8 @@ int machine_kexec_prepare(struct kimage *image) > __be32 header; > int i, err; > > + kexec_image_info(image); > + > image->arch.kernel_r2 = image->start - KEXEC_ARM_ZIMAGE_OFFSET > + KEXEC_ARM_ATAGS_OFFSET; > > -- > 2.26.2 > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC for 0.8m (est. 1762m) line in suburbia: sync at 13.1Mbps down 424kbps up From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1652C433E0 for ; Mon, 1 Jun 2020 14:56:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8044F20738 for ; Mon, 1 Jun 2020 14:56:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="l8A8Lel4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="xJ3jMVda" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8044F20738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sYX8IxVlvCNhHPmSg1ye76uiR3+s25KILD+FGMLxVpE=; b=l8A8Lel4SPO71p Bd7ow2nssfrC6dK+YvLexapzNz2WnY8//P5HOg1v0mfDkZgOHNoO3QIlU1vX2nm5C4J9Vt3pFqYsd y3OKzzLdD9z1Z2EL0ntE9lCq5knCv00psgEQTCTA0fk+pbH6ZTAFW52M/iGPZ8la25Y9ZpcyAb1Ce 4q85ocDLvn5qa+ddeRkRHeMvSb6dAfGhhrEECF7ll8VDcmQtSUBunS7qmHu7xVPyH6KcoFER8HzYj Up5JbWFqXAb5t9yrQhGfdF0NTFlP0PgOeZgzOniDvn77ZUxJmxPcumhkPZMp7vvKbqfRkTWu2a5FR xV8j7PZ4ALdtMHHOxQsg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jflra-0007MV-Dc; Mon, 01 Jun 2020 14:56:30 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jflrX-0007Lx-Hr for linux-arm-kernel@lists.infradead.org; Mon, 01 Jun 2020 14:56:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=nDf9cvm/ZefW9y6efpBbORsXzUNCnvBktxgDSUJOFe0=; b=xJ3jMVdaSmg2Ny7iJI06PVpl7 SCS6f+oZDfUj0tkfF5DLpvqlKPdRpf1oDCW6w2N4xY8LHAMKQ27jM3FruT0cBSJGsF0iUMXZ5gz4l Frfyv4n59QLbmn9BqF/9v8aFUg8QZknM3BGdSEw8eklEHRwu/UMk00KY8muN3FPe+5MJNJmvyFYDW P7GutIGYA6/jn37IhfdMUzZYgM0zLD1U1BARdCSNYFMDnHAMJ0bnxiTj3d5hyfI5TIE5xV3fOm0OH WLUcluznY6uGxGFu3ZuNvly1dphT7bh0apG/41hfx4vv1vtaLxEBbxvM/co/7H6x2cMIluUzYpJbF tUn9zw3cw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:39986) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jflrL-0000Zg-2t; Mon, 01 Jun 2020 15:56:15 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jflrK-0003Or-Gl; Mon, 01 Jun 2020 15:56:14 +0100 Date: Mon, 1 Jun 2020 15:56:14 +0100 From: Russell King - ARM Linux admin To: =?utf-8?Q?=C5=81ukasz?= Stelmach Subject: Re: [PATCH 4/5] arm: Add kexec_image_info Message-ID: <20200601145614.GK1551@shell.armlinux.org.uk> References: <20200601142754.26139-1-l.stelmach@samsung.com> <20200601142754.26139-5-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200601142754.26139-5-l.stelmach@samsung.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200601_075627_667982_AE39750B X-CRM114-Status: GOOD ( 15.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Bartlomiej Zolnierkiewicz , Masahiro Yamada , Nick Desaulniers , linux-kernel@vger.kernel.org, AKASHI Takahiro , Ben Dooks , Thomas Gleixner , Enrico Weigelt , Ingo Molnar , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdW4gMDEsIDIwMjAgYXQgMDQ6Mjc6NTNQTSArMDIwMCwgxYF1a2FzeiBTdGVsbWFj aCB3cm90ZToKPiBBZGQga2V4ZWNfaW1hZ2VfaW5mbyB0byBwcmludCBkZXRhaWxlZCBpbmZvcm1h dGlvbiBhYm91dCBhIGtleGVjIGltYWdlLgoKSXNuJ3QgdGhpcyBhbHJlYWR5IHZpc2libGUgdGhy b3VnaCBrZXhlYyBkZWJ1Z2dpbmc/ICBXaHkgZG8gd2UgbmVlZAp0byBkdXBsaWNhdGUgdGhlIHNh bWUgb3V0cHV0IGluIHRoZSBrZXJuZWw/ICBEbyB3ZSB0aGluayB0aGF0IHRoZQprZXhlYyBpbnRl cmZhY2VzIGFyZSB0aGF0IGZyYWdpbGUgdGhhdCB0aGV5IGRvbid0IHdvcms/Cgo+IAo+IFNpZ25l ZC1vZmYtYnk6IMWBdWthc3ogU3RlbG1hY2ggPGwuc3RlbG1hY2hAc2Ftc3VuZy5jb20+Cj4gLS0t Cj4gIGFyY2gvYXJtL2tlcm5lbC9tYWNoaW5lX2tleGVjLmMgfCAyOCArKysrKysrKysrKysrKysr KysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspCj4gCj4gZGlm ZiAtLWdpdCBhL2FyY2gvYXJtL2tlcm5lbC9tYWNoaW5lX2tleGVjLmMgYi9hcmNoL2FybS9rZXJu ZWwvbWFjaGluZV9rZXhlYy5jCj4gaW5kZXggNzYzMDBmMzgxM2U4Li5jMTBhMmRmZDUzZDEgMTAw NjQ0Cj4gLS0tIGEvYXJjaC9hcm0va2VybmVsL21hY2hpbmVfa2V4ZWMuYwo+ICsrKyBiL2FyY2gv YXJtL2tlcm5lbC9tYWNoaW5lX2tleGVjLmMKPiBAQCAtMzEsNiArMzEsMzIgQEAgZXh0ZXJuIHVu c2lnbmVkIGxvbmcga2V4ZWNfYm9vdF9hdGFnczsKPiAgCj4gIHN0YXRpYyBhdG9taWNfdCB3YWl0 aW5nX2Zvcl9jcmFzaF9pcGk7Cj4gIAo+ICsvKioKPiArICoga2V4ZWNfaW1hZ2VfaW5mbyAtIEZv ciBkZWJ1Z2dpbmcgb3V0cHV0Lgo+ICsgKi8KPiArI2RlZmluZSBrZXhlY19pbWFnZV9pbmZvKF9p KSBfa2V4ZWNfaW1hZ2VfaW5mbyhfX2Z1bmNfXywgX19MSU5FX18sIF9pKQo+ICtzdGF0aWMgdm9p ZCBfa2V4ZWNfaW1hZ2VfaW5mbyhjb25zdCBjaGFyICpmdW5jLCBpbnQgbGluZSwKPiArCWNvbnN0 IHN0cnVjdCBraW1hZ2UgKmtpbWFnZSkKPiArewo+ICsJdW5zaWduZWQgbG9uZyBpOwo+ICsKPiAr CXByX2RlYnVnKCIlczolZDpcbiIsIGZ1bmMsIGxpbmUpOwo+ICsJcHJfZGVidWcoIiAga2V4ZWMg a2ltYWdlIGluZm86XG4iKTsKPiArCXByX2RlYnVnKCIgICAgdHlwZTogICAgICAgICVkXG4iLCBr aW1hZ2UtPnR5cGUpOwo+ICsJcHJfZGVidWcoIiAgICBzdGFydDogICAgICAgJWx4XG4iLCBraW1h Z2UtPnN0YXJ0KTsKPiArCXByX2RlYnVnKCIgICAgaGVhZDogICAgICAgICVseFxuIiwga2ltYWdl LT5oZWFkKTsKPiArCXByX2RlYnVnKCIgICAgbnJfc2VnbWVudHM6ICVsdVxuIiwga2ltYWdlLT5u cl9zZWdtZW50cyk7Cj4gKwo+ICsJZm9yIChpID0gMDsgaSA8IGtpbWFnZS0+bnJfc2VnbWVudHM7 IGkrKykgewo+ICsJCXByX2RlYnVnKCIgICAgICBzZWdtZW50WyVsdV06ICUwOGx4IC0gJTA4bHgs IDB4JXggYnl0ZXMsICVsdSBwYWdlc1xuIiwKPiArCQkJaSwKPiArCQkJa2ltYWdlLT5zZWdtZW50 W2ldLm1lbSwKPiArCQkJa2ltYWdlLT5zZWdtZW50W2ldLm1lbSArIGtpbWFnZS0+c2VnbWVudFtp XS5tZW1zeiwKPiArCQkJa2ltYWdlLT5zZWdtZW50W2ldLm1lbXN6LAo+ICsJCQlraW1hZ2UtPnNl Z21lbnRbaV0ubWVtc3ogLyAgUEFHRV9TSVpFKTsKPiArCX0KPiArfQo+ICsKPiAgLyoKPiAgICog UHJvdmlkZSBhIGR1bW15IGNyYXNoX25vdGVzIGRlZmluaXRpb24gd2hpbGUgY3Jhc2ggZHVtcCBh cnJpdmVzIHRvIGFybS4KPiAgICogVGhpcyBwcmV2ZW50cyBicmVha2FnZSBvZiBjcmFzaF9ub3Rl cyBhdHRyaWJ1dGUgaW4ga2VybmVsL2tzeXNmcy5jLgo+IEBAIC00Miw2ICs2OCw4IEBAIGludCBt YWNoaW5lX2tleGVjX3ByZXBhcmUoc3RydWN0IGtpbWFnZSAqaW1hZ2UpCj4gIAlfX2JlMzIgaGVh ZGVyOwo+ICAJaW50IGksIGVycjsKPiAgCj4gKwlrZXhlY19pbWFnZV9pbmZvKGltYWdlKTsKPiAr Cj4gIAlpbWFnZS0+YXJjaC5rZXJuZWxfcjIgPSBpbWFnZS0+c3RhcnQgLSBLRVhFQ19BUk1fWklN QUdFX09GRlNFVAo+ICAJCQkJICAgICArIEtFWEVDX0FSTV9BVEFHU19PRkZTRVQ7Cj4gIAo+IC0t IAo+IDIuMjYuMgo+IAo+IAoKLS0gClJNSydzIFBhdGNoIHN5c3RlbTogaHR0cHM6Ly93d3cuYXJt bGludXgub3JnLnVrL2RldmVsb3Blci9wYXRjaGVzLwpGVFRDIGZvciAwLjhtIChlc3QuIDE3NjJt KSBsaW5lIGluIHN1YnVyYmlhOiBzeW5jIGF0IDEzLjFNYnBzIGRvd24gNDI0a2JwcyB1cAoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=