From: Rikard Falkeborn <rikard.falkeborn@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Emil Velikov <emil.l.velikov@gmail.com>,
Kees Cook <keescook@chromium.org>,
Linus Walleij <linus.walleij@linaro.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kbuild test robot <lkp@intel.com>,
Syed Nayyar Waris <syednwaris@gmail.com>,
William Breathitt Gray <vilhelm.gray@gmail.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [PATCH v2 2/2] bits: Add tests of GENMASK
Date: Mon, 8 Jun 2020 20:44:26 +0200 [thread overview]
Message-ID: <20200608184426.GB899@rikard> (raw)
In-Reply-To: <CAHp75Vd94PKFSYNQ6h+ju40TwtPvLpi5gt0kCec=SJJOcM3GYQ@mail.gmail.com>
On Mon, Jun 08, 2020 at 11:08:04AM +0300, Andy Shevchenko wrote:
> On Sun, Jun 7, 2020 at 11:34 PM Rikard Falkeborn
> <rikard.falkeborn@gmail.com> wrote:
> >
> > Add tests of GENMASK and GENMASK_ULL.
> >
> > A few test cases that should fail compilation are provided under ifdef.
> >
>
> Thank you very much!
>
> > * New patch. First time I wrote a KUnittest so may be room for
> > improvements...
>
> Have you considered to unify them with existing test_bitops.h?
test_bitops.c seems to be tests for macros/functions in bitops.h, so I
figured it would make more sense to add tests of bits.h in test_bits.c.
But I don't have a strong opinion about it. If you prefer, I'll move
them to test_bitops.c.
Rikard
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2020-06-08 18:44 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 5:00 [PATCH v7 0/4] Introduce the for_each_set_clump macro Syed Nayyar Waris
2020-05-24 5:00 ` Syed Nayyar Waris
2020-05-24 5:00 ` Syed Nayyar Waris
2020-05-24 5:00 ` Syed Nayyar Waris
2020-05-24 5:01 ` [PATCH v7 1/4] bitops: Introduce the " Syed Nayyar Waris
2020-05-24 14:44 ` kbuild test robot
2020-05-24 14:44 ` kbuild test robot
2020-05-29 18:08 ` Syed Nayyar Waris
2020-05-29 18:38 ` Andy Shevchenko
2020-05-29 18:38 ` Andy Shevchenko
2020-05-29 20:02 ` Syed Nayyar Waris
2020-05-29 21:31 ` William Breathitt Gray
2020-05-29 21:53 ` Syed Nayyar Waris
2020-05-29 21:42 ` Andy Shevchenko
2020-05-29 21:42 ` Andy Shevchenko
2020-05-29 22:07 ` Andy Shevchenko
2020-05-29 22:11 ` Syed Nayyar Waris
2020-05-29 22:19 ` Andy Shevchenko
2020-05-30 8:45 ` Syed Nayyar Waris
2020-05-30 9:20 ` Andy Shevchenko
2020-05-31 1:11 ` Syed Nayyar Waris
2020-05-31 11:00 ` Andy Shevchenko
2020-05-31 22:37 ` Rikard Falkeborn
2020-06-01 0:31 ` Syed Nayyar Waris
2020-06-01 8:33 ` Andy Shevchenko
2020-06-02 19:01 ` Rikard Falkeborn
2020-06-03 8:49 ` Andy Shevchenko
2020-06-03 21:53 ` Rikard Falkeborn
2020-06-03 21:58 ` Andy Shevchenko
2020-06-03 21:59 ` Andy Shevchenko
2020-06-03 22:02 ` [PATCH] linux/bits.h: fix unsigned less than zero warnings Rikard Falkeborn
2020-06-04 6:41 ` Andy Shevchenko
2020-06-04 16:49 ` Joe Perches
2020-06-04 23:30 ` Rikard Falkeborn
2020-06-07 20:34 ` [PATCH v2 1/2] " Rikard Falkeborn
2020-06-07 20:34 ` [PATCH v2 2/2] bits: Add tests of GENMASK Rikard Falkeborn
2020-06-08 7:33 ` Geert Uytterhoeven
2020-06-08 18:42 ` Rikard Falkeborn
2020-06-08 22:18 ` [PATCH v3 1/2] linux/bits.h: fix unsigned less than zero warnings Rikard Falkeborn
2020-06-08 22:18 ` [PATCH v3 2/2] bits: Add tests of GENMASK Rikard Falkeborn
2020-06-09 14:11 ` Andy Shevchenko
2020-06-21 4:36 ` Andrew Morton
2020-06-21 5:42 ` [PATCH v4 1/2] linux/bits.h: fix unsigned less than zero warnings Rikard Falkeborn
2020-06-21 5:42 ` [PATCH v4 2/2] bits: Add tests of GENMASK Rikard Falkeborn
2021-04-22 19:40 ` Nico Pache
2021-04-22 21:30 ` Nico Pache
2020-07-09 12:30 ` [PATCH v4 1/2] linux/bits.h: fix unsigned less than zero warnings Herbert Xu
2020-07-09 12:30 ` Herbert Xu
2020-07-09 12:30 ` Herbert Xu
2020-07-09 18:13 ` Linus Torvalds
2020-07-10 6:38 ` Herbert Xu
2020-06-15 19:52 ` [PATCH v3 " Emil Velikov
2020-06-08 8:08 ` [PATCH v2 2/2] bits: Add tests of GENMASK Andy Shevchenko
2020-06-08 8:08 ` Andy Shevchenko
2020-06-08 18:44 ` Rikard Falkeborn [this message]
2020-06-08 11:09 ` [PATCH v2 1/2] linux/bits.h: fix unsigned less than zero warnings Andy Shevchenko
2020-05-24 5:04 ` [PATCH v7 2/4] lib/test_bitmap.c: Add for_each_set_clump test cases Syed Nayyar Waris
2020-05-30 19:20 ` kbuild test robot
2020-05-30 19:20 ` kbuild test robot
2020-06-04 20:42 ` Syed Nayyar Waris
2020-06-05 12:24 ` Andy Shevchenko
2020-06-05 12:24 ` Andy Shevchenko
2020-06-06 23:15 ` Syed Nayyar Waris
2020-06-08 13:18 ` Andy Shevchenko
2020-06-08 13:18 ` Andy Shevchenko
2020-06-10 5:38 ` Rong Chen
2020-06-10 5:38 ` Rong Chen
2020-05-24 5:05 ` [PATCH v7 3/4] gpio: thunderx: Utilize for_each_set_clump macro Syed Nayyar Waris
2020-05-24 5:06 ` [PATCH v7 4/4] gpio: xilinx: " Syed Nayyar Waris
2020-05-24 5:06 ` Syed Nayyar Waris
2020-05-25 9:36 ` [PATCH v7 0/4] Introduce the " Bartosz Golaszewski
2020-05-25 9:36 ` Bartosz Golaszewski
2020-06-15 12:46 ` Syed Nayyar Waris
2020-06-15 12:46 ` Syed Nayyar Waris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608184426.GB899@rikard \
--to=rikard.falkeborn@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=emil.l.velikov@gmail.com \
--cc=keescook@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=syednwaris@gmail.com \
--cc=vilhelm.gray@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.