From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3AA2C433E1 for ; Mon, 13 Jul 2020 12:10:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DBA520773 for ; Mon, 13 Jul 2020 12:10:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intenta.de header.i=@intenta.de header.b="inf5MulV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729027AbgGMMKZ (ORCPT ); Mon, 13 Jul 2020 08:10:25 -0400 Received: from mail.intenta.de ([178.249.25.132]:34971 "EHLO mail.intenta.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728714AbgGMMKZ (ORCPT ); Mon, 13 Jul 2020 08:10:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=intenta.de; s=dkim1; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:CC:To:From:Date; bh=1FfHxGk9Fkq4rbXPd8sX91QgCFVfWDb1d+CXYS3YaHM=; b=inf5MulVjWhipWbArKPDwNh25OqJ9z+5Ul/bTDyK+Zj8W8PmEQKjGrpTZaCEDkCzN+V45PZAlKC+6drpa+4ZKb0OI5DBKL2PfPHnXZDM5Zwy6cAD05+T7ad50dK/eHK0hdixmZq2FUWm8b/ZehcKYf/+1buSle6Frv8AIpFxX6GKkVSMbDasPvDaRi1CMDhjHfCS6+5PkWbKkzK8DIF6Y5WtH4NASeDXgwJXDsQQiEyVLBMEQM5nBfMm9z3zLMwfk3W/90Co7WIGCet6WvIgZ8XPvtIummjHEU+QRr3QWTUwMR9BVYrGXLG9kkrb0SVQoTOFAGZ4+n3qS0XcNmY14g==; Date: Mon, 13 Jul 2020 14:10:19 +0200 From: Helmut Grohne To: Michal Simek CC: Greg Kroah-Hartman , Jiri Slaby , Shubhrajyoti Datta , "Jan Kiszka" , , Subject: Re: [PATCH] tty: xilinx_uartps: Really fix id assignment Message-ID: <20200713121019.GA6920@laureti-dev> References: <20200709074849.GA28968@laureti-dev> <20200713071123.GA1994@laureti-dev> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: ICSMA002.intenta.de (10.10.16.48) To ICSMA002.intenta.de (10.10.16.48) Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Hi Michal, On Mon, Jul 13, 2020 at 01:49:38PM +0200, Michal Simek wrote: > On 13. 07. 20 9:11, Helmut Grohne wrote: > > Let me try to enumerate those I know: > > > > uart0 | uart1 | console | remark > > ---------+----------+---------+---------- > > serial0 | serial1 | ttyPS0 | regular case > > serial0 | serial1 | ttyPS1 | normal assignment, second console > > serial1 | serial0 | ttyPS0 | -> Jan Kiszka, broken since revert > > disabled | serial0 | ttyPS0 | use only uart1 as serial0 > > serial0 | disabled | ttyPS0 | regular case with uart1 disabled > > > > Out of these, I'm actively using configurations 3 and 4. > > > > Which of these scenarios do you test already? > > For above we are missing also others > serial1 | serial0 | ttyPS1 > disabled| serial1 | ttyPS1 Is it actually possible to have ttyPS1, but no ttyPS0? I think I tried doing that earlier and it resulted in there being ttyPS0, but no ttyPS1. > serial1 | disables | ttyPS0 I'm not sure what this is supposed to mean. When there is no serial0 alias, I'd expect ttyPS0 to be missing. However as indicated above that is not what happens in practice. So either of these two configurations seems invalid to me. > All of these above are just not setting any console= on bootargs. We usually set the console= assignment on bootargs. > It means mix of these combinations is tested regularly but not all of > them. Do you see any other combination which is not supported? I'm not aware of further relevant combinations. Can we maybe trim down the matrix somehow? In my context, the need for swapping the serial aliases arises from a limitation in u-boot-xlnx and the desire to use one dtb for both linux and u-boot. It requires that the serial0 alias is the console. Are there other reasons to swap them? If not, maybe fixing u-boot would be an option? Helmut From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 895C9C433E3 for ; Mon, 13 Jul 2020 12:11:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5682A2072D for ; Mon, 13 Jul 2020 12:11:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bW5nb+Cc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intenta.de header.i=@intenta.de header.b="inf5MulV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5682A2072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intenta.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kaaxY3tEV+grVqbQYy4l3gityF+8ttIyf3vIKRtOBPU=; b=bW5nb+CcrWydRHGjcCpW9OcPr HaRnhhiLVtUWa1EkUPt7ddJSLOI673PYzKiUrD3bOYRm8u0b6zVGQ3BHeb/e9zB6bUzWHvm/ioDQl kHj+jqbq04o8cD4XoVFBWPoqBgSw9H6O3bOPgHXYs0hIWiMzOVpaA60mvRCtZn0NNrFYk50JLrqSI 9wqz7nzMQPQWhgTA+0rsqU8iO0fNel0iqV8D7gTEOyplzTuIa6K31cLij1x1mJ3jkLGNaCATPQOo7 FKtLun5Xdi5TaIdILusPxq88lWnH68/3nFO4BZxDInnnLOvqSdQLN4VoBy3jwzkBxsKU45Dnf9Y9v bc9X7TmFQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1juxHx-0006EG-6p; Mon, 13 Jul 2020 12:10:29 +0000 Received: from mail.intenta.de ([178.249.25.132]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1juxHt-0006Dp-PT for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 12:10:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=intenta.de; s=dkim1; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:CC:To:From:Date; bh=1FfHxGk9Fkq4rbXPd8sX91QgCFVfWDb1d+CXYS3YaHM=; b=inf5MulVjWhipWbArKPDwNh25OqJ9z+5Ul/bTDyK+Zj8W8PmEQKjGrpTZaCEDkCzN+V45PZAlKC+6drpa+4ZKb0OI5DBKL2PfPHnXZDM5Zwy6cAD05+T7ad50dK/eHK0hdixmZq2FUWm8b/ZehcKYf/+1buSle6Frv8AIpFxX6GKkVSMbDasPvDaRi1CMDhjHfCS6+5PkWbKkzK8DIF6Y5WtH4NASeDXgwJXDsQQiEyVLBMEQM5nBfMm9z3zLMwfk3W/90Co7WIGCet6WvIgZ8XPvtIummjHEU+QRr3QWTUwMR9BVYrGXLG9kkrb0SVQoTOFAGZ4+n3qS0XcNmY14g==; Date: Mon, 13 Jul 2020 14:10:19 +0200 From: Helmut Grohne To: Michal Simek Subject: Re: [PATCH] tty: xilinx_uartps: Really fix id assignment Message-ID: <20200713121019.GA6920@laureti-dev> References: <20200709074849.GA28968@laureti-dev> <20200713071123.GA1994@laureti-dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: ICSMA002.intenta.de (10.10.16.48) To ICSMA002.intenta.de (10.10.16.48) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_081026_280999_AD246AB4 X-CRM114-Status: GOOD ( 13.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Shubhrajyoti Datta , Jan Kiszka , linux-serial@vger.kernel.org, Jiri Slaby , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Michal, On Mon, Jul 13, 2020 at 01:49:38PM +0200, Michal Simek wrote: > On 13. 07. 20 9:11, Helmut Grohne wrote: > > Let me try to enumerate those I know: > > > > uart0 | uart1 | console | remark > > ---------+----------+---------+---------- > > serial0 | serial1 | ttyPS0 | regular case > > serial0 | serial1 | ttyPS1 | normal assignment, second console > > serial1 | serial0 | ttyPS0 | -> Jan Kiszka, broken since revert > > disabled | serial0 | ttyPS0 | use only uart1 as serial0 > > serial0 | disabled | ttyPS0 | regular case with uart1 disabled > > > > Out of these, I'm actively using configurations 3 and 4. > > > > Which of these scenarios do you test already? > > For above we are missing also others > serial1 | serial0 | ttyPS1 > disabled| serial1 | ttyPS1 Is it actually possible to have ttyPS1, but no ttyPS0? I think I tried doing that earlier and it resulted in there being ttyPS0, but no ttyPS1. > serial1 | disables | ttyPS0 I'm not sure what this is supposed to mean. When there is no serial0 alias, I'd expect ttyPS0 to be missing. However as indicated above that is not what happens in practice. So either of these two configurations seems invalid to me. > All of these above are just not setting any console= on bootargs. We usually set the console= assignment on bootargs. > It means mix of these combinations is tested regularly but not all of > them. Do you see any other combination which is not supported? I'm not aware of further relevant combinations. Can we maybe trim down the matrix somehow? In my context, the need for swapping the serial aliases arises from a limitation in u-boot-xlnx and the desire to use one dtb for both linux and u-boot. It requires that the serial0 alias is the console. Are there other reasons to swap them? If not, maybe fixing u-boot would be an option? Helmut _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel