All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 02/25] target/arm: Fix mtedesc for do_mem_zpz
Date: Mon, 13 Jul 2020 15:10:41 +0100	[thread overview]
Message-ID: <20200713141104.5139-3-peter.maydell@linaro.org> (raw)
In-Reply-To: <20200713141104.5139-1-peter.maydell@linaro.org>

From: Richard Henderson <richard.henderson@linaro.org>

The mtedesc that was constructed was not actually passed in.
Found by Coverity (CID 1429996).

Fixes: d28d12f008e
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20200706202345.193676-1-richard.henderson@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/translate-sve.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
index 08f0fd15b28..88a2fb271d1 100644
--- a/target/arm/translate-sve.c
+++ b/target/arm/translate-sve.c
@@ -5275,7 +5275,7 @@ static void do_mem_zpz(DisasContext *s, int zt, int pg, int zm,
         desc = FIELD_DP32(desc, MTEDESC, ESIZE, 1 << msz);
         desc <<= SVE_MTEDESC_SHIFT;
     }
-    desc = simd_desc(vsz, vsz, scale);
+    desc = simd_desc(vsz, vsz, desc | scale);
     t_desc = tcg_const_i32(desc);
 
     tcg_gen_addi_ptr(t_pg, cpu_env, pred_full_reg_offset(s, pg));
-- 
2.20.1



  parent reply	other threads:[~2020-07-13 14:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-13 14:10 [PULL 00/25] target-arm queue Peter Maydell
2020-07-13 14:10 ` [PULL 01/25] hw/arm/bcm2836: Remove unused 'cpu_type' field Peter Maydell
2020-07-13 14:10 ` Peter Maydell [this message]
2020-07-13 14:10 ` [PULL 03/25] Add the ability to change the FEC PHY MDIO device number on i.MX25 processor Peter Maydell
2020-07-13 14:10 ` [PULL 04/25] Add the ability to change the FEC PHY MDIO device number on i.MX6 processor Peter Maydell
2020-07-13 14:10 ` [PULL 05/25] Add the ability to change the FEC PHY MDIO devices numbers on i.MX7 processor Peter Maydell
2020-07-13 14:10 ` [PULL 06/25] target/arm: Don't do raw writes for PMINTENCLR Peter Maydell
2020-07-13 14:10 ` [PULL 07/25] virtio-iommu: Fix coverity issue in virtio_iommu_handle_command() Peter Maydell
2020-07-13 14:10 ` [PULL 08/25] build: Enable BSD symbols for Haiku Peter Maydell
2020-07-13 14:10 ` [PULL 09/25] util/qemu-openpty.c: Don't assume pty.h is glibc-only Peter Maydell
2020-07-13 14:10 ` [PULL 10/25] build: Check that mlockall() exists Peter Maydell
2020-07-13 14:10 ` [PULL 11/25] osdep.h: Always include <sys/signal.h> if it exists Peter Maydell
2020-07-13 14:10 ` [PULL 12/25] osdep.h: For Haiku, define SIGIO as equivalent to SIGPOLL Peter Maydell
2020-07-13 14:10 ` [PULL 13/25] bswap.h: Include <endian.h> on Haiku for bswap operations Peter Maydell
2020-07-13 14:10 ` [PULL 14/25] util/compatfd.c: Only include <sys/syscall.h> if CONFIG_SIGNALFD Peter Maydell
2020-07-13 14:10 ` [PULL 15/25] util/oslib-posix.c: Implement qemu_init_exec_dir() for Haiku Peter Maydell
2020-07-13 14:10 ` [PULL 16/25] util/drm: make portable by avoiding struct dirent d_type Peter Maydell
2020-07-13 14:10 ` [PULL 17/25] target/nios2: add DISAS_NORETURN case for nothing more to generate Peter Maydell
2020-07-13 14:10 ` [PULL 18/25] target/nios2: in line the semantics of DISAS_UPDATE with other targets Peter Maydell
2020-07-13 14:10 ` [PULL 19/25] target/nios2: Use gen_io_start around wrctl instruction Peter Maydell
2020-07-13 14:10 ` [PULL 20/25] hw/nios2: exit to main CPU loop only when unmasking interrupts Peter Maydell
2020-07-13 14:11 ` [PULL 21/25] hw/arm/tosa.c: Detabify Peter Maydell
2020-07-13 14:11 ` [PULL 22/25] hw/arm/tosa: Encapsulate misc GPIO handling in a device Peter Maydell
2020-07-13 14:11 ` [PULL 23/25] hw/arm/palm.c: Detabify Peter Maydell
2020-07-13 14:11 ` [PULL 24/25] hw/arm/palm.c: Encapsulate misc GPIO handling in a device Peter Maydell
2020-07-13 14:11 ` [PULL 25/25] hw/arm/aspeed: Do not create and attach empty SD cards by default Peter Maydell
2020-07-13 15:58 ` [PULL 00/25] target-arm queue Peter Maydell
2020-07-14 14:52   ` Wu, Wentong
2020-07-14 14:55     ` Peter Maydell
2020-07-14 15:03       ` Wu, Wentong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200713141104.5139-3-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.