From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 04/21] devtmpfs: refactor devtmpfsd() Date: Sun, 26 Jul 2020 09:43:06 +0200 Message-ID: <20200726074306.GA444745@kroah.com> References: <20200726071356.287160-1-hch@lst.de> <20200726071356.287160-5-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200726071356.287160-5-hch-jcswGhMUV9g@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Christoph Hellwig Cc: Al Viro , Linus Torvalds , "Rafael J. Wysocki" , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-raid.ids On Sun, Jul 26, 2020 at 09:13:39AM +0200, Christoph Hellwig wrote: > Split the main worker loop into a separate function. This allows > devtmpfsd itself and devtmpfsd_setup to be marked __init, which will > allows us to call __init routines for the setup work. > > Signed-off-by: Christoph Hellwig > --- > drivers/base/devtmpfs.c | 47 +++++++++++++++++++++++------------------ > 1 file changed, 26 insertions(+), 21 deletions(-) Nice cleanup, thanks for doing this: Reviewed-by: Greg Kroah-Hartman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD7B8C433E4 for ; Sun, 26 Jul 2020 07:43:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACA4C20715 for ; Sun, 26 Jul 2020 07:43:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595749394; bh=4rKZH64Zbiy83+h01nqKrcL6n0VVrtwg4ZMe+QZwIRo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=VB4nXyYWfS7w1N14Owz+v6L+x34x5Y/kU24BkPOOVz69T4NrhUiYbr0yCCF8t1I/+ PusI1q4NOlvrAIX20ZSU2TmYgRoDwyNsUJ5IVbuC0a5wwUNU24DrjuzqW4Y19UAyoq HMJpkeUSXeZgqOjOUszHbWhWht6X2UaILhfrX9xQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726857AbgGZHnL (ORCPT ); Sun, 26 Jul 2020 03:43:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:37660 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725810AbgGZHnK (ORCPT ); Sun, 26 Jul 2020 03:43:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 76B1E2065F; Sun, 26 Jul 2020 07:43:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595749389; bh=4rKZH64Zbiy83+h01nqKrcL6n0VVrtwg4ZMe+QZwIRo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HY0hQztRqLg6G8Q0yBnmMqG005o1z+P1Yc2ak3vJ4d51ZZboJIrkjsNc3e3yjGEC/ QpD3EzKSp8Ok5LWLMxylIjGQaYkKLB0NVOxQfBkipq4ujre5F/pUD7W7BYzy4lkHcd uJlYa8c52/5k4hjHAGC4y16hYKzoM7k+OXYG2YEY= Date: Sun, 26 Jul 2020 09:43:06 +0200 From: Greg Kroah-Hartman To: Christoph Hellwig Cc: Al Viro , Linus Torvalds , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH 04/21] devtmpfs: refactor devtmpfsd() Message-ID: <20200726074306.GA444745@kroah.com> References: <20200726071356.287160-1-hch@lst.de> <20200726071356.287160-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200726071356.287160-5-hch@lst.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 26, 2020 at 09:13:39AM +0200, Christoph Hellwig wrote: > Split the main worker loop into a separate function. This allows > devtmpfsd itself and devtmpfsd_setup to be marked __init, which will > allows us to call __init routines for the setup work. > > Signed-off-by: Christoph Hellwig > --- > drivers/base/devtmpfs.c | 47 +++++++++++++++++++++++------------------ > 1 file changed, 26 insertions(+), 21 deletions(-) Nice cleanup, thanks for doing this: Reviewed-by: Greg Kroah-Hartman