All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andrey Konovalov" <andrey.konovalov@linaro.org>
To: openembedded-devel@lists.openembedded.org
Cc: madhavan.krishnan@linaro.org, raj.khem@gmail.com,
	peter.griffin@linaro.org, libcamera-devel@lists.libcamera.org,
	Andrey Konovalov <andrey.konovalov@linaro.org>
Subject: [meta-multimedia][PATCH] libcamera: fix packaging and installation
Date: Mon, 27 Jul 2020 12:21:08 +0300	[thread overview]
Message-ID: <20200727092108.6209-1-andrey.konovalov@linaro.org> (raw)

libcamera checks if RPATH or RUNPATH dynamic tag is present in
libcamera.so. If it does, it assumes that libcamera binaries are
run directly from the build directory without installing them, and
tries to use resorces like IPA modules from the build directory.
Mainline meson strips RPATH/RUNPATH out at install time (for
meson versions up to 0.54; the things are somewhat changed in 0.55).
But openembedded-core patches meson to disable RPATH/RUNPATH removal.
That's why we need to remove this tag manually in do_install_append().

IPA module is signed (with openssl dgst) after it is built. But
during packaging the OE build system 1) splits out debugging info,
and 2) strips the binaries. So the IPA module *.so file installed
isn't the one which the signature was calculated against. Then
the signature check fails, and libcamera tries to run the IPA
module isolated (in a sandbox), which doesn't work if the IPA
module wasn't designed to run isolated. The easiest way to fix that
is to disable splitting out debug information and stripping the binaries
during packaging with INHIBIT_PACKAGE_DEBUG_SPLIT and
INHIBIT_PACKAGE_STRIP.

Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>
---
 .../recipes-multimedia/libcamera/libcamera.bb            | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/meta-multimedia/recipes-multimedia/libcamera/libcamera.bb b/meta-multimedia/recipes-multimedia/libcamera/libcamera.bb
index 00a5c480d..573366f08 100644
--- a/meta-multimedia/recipes-multimedia/libcamera/libcamera.bb
+++ b/meta-multimedia/recipes-multimedia/libcamera/libcamera.bb
@@ -18,13 +18,20 @@ PV = "202006+git${SRCPV}"
 
 S = "${WORKDIR}/git"
 
-DEPENDS = "python3-pyyaml-native udev gnutls boost"
+DEPENDS = "python3-pyyaml-native udev gnutls boost chrpath-native"
 DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'qt', 'qtbase qtbase-native', '', d)}"
 
 RDEPENDS_${PN} = "${@bb.utils.contains('DISTRO_FEATURES', 'wayland qt', 'qtwayland', '', d)}"
 
 inherit meson pkgconfig python3native
 
+do_install_append() {
+        chrpath -d ${D}${libdir}/libcamera.so
+}
+
 FILES_${PN}-dev = "${includedir} ${libdir}/pkgconfig"
 FILES_${PN} += " ${libdir}/libcamera.so"
 
+INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
+INHIBIT_PACKAGE_STRIP = "1"
+
-- 
2.17.1


             reply	other threads:[~2020-07-27  9:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27  9:21 Andrey Konovalov [this message]
     [not found] ` <a17180dc-a0ee-80b1-8c55-ee1c42d20e9e@ideasonboard.com>
2020-07-27  9:58   ` [libcamera-devel] [meta-multimedia][PATCH] libcamera: fix packaging and installation Andrey Konovalov
2020-07-27 11:11     ` Laurent Pinchart
2020-07-27 15:37       ` [oe] " Khem Raj
2020-07-27 15:43         ` Laurent Pinchart
2020-07-27 15:46       ` Andrey Konovalov
2020-07-27 16:03         ` Laurent Pinchart
2020-07-27 16:17           ` Andrey Konovalov
2020-07-28  0:40             ` Laurent Pinchart
2020-07-27 15:31     ` Khem Raj
2020-07-27 15:28 ` Khem Raj
2020-07-27 15:36   ` Andrey Konovalov
2020-07-27 15:38     ` Khem Raj
2020-07-27 15:56       ` Andrey Konovalov
2020-07-27 15:45     ` [libcamera-devel] " Laurent Pinchart
2020-07-27 15:51       ` Andrey Konovalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200727092108.6209-1-andrey.konovalov@linaro.org \
    --to=andrey.konovalov@linaro.org \
    --cc=libcamera-devel@lists.libcamera.org \
    --cc=madhavan.krishnan@linaro.org \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=peter.griffin@linaro.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.