From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 115F9C433E0 for ; Mon, 10 Aug 2020 09:21:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EEE2520734 for ; Mon, 10 Aug 2020 09:21:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726675AbgHJJVo (ORCPT ); Mon, 10 Aug 2020 05:21:44 -0400 Received: from mga04.intel.com ([192.55.52.120]:63148 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726310AbgHJJVo (ORCPT ); Mon, 10 Aug 2020 05:21:44 -0400 IronPort-SDR: LHhCCIJDB02ky4uH86BEvz5/7W3PxAjBDTFkgEdNjLCD9mVV8ag97fRTGQHej1QspmrYMPQREg uqRfugsq7yuw== X-IronPort-AV: E=McAfee;i="6000,8403,9708"; a="150936645" X-IronPort-AV: E=Sophos;i="5.75,457,1589266800"; d="scan'208";a="150936645" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2020 02:21:43 -0700 IronPort-SDR: lJ+AjjmZNrGkYBBEqN0szbQUT5QLSC5pVmEPD1kdHBqJMGBjM67IVNuWfxfkP+ZhJVnsBz1mL7 plRqJJF01Myw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,457,1589266800"; d="scan'208";a="294327539" Received: from lkp-server02.sh.intel.com (HELO 5ad9e2f13e37) ([10.239.97.151]) by orsmga006.jf.intel.com with ESMTP; 10 Aug 2020 02:21:40 -0700 Received: from kbuild by 5ad9e2f13e37 with local (Exim 4.92) (envelope-from ) id 1k53zv-0000U1-FC; Mon, 10 Aug 2020 09:21:39 +0000 Date: Mon, 10 Aug 2020 17:21:00 +0800 From: kernel test robot To: Denis Efremov Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Julia Lawall , Bartlomiej Zolnierkiewicz , Daniel Vetter , Nathan Chancellor , Sam Ravnborg , Alex Deucher , Qiujun Huang , Peter Rosin , dri-devel@lists.freedesktop.org Subject: [PATCH] coccinelle: api: fix device_attr_show.cocci warnings Message-ID: <20200810092100.GA42813@2f5448a72a42> References: <202008101736.EtK0s7BQ%lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202008101736.EtK0s7BQ%lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kernel test robot drivers/video/fbdev/core/fbcon.c:3509:8-16: WARNING: use scnprintf or sprintf drivers/video/fbdev/core/fbcon.c:3484:8-16: WARNING: use scnprintf or sprintf From Documentation/filesystems/sysfs.txt: show() must not use snprintf() when formatting the value to be returned to user space. If you can guarantee that an overflow will never happen you can use sprintf() otherwise you must use scnprintf(). Generated by: scripts/coccinelle/api/device_attr_show.cocci Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script") CC: Denis Efremov Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: fc80c51fd4b23ec007e88d4c688f2cac1b8648e7 commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script Please take the patch only if it's a positive warning. Thanks! fbcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -3481,7 +3481,7 @@ static ssize_t show_rotate(struct device rotate = fbcon_get_rotate(info); err: console_unlock(); - return snprintf(buf, PAGE_SIZE, "%d\n", rotate); + return scnprintf(buf, PAGE_SIZE, "%d\n", rotate); } static ssize_t show_cursor_blink(struct device *device, @@ -3506,7 +3506,7 @@ static ssize_t show_cursor_blink(struct blink = (ops->flags & FBCON_FLAGS_CURSOR_TIMER) ? 1 : 0; err: console_unlock(); - return snprintf(buf, PAGE_SIZE, "%d\n", blink); + return scnprintf(buf, PAGE_SIZE, "%d\n", blink); } static ssize_t store_cursor_blink(struct device *device, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 890EAC433DF for ; Mon, 10 Aug 2020 09:21:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60DCB20709 for ; Mon, 10 Aug 2020 09:21:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60DCB20709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BB8B96E3DF; Mon, 10 Aug 2020 09:21:44 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9867489E03 for ; Mon, 10 Aug 2020 09:21:43 +0000 (UTC) IronPort-SDR: JX+gGseZVbUeuYDPQWRIhmRyWuBNW9kZtmBQjxQTXGuy2E5y99ylmwgnd1YjJsOrAyqM+fhHB7 YcCVDvCWMjog== X-IronPort-AV: E=McAfee;i="6000,8403,9708"; a="151190911" X-IronPort-AV: E=Sophos;i="5.75,457,1589266800"; d="scan'208";a="151190911" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2020 02:21:43 -0700 IronPort-SDR: lJ+AjjmZNrGkYBBEqN0szbQUT5QLSC5pVmEPD1kdHBqJMGBjM67IVNuWfxfkP+ZhJVnsBz1mL7 plRqJJF01Myw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,457,1589266800"; d="scan'208";a="294327539" Received: from lkp-server02.sh.intel.com (HELO 5ad9e2f13e37) ([10.239.97.151]) by orsmga006.jf.intel.com with ESMTP; 10 Aug 2020 02:21:40 -0700 Received: from kbuild by 5ad9e2f13e37 with local (Exim 4.92) (envelope-from ) id 1k53zv-0000U1-FC; Mon, 10 Aug 2020 09:21:39 +0000 Date: Mon, 10 Aug 2020 17:21:00 +0800 From: kernel test robot To: Denis Efremov Subject: [PATCH] coccinelle: api: fix device_attr_show.cocci warnings Message-ID: <20200810092100.GA42813@2f5448a72a42> References: <202008101736.EtK0s7BQ%lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202008101736.EtK0s7BQ%lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kbuild-all@lists.01.org, Bartlomiej Zolnierkiewicz , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Julia Lawall , Alex Deucher , Nathan Chancellor , Sam Ravnborg , Peter Rosin , Qiujun Huang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: kernel test robot drivers/video/fbdev/core/fbcon.c:3509:8-16: WARNING: use scnprintf or sprintf drivers/video/fbdev/core/fbcon.c:3484:8-16: WARNING: use scnprintf or sprintf From Documentation/filesystems/sysfs.txt: show() must not use snprintf() when formatting the value to be returned to user space. If you can guarantee that an overflow will never happen you can use sprintf() otherwise you must use scnprintf(). Generated by: scripts/coccinelle/api/device_attr_show.cocci Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script") CC: Denis Efremov Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: fc80c51fd4b23ec007e88d4c688f2cac1b8648e7 commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script Please take the patch only if it's a positive warning. Thanks! fbcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -3481,7 +3481,7 @@ static ssize_t show_rotate(struct device rotate = fbcon_get_rotate(info); err: console_unlock(); - return snprintf(buf, PAGE_SIZE, "%d\n", rotate); + return scnprintf(buf, PAGE_SIZE, "%d\n", rotate); } static ssize_t show_cursor_blink(struct device *device, @@ -3506,7 +3506,7 @@ static ssize_t show_cursor_blink(struct blink = (ops->flags & FBCON_FLAGS_CURSOR_TIMER) ? 1 : 0; err: console_unlock(); - return snprintf(buf, PAGE_SIZE, "%d\n", blink); + return scnprintf(buf, PAGE_SIZE, "%d\n", blink); } static ssize_t store_cursor_blink(struct device *device, _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6134546687770495632==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: [PATCH] coccinelle: api: fix device_attr_show.cocci warnings Date: Mon, 10 Aug 2020 17:21:00 +0800 Message-ID: <20200810092100.GA42813@2f5448a72a42> In-Reply-To: <202008101736.EtK0s7BQ%lkp@intel.com> List-Id: --===============6134546687770495632== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: kernel test robot drivers/video/fbdev/core/fbcon.c:3509:8-16: WARNING: use scnprintf or sprin= tf drivers/video/fbdev/core/fbcon.c:3484:8-16: WARNING: use scnprintf or sprin= tf From Documentation/filesystems/sysfs.txt: show() must not use snprintf() when formatting the value to be returned to user space. If you can guarantee that an overflow will never happen you can use sprintf() otherwise you must use scnprintf(). Generated by: scripts/coccinelle/api/device_attr_show.cocci Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script") CC: Denis Efremov Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: fc80c51fd4b23ec007e88d4c688f2cac1b8648e7 commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add devic= e_attr_show script Please take the patch only if it's a positive warning. Thanks! fbcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -3481,7 +3481,7 @@ static ssize_t show_rotate(struct device rotate =3D fbcon_get_rotate(info); err: console_unlock(); - return snprintf(buf, PAGE_SIZE, "%d\n", rotate); + return scnprintf(buf, PAGE_SIZE, "%d\n", rotate); } = static ssize_t show_cursor_blink(struct device *device, @@ -3506,7 +3506,7 @@ static ssize_t show_cursor_blink(struct blink =3D (ops->flags & FBCON_FLAGS_CURSOR_TIMER) ? 1 : 0; err: console_unlock(); - return snprintf(buf, PAGE_SIZE, "%d\n", blink); + return scnprintf(buf, PAGE_SIZE, "%d\n", blink); } = static ssize_t store_cursor_blink(struct device *device, --===============6134546687770495632==--