From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8071614841022041319==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: ifnullfree: fix ifnullfree.cocci warnings Date: Thu, 03 Sep 2020 03:41:01 +0800 Message-ID: <20200902194101.GA94484@ef6594e38abe> In-Reply-To: <202009030342.3rHLGgR4%lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============8071614841022041319== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org TO: Denis Efremov CC: Julia Lawall CC: Lucas Stach CC: Russell King CC: Christian Gmeiner CC: David Airlie CC: Daniel Vetter CC: etnaviv(a)lists.freedesktop.org CC: dri-devel(a)lists.freedesktop.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c:81:2-8: WARNING: NULL check bef= ore some freeing functions is not needed. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci Fixes: 5f80f474a2c3 ("coccinelle: ifnullfree: add vfree(), kvfree*() functi= ons") CC: Denis Efremov Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git f= or-5.10 head: 5f80f474a2c330a8e8e30e844f1a06811f082963 commit: 5f80f474a2c330a8e8e30e844f1a06811f082963 [5/5] coccinelle: ifnullfr= ee: add vfree(), kvfree*() functions :::::: branch date: 13 hours ago :::::: commit date: 13 hours ago Please take the patch only if it's a positive warning. Thanks! etnaviv_gem_prime.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c @@ -77,8 +77,7 @@ static void etnaviv_gem_prime_release(st /* Don't drop the pages for imported dmabuf, as they are not * ours, just free the array we allocated: */ - if (etnaviv_obj->pages) - kvfree(etnaviv_obj->pages); + kvfree(etnaviv_obj->pages); = drm_prime_gem_destroy(&etnaviv_obj->base, etnaviv_obj->sgt); } --===============8071614841022041319==--