From: Vladimir Oltean <olteanv@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: davem@davemloft.net, vivien.didelot@gmail.com, andrew@lunn.ch,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 4/4] net: dsa: set configure_vlan_while_not_filtering to true by default
Date: Tue, 8 Sep 2020 13:33:10 +0300 [thread overview]
Message-ID: <20200908103310.ttqh56cr2jyugblw@skbuf> (raw)
In-Reply-To: <961ac1bd-6744-23ef-046f-4b7d8c4413a4@gmail.com>
On Mon, Sep 07, 2020 at 09:07:34PM -0700, Florian Fainelli wrote:
> You should be able to make b53 and bcm_sf2 also use
> configure_vlan_while_not_filtering to true (or rather not specify it), give
> me until tomorrow to run various tests if you don't mind.
Ok, but I would prefer not doing that in this patch.
Note that, given a choice, I try to avoid introducing functional changes
in drivers where I don't have the hardware to test, or somebody to
confirm that it works, at the very least.
For that reason, mv88e6xxx doesn't even have this flag set, even though
Russell had sent a patch for it with the old name:
https://lore.kernel.org/netdev/E1ij6pq-00084C-47@rmk-PC.armlinux.org.uk/
Somebody with a Marvell switch should probably pick that up and resend.
Thanks,
-Vladimir
next prev parent reply other threads:[~2020-09-08 10:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 18:29 [PATCH net-next 0/4] Some VLAN handling cleanup in DSA Vladimir Oltean
2020-09-07 18:29 ` [PATCH net-next 1/4] net: dsa: tag_8021q: include missing refcount.h Vladimir Oltean
2020-09-08 4:07 ` Florian Fainelli
2020-09-07 18:29 ` [PATCH net-next 2/4] net: dsa: tag_8021q: add a context structure Vladimir Oltean
2020-09-07 18:29 ` [PATCH net-next 3/4] Revert "net: dsa: Add more convenient functions for installing port VLANs" Vladimir Oltean
2020-09-07 18:29 ` [PATCH net-next 4/4] net: dsa: set configure_vlan_while_not_filtering to true by default Vladimir Oltean
2020-09-08 4:07 ` Florian Fainelli
2020-09-08 10:33 ` Vladimir Oltean [this message]
2020-09-08 22:28 ` Florian Fainelli
2020-09-09 0:02 ` Florian Fainelli
2020-09-09 16:31 ` Vladimir Oltean
2020-09-09 17:22 ` Florian Fainelli
2020-09-09 17:53 ` Vladimir Oltean
2020-09-09 18:34 ` Florian Fainelli
2020-09-10 21:58 ` Florian Fainelli
2020-09-11 0:03 ` Vladimir Oltean
2020-09-11 3:09 ` Florian Fainelli
2020-09-11 15:43 ` Vladimir Oltean
2020-09-11 18:23 ` Florian Fainelli
2020-09-11 18:35 ` Vladimir Oltean
2020-09-11 19:39 ` Florian Fainelli
2020-09-11 19:48 ` Florian Fainelli
2020-09-11 22:30 ` Vladimir Oltean
2020-09-08 10:14 ` Kurt Kanzenbach
2020-09-08 10:29 ` Vladimir Oltean
2020-10-02 8:06 ` Kurt Kanzenbach
2020-10-02 8:15 ` Vladimir Oltean
2020-10-03 7:52 ` Vladimir Oltean
2020-10-03 9:45 ` Kurt Kanzenbach
2020-10-04 10:56 ` Vladimir Oltean
2020-10-05 12:34 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908103310.ttqh56cr2jyugblw@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.