From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1868C433E2 for ; Tue, 8 Sep 2020 20:05:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C0F020658 for ; Tue, 8 Sep 2020 20:05:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="nerJ56Bo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732174AbgIHUFO (ORCPT ); Tue, 8 Sep 2020 16:05:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730172AbgIHPWE (ORCPT ); Tue, 8 Sep 2020 11:22:04 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3875AC09B04E; Tue, 8 Sep 2020 07:47:07 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3646247; Tue, 8 Sep 2020 16:46:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1599576410; bh=RSK952bhlHi49suHIZc7d6qiORR1jel+b2zV6JRNGfA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nerJ56Bo/ACyXiuYStye+Z40isGeZr0T2w7UunIrue9jbV1y0Tp/EGavuLZCwNJLJ Xqlrz+7LrtNvNUdobIaX68MI0x5n5vtmqPihbFui2aeIU8XngIcl4e3C7mOP8SNIF2 4jmQZ60eIe9n7jRtWNFavPQA9IPrxPW6Z76owfjA= Date: Tue, 8 Sep 2020 17:46:23 +0300 From: Laurent Pinchart To: Kieran Bingham Cc: Kuninori Morimoto , Rob Herring , Geert Uytterhoeven , David Airlie , Daniel Vetter , Magnus , Linux-Renesas , Linux-DT , "(Renesas) shimoda" , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 02/10] dt-bindings: display: renesas: dw-hdmi: tidyup example compatible. Message-ID: <20200908144623.GB11405@pendragon.ideasonboard.com> References: <87o8mhrtxo.wl-kuninori.morimoto.gx@renesas.com> <87lfhlrtwp.wl-kuninori.morimoto.gx@renesas.com> <6e1eedf0-d05f-81cd-e437-33fc4c7337f3@ideasonboard.com> <20200908144317.GA11405@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200908144317.GA11405@pendragon.ideasonboard.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Sep 08, 2020 at 05:43:25PM +0300, Laurent Pinchart wrote: > Hi Kieran, > > On Tue, Sep 08, 2020 at 03:18:20PM +0100, Kieran Bingham wrote: > > On 08/09/2020 01:34, Kuninori Morimoto wrote: > > > From: Kuninori Morimoto > > > > > > required is "renesas,r8a7795-hdmi", instead of "renesas,r8a7795-dw-hdmi" > > > > Hrm, technically the driver will currently only match on : > > "renesas,rcar-gen3-hdmi" > > > > But I see how the '-dw-' has probably snuck in from other devices, and > > is inappropriate. > > > > Perhaps this should be more clear that it matches on the generic compatible: > > renesas,rcar-gen3-hdmi > > > > (or a combination of both?) > > > > > Signed-off-by: Kuninori Morimoto > > > > But if the generic isn't required, then this patch alone does fix what I > > would call an error, so ... > > You're right, the generic compatible string should be required. I'll > update this patch accordingly, and will address the bindings as part of > the conversion to YAML. Proposed new commit: commit cc487cbb06d841ca76efade63201a41bd04f6015 Author: Kuninori Morimoto Date: Tue Sep 8 09:34:11 2020 +0900 dt-bindings: display: renesas: dw-hdmi: Tidyup example compatible The DT example erronously uses the "renesas,r8a7795-dw-hdmi", when the correct value is "renesas,r8a7795-hdmi". It is furthermore missing the generic "renesas,rcar-gen3-hdmi" compatible string. Fix it. Signed-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham [Add "renesas,rcar-gen3-hdmi" and rework commit message] Signed-off-by: Laurent Pinchart diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt index f275997ab947..9c56c5169a88 100644 --- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt @@ -43,7 +43,7 @@ Optional properties: Example: hdmi0: hdmi@fead0000 { - compatible = "renesas,r8a7795-dw-hdmi"; + compatible = "renesas,r8a7795-hdmi", "renesas,rcar-gen3-hdmi"; reg = <0 0xfead0000 0 0x10000>; interrupts = <0 389 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cpg CPG_CORE R8A7795_CLK_S0D4>, <&cpg CPG_MOD 729>; > > Reviewed-by: Kieran Bingham > > > > We could always make this more clear when converting to YAML. > > > > > --- > > > .../devicetree/bindings/display/bridge/renesas,dw-hdmi.txt | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > > > index 819f3e31013c..e6526ab485d0 100644 > > > --- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > > > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > > > @@ -42,7 +42,7 @@ Optional properties: > > > Example: > > > > > > hdmi0: hdmi@fead0000 { > > > - compatible = "renesas,r8a7795-dw-hdmi"; > > > + compatible = "renesas,r8a7795-hdmi"; > > > reg = <0 0xfead0000 0 0x10000>; > > > interrupts = <0 389 IRQ_TYPE_LEVEL_HIGH>; > > > clocks = <&cpg CPG_CORE R8A7795_CLK_S0D4>, <&cpg CPG_MOD 729>; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7438FC43461 for ; Tue, 8 Sep 2020 14:47:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F02DD22B49 for ; Tue, 8 Sep 2020 14:47:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="nerJ56Bo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F02DD22B49 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6E6136E849; Tue, 8 Sep 2020 14:47:08 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F8B86E849 for ; Tue, 8 Sep 2020 14:47:07 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3646247; Tue, 8 Sep 2020 16:46:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1599576410; bh=RSK952bhlHi49suHIZc7d6qiORR1jel+b2zV6JRNGfA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nerJ56Bo/ACyXiuYStye+Z40isGeZr0T2w7UunIrue9jbV1y0Tp/EGavuLZCwNJLJ Xqlrz+7LrtNvNUdobIaX68MI0x5n5vtmqPihbFui2aeIU8XngIcl4e3C7mOP8SNIF2 4jmQZ60eIe9n7jRtWNFavPQA9IPrxPW6Z76owfjA= Date: Tue, 8 Sep 2020 17:46:23 +0300 From: Laurent Pinchart To: Kieran Bingham Subject: Re: [PATCH v2 02/10] dt-bindings: display: renesas: dw-hdmi: tidyup example compatible. Message-ID: <20200908144623.GB11405@pendragon.ideasonboard.com> References: <87o8mhrtxo.wl-kuninori.morimoto.gx@renesas.com> <87lfhlrtwp.wl-kuninori.morimoto.gx@renesas.com> <6e1eedf0-d05f-81cd-e437-33fc4c7337f3@ideasonboard.com> <20200908144317.GA11405@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200908144317.GA11405@pendragon.ideasonboard.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-DT , Kuninori Morimoto , Geert Uytterhoeven , David Airlie , "\(Renesas\) shimoda" , Magnus , dri-devel@lists.freedesktop.org, Linux-Renesas , Rob Herring Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Sep 08, 2020 at 05:43:25PM +0300, Laurent Pinchart wrote: > Hi Kieran, > > On Tue, Sep 08, 2020 at 03:18:20PM +0100, Kieran Bingham wrote: > > On 08/09/2020 01:34, Kuninori Morimoto wrote: > > > From: Kuninori Morimoto > > > > > > required is "renesas,r8a7795-hdmi", instead of "renesas,r8a7795-dw-hdmi" > > > > Hrm, technically the driver will currently only match on : > > "renesas,rcar-gen3-hdmi" > > > > But I see how the '-dw-' has probably snuck in from other devices, and > > is inappropriate. > > > > Perhaps this should be more clear that it matches on the generic compatible: > > renesas,rcar-gen3-hdmi > > > > (or a combination of both?) > > > > > Signed-off-by: Kuninori Morimoto > > > > But if the generic isn't required, then this patch alone does fix what I > > would call an error, so ... > > You're right, the generic compatible string should be required. I'll > update this patch accordingly, and will address the bindings as part of > the conversion to YAML. Proposed new commit: commit cc487cbb06d841ca76efade63201a41bd04f6015 Author: Kuninori Morimoto Date: Tue Sep 8 09:34:11 2020 +0900 dt-bindings: display: renesas: dw-hdmi: Tidyup example compatible The DT example erronously uses the "renesas,r8a7795-dw-hdmi", when the correct value is "renesas,r8a7795-hdmi". It is furthermore missing the generic "renesas,rcar-gen3-hdmi" compatible string. Fix it. Signed-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham [Add "renesas,rcar-gen3-hdmi" and rework commit message] Signed-off-by: Laurent Pinchart diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt index f275997ab947..9c56c5169a88 100644 --- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt @@ -43,7 +43,7 @@ Optional properties: Example: hdmi0: hdmi@fead0000 { - compatible = "renesas,r8a7795-dw-hdmi"; + compatible = "renesas,r8a7795-hdmi", "renesas,rcar-gen3-hdmi"; reg = <0 0xfead0000 0 0x10000>; interrupts = <0 389 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cpg CPG_CORE R8A7795_CLK_S0D4>, <&cpg CPG_MOD 729>; > > Reviewed-by: Kieran Bingham > > > > We could always make this more clear when converting to YAML. > > > > > --- > > > .../devicetree/bindings/display/bridge/renesas,dw-hdmi.txt | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > > > index 819f3e31013c..e6526ab485d0 100644 > > > --- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > > > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > > > @@ -42,7 +42,7 @@ Optional properties: > > > Example: > > > > > > hdmi0: hdmi@fead0000 { > > > - compatible = "renesas,r8a7795-dw-hdmi"; > > > + compatible = "renesas,r8a7795-hdmi"; > > > reg = <0 0xfead0000 0 0x10000>; > > > interrupts = <0 389 IRQ_TYPE_LEVEL_HIGH>; > > > clocks = <&cpg CPG_CORE R8A7795_CLK_S0D4>, <&cpg CPG_MOD 729>; -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel