From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 780D3C433E2 for ; Thu, 10 Sep 2020 19:33:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40CBD21D81 for ; Thu, 10 Sep 2020 19:33:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726850AbgIJTbm (ORCPT ); Thu, 10 Sep 2020 15:31:42 -0400 Received: from cloud.peff.net ([104.130.231.41]:53898 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727107AbgIJT31 (ORCPT ); Thu, 10 Sep 2020 15:29:27 -0400 Received: (qmail 24174 invoked by uid 109); 10 Sep 2020 19:29:21 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Thu, 10 Sep 2020 19:29:21 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 22746 invoked by uid 111); 10 Sep 2020 19:29:22 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 10 Sep 2020 15:29:22 -0400 Authentication-Results: peff.net; auth=none Date: Thu, 10 Sep 2020 15:29:20 -0400 From: Jeff King To: Junio C Hamano Cc: git@vger.kernel.org Subject: Re: [PATCH v2 4/7] quote_path: code clarification Message-ID: <20200910192920.GA1920978@coredump.intra.peff.net> References: <20200908205224.4126551-1-gitster@pobox.com> <20200910170159.1278781-1-gitster@pobox.com> <20200910170159.1278781-5-gitster@pobox.com> <20200910180814.GA1917207@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Sep 10, 2020 at 11:40:42AM -0700, Junio C Hamano wrote: > >> + int force_dq = ((flags & QUOTE_PATH_QUOTE_SP) && strchr(rel, ' ')); > >> [...] > >> + quote_c_style_counted(rel, strlen(rel), out, NULL, !!force_dq); > > > > I think force_dq is already normalized to 0/1 by the &&, so we wouldn't > > need the "!!" here. > > True. CQUOTE_NODQ patch would get rid of it in the end, though ;-) Oh, true. I didn't think to look ahead. Having done so, yeah, I don't see any point in quibbling about this one. :) -Peff