From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82B36C43461 for ; Mon, 14 Sep 2020 02:17:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34E702177B for ; Mon, 14 Sep 2020 02:17:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="mSlhfJ3v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725986AbgINCRP (ORCPT ); Sun, 13 Sep 2020 22:17:15 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:27753 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725965AbgINCRN (ORCPT ); Sun, 13 Sep 2020 22:17:13 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1600049831; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=D1hRyfc52WtHMpJxHxAiS1jEtfY8/MohItXtIX/3i6k=; b=mSlhfJ3vNjdgibTYd0IwNGYUJ6h1fvjjkBHbWH/gPZgU7j4R0hKEqbOPWbjycq+UOx213ygf cBILq2k9akz8kQWpS64u4Gmtd8xxZRtdhbMy+qZvUBAc/EilEN5zFOAqjyCqc1LdiNttXYV5 QVMytqDmLN4IalFY1sBUbtGUgcQ= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 5f5ed2a7698ee477d1dd4af2 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 14 Sep 2020 02:17:11 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 54235C43385; Mon, 14 Sep 2020 02:17:11 +0000 (UTC) Received: from codeaurora.org (unknown [180.166.53.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tingwei) by smtp.codeaurora.org (Postfix) with ESMTPSA id EBFB6C433C6; Mon, 14 Sep 2020 02:17:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EBFB6C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=tingweiz@codeaurora.org Date: Mon, 14 Sep 2020 10:17:00 +0800 From: Tingwei Zhang To: Suzuki K Poulose Cc: tingwei@codeaurora.org, mathieu.poirier@linaro.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, tsoni@codeaurora.org, saiprakash.ranjan@codeaurora.org, kim.phillips@arm.com, lkp@intel.com, jinlmao@codeaurora.org, gregkh@linuxfoundation.org, coresight@lists.linaro.org, rdunlap@infradead.org, ykaukab@suse.de, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, leo.yan@linaro.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v10 14/24] coresight: allow funnel driver to be built as module Message-ID: <20200914021659.GA22686@codeaurora.org> References: <20200821034445.967-1-tingwei@codeaurora.org> <20200821034445.967-15-tingwei@codeaurora.org> <3d4bf829-abca-3f5f-fa2f-282305a9dc7a@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3d4bf829-abca-3f5f-fa2f-282305a9dc7a@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 13, 2020 at 09:24:52PM +0800, Suzuki K Poulose wrote: > On 08/21/2020 04:44 AM, Tingwei Zhang wrote: > >From: Kim Phillips > > > >Allow to build coresight-funnel as module, for ease of development. > > > >- combine static and dynamic funnel init into single > > module_init/exit call > >- add funnel_remove functions, for module unload > >- add a MODULE_DEVICE_TABLE for autoloading on boot > > > >Cc: Mathieu Poirier > >Cc: Leo Yan > >Cc: Alexander Shishkin > >Cc: Randy Dunlap > >Cc: Suzuki K Poulose > >Cc: Greg Kroah-Hartman > >Cc: Russell King > >Co-developed-by: Mian Yousaf Kaukab > >Signed-off-by: Mian Yousaf Kaukab > >Signed-off-by: Kim Phillips > >Signed-off-by: Tingwei Zhang > >Reported-by: kernel test robot > >Tested-by: Mike Leach > >Reviewed-by: Mathieu Poirier > >--- > > .../hwtracing/coresight/coresight-funnel.c | 64 ++++++++++++++++++- > > 1 file changed, 62 insertions(+), 2 deletions(-) > > > >diff --git a/drivers/hwtracing/coresight/coresight-funnel.c > b/drivers/hwtracing/coresight/coresight-funnel.c > >index 900690a9f7f0..07bc20391fac 100644 > >--- a/drivers/hwtracing/coresight/coresight-funnel.c > >+++ b/drivers/hwtracing/coresight/coresight-funnel.c > >@@ -274,6 +274,15 @@ static int funnel_probe(struct device *dev, struct > resource *res) > > return ret; > > } > >+static int __exit funnel_remove(struct device *dev) > >+{ > >+ struct funnel_drvdata *drvdata = dev_get_drvdata(dev); > >+ > >+ coresight_unregister(drvdata->csdev); > >+ > >+ return 0; > >+} > >+ > > #ifdef CONFIG_PM > > static int funnel_runtime_suspend(struct device *dev) > > { > >@@ -319,20 +328,32 @@ static int static_funnel_probe(struct > platform_device *pdev) > > return ret; > > } > >+static int __exit static_funnel_remove(struct platform_device *pdev) > >+{ > >+ funnel_remove(&pdev->dev); > >+ pm_runtime_disable(&pdev->dev); > >+ return 0; > >+} > >+ > > static const struct of_device_id static_funnel_match[] = { > > {.compatible = "arm,coresight-static-funnel"}, > > {} > > }; > >+MODULE_DEVICE_TABLE(of, static_funnel_match); > >+ > > #ifdef CONFIG_ACPI > > static const struct acpi_device_id static_funnel_ids[] = { > > {"ARMHC9FE", 0}, > > {}, > > }; > >+ > >+MODULE_DEVICE_TABLE(acpi, static_funnel_ids); > > #endif > > static struct platform_driver static_funnel_driver = { > > .probe = static_funnel_probe, > >+ .remove = static_funnel_remove, > > .driver = { > > .name = "coresight-static-funnel", > > .of_match_table = static_funnel_match, > > Sorry missed this. Please set the owner field here. With that : > > Reviewed-by: Suzuki K Poulose > Thanks, Suzuki. I'll add owner in v11. Thanks, Tingwei > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B148FC43461 for ; Mon, 14 Sep 2020 02:18:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C3DA2168B for ; Mon, 14 Sep 2020 02:18:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SRvOFTj+"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="pydYIKwV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C3DA2168B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=euMTwKAWcybfz9a+fk/HdfQpNWGMEPYsZDkHBuhGGqY=; b=SRvOFTj+3285fFjTrzWhz+392 1enMIqJvD2Z6ovFkN8koi0ulxLbJhGv1JczgHe+YkO7T0kDf8ff0hAiukWEFagI08vevfJNwox8ZF PT0jKUNdXtnF9MOw9oaKL8LY1JobZcvQr0ZuXBRqmW5YvEicMcSXs9Q22oL+FY+qH2SKvZT6m5kH3 RRZGPeOMH6X3kwo2piBMucuVa2nj2fIq3OEGt06j9TCdTr57m3p0O+1eIBRVm/TJrJfiKcYyzzMNd vxt1DAtd1vwpPDPd4uz9TMShlon803yFWVQSw0/km+bvYkWVnFvQ+ndm7KwiGi1ChSuYxHagFbMKz G/w/YXFcQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHe3R-0008GU-Bj; Mon, 14 Sep 2020 02:17:17 +0000 Received: from m43-7.mailgun.net ([69.72.43.7]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHe3N-0008Fs-T1 for linux-arm-kernel@lists.infradead.org; Mon, 14 Sep 2020 02:17:15 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1600049833; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=D1hRyfc52WtHMpJxHxAiS1jEtfY8/MohItXtIX/3i6k=; b=pydYIKwV9nxA1etQsAiEMoSiHbFsRCI4OHTE5vfJN3xn+Ct7Y29x0d8s20Gg1P3ZPzYnn5gF 4fOxVWSV30Q95dA3Wms8CQl8BKC9EpzMeqyv9xgQqgBLIbHx1iWRTarHLPm/NG1XlIvji+MH 1hy5vG+2CY+KXlVZqdjRR8lly4U= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 5f5ed2a854e87432be64d1bf (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 14 Sep 2020 02:17:12 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 5B4BAC433F0; Mon, 14 Sep 2020 02:17:11 +0000 (UTC) Received: from codeaurora.org (unknown [180.166.53.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tingwei) by smtp.codeaurora.org (Postfix) with ESMTPSA id EBFB6C433C6; Mon, 14 Sep 2020 02:17:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EBFB6C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=tingweiz@codeaurora.org Date: Mon, 14 Sep 2020 10:17:00 +0800 From: Tingwei Zhang To: Suzuki K Poulose Subject: Re: [PATCH v10 14/24] coresight: allow funnel driver to be built as module Message-ID: <20200914021659.GA22686@codeaurora.org> References: <20200821034445.967-1-tingwei@codeaurora.org> <20200821034445.967-15-tingwei@codeaurora.org> <3d4bf829-abca-3f5f-fa2f-282305a9dc7a@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3d4bf829-abca-3f5f-fa2f-282305a9dc7a@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200913_221713_969136_38C17F87 X-CRM114-Status: GOOD ( 24.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, saiprakash.ranjan@codeaurora.org, kim.phillips@arm.com, lkp@intel.com, mathieu.poirier@linaro.org, alexander.shishkin@linux.intel.com, gregkh@linuxfoundation.org, coresight@lists.linaro.org, jinlmao@codeaurora.org, ykaukab@suse.de, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, rdunlap@infradead.org, tingwei@codeaurora.org, leo.yan@linaro.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Sep 13, 2020 at 09:24:52PM +0800, Suzuki K Poulose wrote: > On 08/21/2020 04:44 AM, Tingwei Zhang wrote: > >From: Kim Phillips > > > >Allow to build coresight-funnel as module, for ease of development. > > > >- combine static and dynamic funnel init into single > > module_init/exit call > >- add funnel_remove functions, for module unload > >- add a MODULE_DEVICE_TABLE for autoloading on boot > > > >Cc: Mathieu Poirier > >Cc: Leo Yan > >Cc: Alexander Shishkin > >Cc: Randy Dunlap > >Cc: Suzuki K Poulose > >Cc: Greg Kroah-Hartman > >Cc: Russell King > >Co-developed-by: Mian Yousaf Kaukab > >Signed-off-by: Mian Yousaf Kaukab > >Signed-off-by: Kim Phillips > >Signed-off-by: Tingwei Zhang > >Reported-by: kernel test robot > >Tested-by: Mike Leach > >Reviewed-by: Mathieu Poirier > >--- > > .../hwtracing/coresight/coresight-funnel.c | 64 ++++++++++++++++++- > > 1 file changed, 62 insertions(+), 2 deletions(-) > > > >diff --git a/drivers/hwtracing/coresight/coresight-funnel.c > b/drivers/hwtracing/coresight/coresight-funnel.c > >index 900690a9f7f0..07bc20391fac 100644 > >--- a/drivers/hwtracing/coresight/coresight-funnel.c > >+++ b/drivers/hwtracing/coresight/coresight-funnel.c > >@@ -274,6 +274,15 @@ static int funnel_probe(struct device *dev, struct > resource *res) > > return ret; > > } > >+static int __exit funnel_remove(struct device *dev) > >+{ > >+ struct funnel_drvdata *drvdata = dev_get_drvdata(dev); > >+ > >+ coresight_unregister(drvdata->csdev); > >+ > >+ return 0; > >+} > >+ > > #ifdef CONFIG_PM > > static int funnel_runtime_suspend(struct device *dev) > > { > >@@ -319,20 +328,32 @@ static int static_funnel_probe(struct > platform_device *pdev) > > return ret; > > } > >+static int __exit static_funnel_remove(struct platform_device *pdev) > >+{ > >+ funnel_remove(&pdev->dev); > >+ pm_runtime_disable(&pdev->dev); > >+ return 0; > >+} > >+ > > static const struct of_device_id static_funnel_match[] = { > > {.compatible = "arm,coresight-static-funnel"}, > > {} > > }; > >+MODULE_DEVICE_TABLE(of, static_funnel_match); > >+ > > #ifdef CONFIG_ACPI > > static const struct acpi_device_id static_funnel_ids[] = { > > {"ARMHC9FE", 0}, > > {}, > > }; > >+ > >+MODULE_DEVICE_TABLE(acpi, static_funnel_ids); > > #endif > > static struct platform_driver static_funnel_driver = { > > .probe = static_funnel_probe, > >+ .remove = static_funnel_remove, > > .driver = { > > .name = "coresight-static-funnel", > > .of_match_table = static_funnel_match, > > Sorry missed this. Please set the owner field here. With that : > > Reviewed-by: Suzuki K Poulose > Thanks, Suzuki. I'll add owner in v11. Thanks, Tingwei > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel