Re: [RFC PATCH v2] PCI/portdrv: Only disable Bus Master on kexec reboot and connected PCI devices

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH v2] PCI/portdrv: Only disable Bus Master on kexec reboot and connected PCI devices
Date: Mon, 14 Sep 2020 13:59:10 +0800	[thread overview]
Message-ID: <202009141332.XW0DYSLf%lkp@intel.com> (raw)
In-Reply-To: <1600028950-10644-1-git-send-email-yangtiezhu@loongson.cn>

[-- Attachment #1: Type: text/plain, Size: 2598 bytes --]

Hi Tiezhu,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on pci/next]
[also build test WARNING on v5.9-rc5 next-20200911]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Tiezhu-Yang/PCI-portdrv-Only-disable-Bus-Master-on-kexec-reboot-and-connected-PCI-devices/20200914-043100
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-randconfig-s021-20200913 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.2-191-g10164920-dirty
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)

>> drivers/pci/pcie/portdrv_pci.c:167:38: sparse: sparse: restricted pci_power_t degrades to integer
   drivers/pci/pcie/portdrv_pci.c:167:57: sparse: sparse: restricted pci_power_t degrades to integer

# https://github.com/0day-ci/linux/commit/554a10648754bd244b64a233c257821c4719be0e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tiezhu-Yang/PCI-portdrv-Only-disable-Bus-Master-on-kexec-reboot-and-connected-PCI-devices/20200914-043100
git checkout 554a10648754bd244b64a233c257821c4719be0e
vim +167 drivers/pci/pcie/portdrv_pci.c

   149	
   150	static void pcie_portdrv_shutdown(struct pci_dev *dev)
   151	{
   152		if (pci_bridge_d3_possible(dev)) {
   153			pm_runtime_forbid(&dev->dev);
   154			pm_runtime_get_noresume(&dev->dev);
   155			pm_runtime_dont_use_autosuspend(&dev->dev);
   156		}
   157	
   158		pcie_port_device_remove(dev);
   159	
   160		/*
   161		 * If this is a kexec reboot, turn off Bus Master bit on the
   162		 * device to tell it to not continue to do DMA. Don't touch
   163		 * devices in D3cold or unknown states.
   164		 * If it is not a kexec reboot, firmware will hit the PCI
   165		 * devices with big hammer and stop their DMA any way.
   166		 */
 > 167		if (kexec_in_progress && (dev->current_state <= PCI_D3hot))
   168			pci_disable_device(dev);
   169	}
   170	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32722 bytes --]