All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] support/scripts/mkusers: allow option for system uid/gid
Date: Tue, 15 Sep 2020 22:47:01 +0200	[thread overview]
Message-ID: <20200915224701.5f096d97@windsurf.hq.k.grp> (raw)
In-Reply-To: <20200113153516.486106-1-nolange79@gmail.com>

Hello Norbert,

On Mon, 13 Jan 2020 16:35:13 +0100
Norbert Lange <nolange79@gmail.com> wrote:

> Extend the mkusers script to allow -2 for uid/gid.
> This value will take an identifier from the system range.
> 
> Signed-off-by: Norbert Lange <nolange79@gmail.com>

Sorry for the long delay in getting back to you. We had an earlier
proposal from Stephan Henningsen doing pretty much the same:

  https://patchwork.ozlabs.org/project/buildroot/patch/20191023211313.6758-1-stephan+buildroot at asklandd.dk/

The argument of Stephan was pretty much beauty/consistency with what
"most systems do" without much other arguments.

However, based on your PATCH 2/3 and a reading of
https://systemd.io/UIDS-GIDS/ it seems like systemd somehow cares about
this system vs. normal user difference.

Could you give some details about the *why* you did this change?
Indeed, your commit log doesn't explain anything about the *why*.

Also, could you compare your changes to mkusers with the ones proposed
by Stephan? The ones proposed by Stephan looked quite a bit more
complicated.

Another (minor) question is: if we're going to go to this route of
separating system and normal users, wouldn't it make sense to have -1
identify system users, and -2 identify normal users? Indeed the vast
majority (all?) Buildroot packages probably want to create system
users, and they already use -1.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2020-09-15 20:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-13 15:35 [Buildroot] [PATCH 1/3] support/scripts/mkusers: allow option for system uid/gid Norbert Lange
2020-01-13 15:35 ` [Buildroot] [PATCH 2/3] package/systemd: create system users Norbert Lange
2020-01-13 16:05   ` Thomas Petazzoni
2020-01-13 15:35 ` [Buildroot] [PATCH 3/3] package/openssh: " Norbert Lange
2020-09-15 20:47 ` Thomas Petazzoni [this message]
2020-09-15 21:29   ` [Buildroot] [PATCH 1/3] support/scripts/mkusers: allow option for system uid/gid Norbert Lange
2020-09-16  6:41     ` Jérémy ROSEN
2020-09-16  6:53     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200915224701.5f096d97@windsurf.hq.k.grp \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.