From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CB80C43461 for ; Wed, 16 Sep 2020 20:39:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2466421941 for ; Wed, 16 Sep 2020 20:39:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728510AbgIPUjk (ORCPT ); Wed, 16 Sep 2020 16:39:40 -0400 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:33013 "EHLO new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726736AbgIPRGS (ORCPT ); Wed, 16 Sep 2020 13:06:18 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 28A7D58011F; Wed, 16 Sep 2020 12:57:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 16 Sep 2020 12:57:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=u8jbHISbSUUNQj4aheiIBcbQzWT dwA6DbD/UfopS5AA=; b=EyG/8c0/G9xXeiBHnZNVdtJY6d8BC2rME/t6/EmIQFV 47BAhwZnUMP/57J73C7Iyn9wyo+lbqv+5FBwjwE8AUg+U+PDqkt2R5DOunVh6Zk8 F4rtXpTUCOP5f/2bzEzPbKZjaZSR448COTL0a+H6eve3TzS/Y67ZwZoCmsciVgmQ 1rNtEy3kz44B4cNmbogojSsgi4qtGeQaN4ikvROrFDAuCOSgtCIW6VWXOJBby9qe eJgW/Ri0E1hAo+b7DWfu555RGsrNoW5daaKJ1sxqqgoubECBq2GCTb/wqUVOwXFZ SEdBDYItV/nZ7ldBsl8Th6zxWoyTRUVO+OyOTRR0nqQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=u8jbHI SbSUUNQj4aheiIBcbQzWTdwA6DbD/UfopS5AA=; b=uJDj+5FtdycqWiX+jymszg EiwsCklp8q3zAgck221U68jcnEEbhAeOD+kWt9idE/lYtvpqUyYTkgemngX3GAhZ yTdM2INsE6lvgwggnqv8/iWKmBhJgfL4A6oDbYpxbzNLIOvwmMwt6uGiAQ+zCOZ2 nodz4iceUK8FjwA7F7Ex5O8QvwZdT6zwPeq/hGrG2RR5fmQ/nc21oP5+Z095Vd0J HVynvFBwQBffR5Bbphmt6Qd956KywUykDT4MCe9AGOFgUI5Kefq9iAnYlBSO6EAE 4jaVVVPvndPJmecnlQurDaFh0jKLOWEG/VdrGY37DJC9ldMsrvPFJp/16HBOmQjA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrtddvgddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddunecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepuddvudfhkeekhefgffetffelgffftdehffduffegveetffehueeivddvjedv gfevnecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 017CD328005A; Wed, 16 Sep 2020 12:57:06 -0400 (EDT) Date: Wed, 16 Sep 2020 18:57:05 +0200 From: Maxime Ripard To: Hoegeun Kwon Cc: Nicolas Saenz Julienne , Eric Anholt , devicetree@vger.kernel.org, Tim Gover , Dave Stevenson , Stephen Boyd , Kamal Dasu , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Phil Elwell , linux-arm-kernel@lists.infradead.org, =?utf-8?B?64KY7ISx6rWt?= Subject: Re: [PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline Message-ID: <20200916165705.7pfgesma47vgkfxt@gilmour.lan> References: <20200908120019.3rmhzoijoijrbb7d@gilmour.lan> <3e113525-aa89-b1e2-56b7-ca55bd41d057@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zlz5rlu4elwsvrxu" Content-Disposition: inline In-Reply-To: <3e113525-aa89-b1e2-56b7-ca55bd41d057@samsung.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zlz5rlu4elwsvrxu Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 14, 2020 at 07:14:11PM +0900, Hoegeun Kwon wrote: > Hi Maxime, >=20 > On 9/8/20 9:00 PM, Maxime Ripard wrote: > > Hi Hoegeun, > > > > On Mon, Sep 07, 2020 at 08:49:12PM +0900, Hoegeun Kwon wrote: > >> On 9/3/20 5:00 PM, Maxime Ripard wrote: > >>> Hi everyone, > >>> > >>> Here's a (pretty long) series to introduce support in the VC4 DRM dri= ver > >>> for the display pipeline found in the BCM2711 (and thus the Raspberry= Pi 4). > >>> > >>> The main differences are that there's two HDMI controllers and that t= here's > >>> more pixelvalve now. Those pixelvalve come with a mux in the HVS that= still > >>> have only 3 FIFOs. Both of those differences are breaking a bunch of > >>> expectations in the driver, so we first need a good bunch of cleanup = and > >>> reworks to introduce support for the new controllers. > >>> > >>> Similarly, the HDMI controller has all its registers shuffled and spl= it in > >>> multiple controllers now, so we need a bunch of changes to support th= is as > >>> well. > >>> > >>> Only the HDMI support is enabled for now (even though the DPI and DSI > >>> outputs have been tested too). > >>> > >>> Let me know if you have any comments > >>> Maxime > >>> > >>> Cc: bcm-kernel-feedback-list@broadcom.com > >>> Cc: devicetree@vger.kernel.org > >>> Cc: Kamal Dasu > >>> Cc: Philipp Zabel > >>> Cc: Rob Herring > >>> Cc: Stephen Boyd > >>> > >>> Changes from v4: > >>> - Rebased on top of next-20200828 > >>> - Collected the various tags > >>> - Fixed some issues with 4k support and dual output (thanks Hoege= un!) > >> Thanks for your v5 patchset. > >> > >> I tested all patches based on the next-20200812. > > Thanks again for testing all the patches > > > >> Everything else is fine, but the dual hdmi modetest doesn't work well = in my > >> environment... > >> > >> In my environment, dsi is not connected, I have seen your answer[1]. > > Can you share a bit more your setup? What monitors are being connected > > to each HDMI port? Do you hotplug any? > Yes, Monitors are being connected to each HDMI ports. (did not use hotplu= g) >=20 > When booting, both HDMI-0 and 1 are recognized and the kernel log is outp= ut. > But after run modetest on HDMI-0(works) and modetest on HDMI-1(works), > crtc timed out occurs on HDMI-0 and does not work. >=20 > When HDMI-0 is not working we do a modetest on HDMI-0, it will work agin > after about 40 sec. >=20 > Below is the log for modetest. >=20 >=20 > root:~> modetest -Mvc4 -s 32:1280x720 =A0=A0=A0 =A0=A0=A0 - HDMI-0 works > setting mode 1280x720-60Hz@XR24 on connectors 32, crtc 64 > failed to set gamma: Invalid argument >=20 > root:~> modetest -Mvc4 -s 32:1280x720 =A0=A0=A0 =A0=A0=A0 - HDMI-0 works > setting mode 1280x720-60Hz@XR24 on connectors 32, crtc 64 > failed to set gamma: Invalid argument >=20 > root:~> modetest -Mvc4 -s 38:1280x720 =A0=A0=A0 =A0=A0=A0 - HDMI-1 works > setting mode 1280x720-60Hz@XR24 on connectors 38, crtc 69 > failed to set gamma: Invalid argument >=20 > =A0=A0=A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0=A0= =A0 =A0=A0=A0 - Crtc timed out occurs on HDMI-0 and=20 > does not work. >=20 > [=A0=A0 71.134283] [drm:drm_atomic_helper_wait_for_flip_done] *ERROR*=20 > [CRTC:64:crtc-3] flip_done timed out > [=A0=A0 81.374296] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*= =20 > [CRTC:64:crtc-3] flip_done timed out > [=A0=A0 91.618380] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*= =20 > [CONNECTOR:32:HDMI-A-1] flip_done timed out > [=A0 101.854274] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [PLANE:60:plane-3] flip_done timed out >=20 > [=A0 112.094271] [drm:drm_atomic_helper_wait_for_flip_done] *ERROR*=20 > [CRTC:64:crtc-3] flip_done timed out > [=A0 122.590311] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [CRTC:64:crtc-3] flip_done timed out >=20 > root:~> modetest -Mvc4 -s 32:1280x720 > [=A0 132.830309] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [CONNECTOR:32:HDMI-A-1] flip_done timed out > [=A0 143.070307] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [PLANE:60:plane-3] flip_done timed out > [=A0 153.310303] [drm:drm_atomic_helper_wait_for_flip_done] *ERROR*=20 > [CRTC:64:crtc-3] flip_done timed out > setting mode 1280x720-60Hz@XR24 on connectors 32, crtc 64 > [=A0 163.550340] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [CRTC:64:crtc-3] flip_done timed out > [=A0 173.790277] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [CONNECTOR:32:HDMI-A-1] flip_done timed out > [=A0 184.030286] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [PLANE:60:plane-3] flip_done timed out > failed to set gamma: Invalid argument =A0=A0=A0 =A0=A0=A0 - HDMI-0 works Thanks :) I was able to reproduce it just by also letting X boot. I'm on a good path to fix it and found a workaround. I'll send you the patch in the upcoming days :) Thanks again, Maxime --zlz5rlu4elwsvrxu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX2JD4QAKCRDj7w1vZxhR xRSMAQDJUj9nSuN6IyZmgUE3IaFEuev8g+P2MdyQzGg10MpHBQEA00Yn3whT31br uSzvMFoupb5cWMsYQo6Zh1bdS0ejIAg= =BQPM -----END PGP SIGNATURE----- --zlz5rlu4elwsvrxu-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FEDEC43461 for ; Wed, 16 Sep 2020 17:00:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8FFF224B0 for ; Wed, 16 Sep 2020 17:00:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dq695FxV"; dkim=temperror (0-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="EyG/8c0/"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="uJDj+5Ft" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8FFF224B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X7TtCVzlLT7LzaYj6oU94ZMEGsOENsF2BiSaBwY0j5s=; b=dq695FxVXgd349+O9oVTFQtnO dLl6gD2RW8AQfwLK/+7bSHtsrms3H7t9JD/N7wv36LdLYwlXJXQzzm/wbLAlfZEDce8SEtaZh92p4 yCdYK7lMnlpUTdaNErAP9+TUgD2Mz2kWhus9GLBNtaSlstJhn/otYaHOJzKUbs9HyN+LlY/LwKOc3 aFMqvXUS7GS4rEoE3+L0lVM3tRtJtBdxXpl5t6cK4KZQSxcxZ0em1P2DPmH155fsnEgelCKG8cECF C9vHc13j+v4Qb4jVfByC9HZXUSyTmLLkqbKXdDrzTkKBlFBYRJTq62428OKKE+OQRHvw4oZqneBT6 bYCn7Dfww==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIak8-0003IO-6f; Wed, 16 Sep 2020 16:57:16 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIak4-0003HL-Oq; Wed, 16 Sep 2020 16:57:13 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 28A7D58011F; Wed, 16 Sep 2020 12:57:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 16 Sep 2020 12:57:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=u8jbHISbSUUNQj4aheiIBcbQzWT dwA6DbD/UfopS5AA=; b=EyG/8c0/G9xXeiBHnZNVdtJY6d8BC2rME/t6/EmIQFV 47BAhwZnUMP/57J73C7Iyn9wyo+lbqv+5FBwjwE8AUg+U+PDqkt2R5DOunVh6Zk8 F4rtXpTUCOP5f/2bzEzPbKZjaZSR448COTL0a+H6eve3TzS/Y67ZwZoCmsciVgmQ 1rNtEy3kz44B4cNmbogojSsgi4qtGeQaN4ikvROrFDAuCOSgtCIW6VWXOJBby9qe eJgW/Ri0E1hAo+b7DWfu555RGsrNoW5daaKJ1sxqqgoubECBq2GCTb/wqUVOwXFZ SEdBDYItV/nZ7ldBsl8Th6zxWoyTRUVO+OyOTRR0nqQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=u8jbHI SbSUUNQj4aheiIBcbQzWTdwA6DbD/UfopS5AA=; b=uJDj+5FtdycqWiX+jymszg EiwsCklp8q3zAgck221U68jcnEEbhAeOD+kWt9idE/lYtvpqUyYTkgemngX3GAhZ yTdM2INsE6lvgwggnqv8/iWKmBhJgfL4A6oDbYpxbzNLIOvwmMwt6uGiAQ+zCOZ2 nodz4iceUK8FjwA7F7Ex5O8QvwZdT6zwPeq/hGrG2RR5fmQ/nc21oP5+Z095Vd0J HVynvFBwQBffR5Bbphmt6Qd956KywUykDT4MCe9AGOFgUI5Kefq9iAnYlBSO6EAE 4jaVVVPvndPJmecnlQurDaFh0jKLOWEG/VdrGY37DJC9ldMsrvPFJp/16HBOmQjA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrtddvgddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddunecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepuddvudfhkeekhefgffetffelgffftdehffduffegveetffehueeivddvjedv gfevnecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 017CD328005A; Wed, 16 Sep 2020 12:57:06 -0400 (EDT) Date: Wed, 16 Sep 2020 18:57:05 +0200 From: Maxime Ripard To: Hoegeun Kwon Subject: Re: [PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline Message-ID: <20200916165705.7pfgesma47vgkfxt@gilmour.lan> References: <20200908120019.3rmhzoijoijrbb7d@gilmour.lan> <3e113525-aa89-b1e2-56b7-ca55bd41d057@samsung.com> MIME-Version: 1.0 In-Reply-To: <3e113525-aa89-b1e2-56b7-ca55bd41d057@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200916_125713_014101_AA42C020 X-CRM114-Status: GOOD ( 31.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Tim Gover , Dave Stevenson , Stephen Boyd , Kamal Dasu , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Eric Anholt , Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, =?utf-8?B?64KY7ISx6rWt?= , Phil Elwell , Nicolas Saenz Julienne Content-Type: multipart/mixed; boundary="===============1953608649738283168==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1953608649738283168== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zlz5rlu4elwsvrxu" Content-Disposition: inline --zlz5rlu4elwsvrxu Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 14, 2020 at 07:14:11PM +0900, Hoegeun Kwon wrote: > Hi Maxime, >=20 > On 9/8/20 9:00 PM, Maxime Ripard wrote: > > Hi Hoegeun, > > > > On Mon, Sep 07, 2020 at 08:49:12PM +0900, Hoegeun Kwon wrote: > >> On 9/3/20 5:00 PM, Maxime Ripard wrote: > >>> Hi everyone, > >>> > >>> Here's a (pretty long) series to introduce support in the VC4 DRM dri= ver > >>> for the display pipeline found in the BCM2711 (and thus the Raspberry= Pi 4). > >>> > >>> The main differences are that there's two HDMI controllers and that t= here's > >>> more pixelvalve now. Those pixelvalve come with a mux in the HVS that= still > >>> have only 3 FIFOs. Both of those differences are breaking a bunch of > >>> expectations in the driver, so we first need a good bunch of cleanup = and > >>> reworks to introduce support for the new controllers. > >>> > >>> Similarly, the HDMI controller has all its registers shuffled and spl= it in > >>> multiple controllers now, so we need a bunch of changes to support th= is as > >>> well. > >>> > >>> Only the HDMI support is enabled for now (even though the DPI and DSI > >>> outputs have been tested too). > >>> > >>> Let me know if you have any comments > >>> Maxime > >>> > >>> Cc: bcm-kernel-feedback-list@broadcom.com > >>> Cc: devicetree@vger.kernel.org > >>> Cc: Kamal Dasu > >>> Cc: Philipp Zabel > >>> Cc: Rob Herring > >>> Cc: Stephen Boyd > >>> > >>> Changes from v4: > >>> - Rebased on top of next-20200828 > >>> - Collected the various tags > >>> - Fixed some issues with 4k support and dual output (thanks Hoege= un!) > >> Thanks for your v5 patchset. > >> > >> I tested all patches based on the next-20200812. > > Thanks again for testing all the patches > > > >> Everything else is fine, but the dual hdmi modetest doesn't work well = in my > >> environment... > >> > >> In my environment, dsi is not connected, I have seen your answer[1]. > > Can you share a bit more your setup? What monitors are being connected > > to each HDMI port? Do you hotplug any? > Yes, Monitors are being connected to each HDMI ports. (did not use hotplu= g) >=20 > When booting, both HDMI-0 and 1 are recognized and the kernel log is outp= ut. > But after run modetest on HDMI-0(works) and modetest on HDMI-1(works), > crtc timed out occurs on HDMI-0 and does not work. >=20 > When HDMI-0 is not working we do a modetest on HDMI-0, it will work agin > after about 40 sec. >=20 > Below is the log for modetest. >=20 >=20 > root:~> modetest -Mvc4 -s 32:1280x720 =A0=A0=A0 =A0=A0=A0 - HDMI-0 works > setting mode 1280x720-60Hz@XR24 on connectors 32, crtc 64 > failed to set gamma: Invalid argument >=20 > root:~> modetest -Mvc4 -s 32:1280x720 =A0=A0=A0 =A0=A0=A0 - HDMI-0 works > setting mode 1280x720-60Hz@XR24 on connectors 32, crtc 64 > failed to set gamma: Invalid argument >=20 > root:~> modetest -Mvc4 -s 38:1280x720 =A0=A0=A0 =A0=A0=A0 - HDMI-1 works > setting mode 1280x720-60Hz@XR24 on connectors 38, crtc 69 > failed to set gamma: Invalid argument >=20 > =A0=A0=A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0=A0= =A0 =A0=A0=A0 - Crtc timed out occurs on HDMI-0 and=20 > does not work. >=20 > [=A0=A0 71.134283] [drm:drm_atomic_helper_wait_for_flip_done] *ERROR*=20 > [CRTC:64:crtc-3] flip_done timed out > [=A0=A0 81.374296] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*= =20 > [CRTC:64:crtc-3] flip_done timed out > [=A0=A0 91.618380] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*= =20 > [CONNECTOR:32:HDMI-A-1] flip_done timed out > [=A0 101.854274] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [PLANE:60:plane-3] flip_done timed out >=20 > [=A0 112.094271] [drm:drm_atomic_helper_wait_for_flip_done] *ERROR*=20 > [CRTC:64:crtc-3] flip_done timed out > [=A0 122.590311] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [CRTC:64:crtc-3] flip_done timed out >=20 > root:~> modetest -Mvc4 -s 32:1280x720 > [=A0 132.830309] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [CONNECTOR:32:HDMI-A-1] flip_done timed out > [=A0 143.070307] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [PLANE:60:plane-3] flip_done timed out > [=A0 153.310303] [drm:drm_atomic_helper_wait_for_flip_done] *ERROR*=20 > [CRTC:64:crtc-3] flip_done timed out > setting mode 1280x720-60Hz@XR24 on connectors 32, crtc 64 > [=A0 163.550340] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [CRTC:64:crtc-3] flip_done timed out > [=A0 173.790277] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [CONNECTOR:32:HDMI-A-1] flip_done timed out > [=A0 184.030286] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [PLANE:60:plane-3] flip_done timed out > failed to set gamma: Invalid argument =A0=A0=A0 =A0=A0=A0 - HDMI-0 works Thanks :) I was able to reproduce it just by also letting X boot. I'm on a good path to fix it and found a workaround. I'll send you the patch in the upcoming days :) Thanks again, Maxime --zlz5rlu4elwsvrxu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX2JD4QAKCRDj7w1vZxhR xRSMAQDJUj9nSuN6IyZmgUE3IaFEuev8g+P2MdyQzGg10MpHBQEA00Yn3whT31br uSzvMFoupb5cWMsYQo6Zh1bdS0ejIAg= =BQPM -----END PGP SIGNATURE----- --zlz5rlu4elwsvrxu-- --===============1953608649738283168== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1953608649738283168==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 670A7C433E2 for ; Thu, 17 Sep 2020 08:08:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BE6321D90 for ; Thu, 17 Sep 2020 08:08:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BE6321D90 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EF3D86EB7E; Thu, 17 Sep 2020 08:08:10 +0000 (UTC) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by gabe.freedesktop.org (Postfix) with ESMTPS id BB595892F1 for ; Wed, 16 Sep 2020 16:57:10 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 28A7D58011F; Wed, 16 Sep 2020 12:57:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 16 Sep 2020 12:57:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=u8jbHISbSUUNQj4aheiIBcbQzWT dwA6DbD/UfopS5AA=; b=EyG/8c0/G9xXeiBHnZNVdtJY6d8BC2rME/t6/EmIQFV 47BAhwZnUMP/57J73C7Iyn9wyo+lbqv+5FBwjwE8AUg+U+PDqkt2R5DOunVh6Zk8 F4rtXpTUCOP5f/2bzEzPbKZjaZSR448COTL0a+H6eve3TzS/Y67ZwZoCmsciVgmQ 1rNtEy3kz44B4cNmbogojSsgi4qtGeQaN4ikvROrFDAuCOSgtCIW6VWXOJBby9qe eJgW/Ri0E1hAo+b7DWfu555RGsrNoW5daaKJ1sxqqgoubECBq2GCTb/wqUVOwXFZ SEdBDYItV/nZ7ldBsl8Th6zxWoyTRUVO+OyOTRR0nqQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=u8jbHI SbSUUNQj4aheiIBcbQzWTdwA6DbD/UfopS5AA=; b=uJDj+5FtdycqWiX+jymszg EiwsCklp8q3zAgck221U68jcnEEbhAeOD+kWt9idE/lYtvpqUyYTkgemngX3GAhZ yTdM2INsE6lvgwggnqv8/iWKmBhJgfL4A6oDbYpxbzNLIOvwmMwt6uGiAQ+zCOZ2 nodz4iceUK8FjwA7F7Ex5O8QvwZdT6zwPeq/hGrG2RR5fmQ/nc21oP5+Z095Vd0J HVynvFBwQBffR5Bbphmt6Qd956KywUykDT4MCe9AGOFgUI5Kefq9iAnYlBSO6EAE 4jaVVVPvndPJmecnlQurDaFh0jKLOWEG/VdrGY37DJC9ldMsrvPFJp/16HBOmQjA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrtddvgddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddunecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepuddvudfhkeekhefgffetffelgffftdehffduffegveetffehueeivddvjedv gfevnecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 017CD328005A; Wed, 16 Sep 2020 12:57:06 -0400 (EDT) Date: Wed, 16 Sep 2020 18:57:05 +0200 From: Maxime Ripard To: Hoegeun Kwon Subject: Re: [PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline Message-ID: <20200916165705.7pfgesma47vgkfxt@gilmour.lan> References: <20200908120019.3rmhzoijoijrbb7d@gilmour.lan> <3e113525-aa89-b1e2-56b7-ca55bd41d057@samsung.com> MIME-Version: 1.0 In-Reply-To: <3e113525-aa89-b1e2-56b7-ca55bd41d057@samsung.com> X-Mailman-Approved-At: Thu, 17 Sep 2020 08:08:02 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Tim Gover , Dave Stevenson , Stephen Boyd , Kamal Dasu , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, =?utf-8?B?64KY7ISx6rWt?= , Phil Elwell , Nicolas Saenz Julienne Content-Type: multipart/mixed; boundary="===============0631032797==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============0631032797== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zlz5rlu4elwsvrxu" Content-Disposition: inline --zlz5rlu4elwsvrxu Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 14, 2020 at 07:14:11PM +0900, Hoegeun Kwon wrote: > Hi Maxime, >=20 > On 9/8/20 9:00 PM, Maxime Ripard wrote: > > Hi Hoegeun, > > > > On Mon, Sep 07, 2020 at 08:49:12PM +0900, Hoegeun Kwon wrote: > >> On 9/3/20 5:00 PM, Maxime Ripard wrote: > >>> Hi everyone, > >>> > >>> Here's a (pretty long) series to introduce support in the VC4 DRM dri= ver > >>> for the display pipeline found in the BCM2711 (and thus the Raspberry= Pi 4). > >>> > >>> The main differences are that there's two HDMI controllers and that t= here's > >>> more pixelvalve now. Those pixelvalve come with a mux in the HVS that= still > >>> have only 3 FIFOs. Both of those differences are breaking a bunch of > >>> expectations in the driver, so we first need a good bunch of cleanup = and > >>> reworks to introduce support for the new controllers. > >>> > >>> Similarly, the HDMI controller has all its registers shuffled and spl= it in > >>> multiple controllers now, so we need a bunch of changes to support th= is as > >>> well. > >>> > >>> Only the HDMI support is enabled for now (even though the DPI and DSI > >>> outputs have been tested too). > >>> > >>> Let me know if you have any comments > >>> Maxime > >>> > >>> Cc: bcm-kernel-feedback-list@broadcom.com > >>> Cc: devicetree@vger.kernel.org > >>> Cc: Kamal Dasu > >>> Cc: Philipp Zabel > >>> Cc: Rob Herring > >>> Cc: Stephen Boyd > >>> > >>> Changes from v4: > >>> - Rebased on top of next-20200828 > >>> - Collected the various tags > >>> - Fixed some issues with 4k support and dual output (thanks Hoege= un!) > >> Thanks for your v5 patchset. > >> > >> I tested all patches based on the next-20200812. > > Thanks again for testing all the patches > > > >> Everything else is fine, but the dual hdmi modetest doesn't work well = in my > >> environment... > >> > >> In my environment, dsi is not connected, I have seen your answer[1]. > > Can you share a bit more your setup? What monitors are being connected > > to each HDMI port? Do you hotplug any? > Yes, Monitors are being connected to each HDMI ports. (did not use hotplu= g) >=20 > When booting, both HDMI-0 and 1 are recognized and the kernel log is outp= ut. > But after run modetest on HDMI-0(works) and modetest on HDMI-1(works), > crtc timed out occurs on HDMI-0 and does not work. >=20 > When HDMI-0 is not working we do a modetest on HDMI-0, it will work agin > after about 40 sec. >=20 > Below is the log for modetest. >=20 >=20 > root:~> modetest -Mvc4 -s 32:1280x720 =A0=A0=A0 =A0=A0=A0 - HDMI-0 works > setting mode 1280x720-60Hz@XR24 on connectors 32, crtc 64 > failed to set gamma: Invalid argument >=20 > root:~> modetest -Mvc4 -s 32:1280x720 =A0=A0=A0 =A0=A0=A0 - HDMI-0 works > setting mode 1280x720-60Hz@XR24 on connectors 32, crtc 64 > failed to set gamma: Invalid argument >=20 > root:~> modetest -Mvc4 -s 38:1280x720 =A0=A0=A0 =A0=A0=A0 - HDMI-1 works > setting mode 1280x720-60Hz@XR24 on connectors 38, crtc 69 > failed to set gamma: Invalid argument >=20 > =A0=A0=A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0=A0= =A0 =A0=A0=A0 - Crtc timed out occurs on HDMI-0 and=20 > does not work. >=20 > [=A0=A0 71.134283] [drm:drm_atomic_helper_wait_for_flip_done] *ERROR*=20 > [CRTC:64:crtc-3] flip_done timed out > [=A0=A0 81.374296] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*= =20 > [CRTC:64:crtc-3] flip_done timed out > [=A0=A0 91.618380] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*= =20 > [CONNECTOR:32:HDMI-A-1] flip_done timed out > [=A0 101.854274] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [PLANE:60:plane-3] flip_done timed out >=20 > [=A0 112.094271] [drm:drm_atomic_helper_wait_for_flip_done] *ERROR*=20 > [CRTC:64:crtc-3] flip_done timed out > [=A0 122.590311] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [CRTC:64:crtc-3] flip_done timed out >=20 > root:~> modetest -Mvc4 -s 32:1280x720 > [=A0 132.830309] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [CONNECTOR:32:HDMI-A-1] flip_done timed out > [=A0 143.070307] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [PLANE:60:plane-3] flip_done timed out > [=A0 153.310303] [drm:drm_atomic_helper_wait_for_flip_done] *ERROR*=20 > [CRTC:64:crtc-3] flip_done timed out > setting mode 1280x720-60Hz@XR24 on connectors 32, crtc 64 > [=A0 163.550340] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [CRTC:64:crtc-3] flip_done timed out > [=A0 173.790277] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [CONNECTOR:32:HDMI-A-1] flip_done timed out > [=A0 184.030286] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR*=20 > [PLANE:60:plane-3] flip_done timed out > failed to set gamma: Invalid argument =A0=A0=A0 =A0=A0=A0 - HDMI-0 works Thanks :) I was able to reproduce it just by also letting X boot. I'm on a good path to fix it and found a workaround. I'll send you the patch in the upcoming days :) Thanks again, Maxime --zlz5rlu4elwsvrxu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX2JD4QAKCRDj7w1vZxhR xRSMAQDJUj9nSuN6IyZmgUE3IaFEuev8g+P2MdyQzGg10MpHBQEA00Yn3whT31br uSzvMFoupb5cWMsYQo6Zh1bdS0ejIAg= =BQPM -----END PGP SIGNATURE----- --zlz5rlu4elwsvrxu-- --===============0631032797== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0631032797==--