From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 663CEC4727E for ; Thu, 1 Oct 2020 07:32:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32C19206D9 for ; Thu, 1 Oct 2020 07:32:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601537538; bh=H76vxfOOF5M3yKN9YciujFV8TF/VNxTCYlNS8B8c0l4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=NRN3TVr/QiZKDZ9xBLH/Tr9iICm4R5DOiVNBNKmpGYFEDXkfSQjI4EholB58uqVs+ AQYK6ehVw8S60m0NhqLjYHnA61zvBbCM0Wq4dmHb++FGn9L1MEi6A1m4AScNgTghU5 gknDxu4Nmhi3Q9PFmJ6jdoXuODrhEnMuTefnYzMY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731171AbgJAHcR (ORCPT ); Thu, 1 Oct 2020 03:32:17 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:34741 "EHLO mail-ej1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbgJAHcP (ORCPT ); Thu, 1 Oct 2020 03:32:15 -0400 Received: by mail-ej1-f67.google.com with SMTP id gr14so6579125ejb.1; Thu, 01 Oct 2020 00:32:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GDPrLOwa2YDIt9rOahcyvMHm5jBbfc6BnJW0QyGmLM8=; b=VFD+mFrAfDoGofYfm6GZ/0Etu5F5uu6cKAMglsCymGrXXBgZszwIuVqFA3cM8JQrhh 4pluvwCGv6FLm+FzUTNrmStPcvWmDf0vUdX/bF+E26tGwDnHNwPpger/EyCxPmxwMU3E 84rAFl/EjlOAA5H6zKTfa4GHa0SO5SVpBVyJKpx8LjMb0MycjASuFW3tGASFRz/3WxEj 5Te3TZZEHkxuF6+QNhYiPueWWCQYK5TEocUdHtE/jUveDKwMnDFNnCvqoWRd4MoIPw9x IXyfFsS394Tr6POrNEvXT1WWgPZDVBBiI/PZhhVwZOUmxbS4wH1VSLHY2goqGlcpIagZ FWYg== X-Gm-Message-State: AOAM533kMi8IW6SnqLp+f3LBdtsdtvSYJyGMJuo76KYlDyr7aw076Kpb dtqQ20ybqPQ1OQmWsBTGL4g= X-Google-Smtp-Source: ABdhPJzy3xgC6JU5blEUxdisaf5j4WjB6FYtXHbhypV1gfguZbrHfAJLc/4OCEMClu7A7rt/3kWtsw== X-Received: by 2002:a17:906:4c89:: with SMTP id q9mr6954374eju.290.1601537531522; Thu, 01 Oct 2020 00:32:11 -0700 (PDT) Received: from kozik-lap ([194.230.155.194]) by smtp.googlemail.com with ESMTPSA id p7sm539897edq.5.2020.10.01.00.32.09 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Oct 2020 00:32:10 -0700 (PDT) Date: Thu, 1 Oct 2020 09:32:08 +0200 From: Krzysztof Kozlowski To: Ahmad Fatoum Cc: Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Anson Huang , Andreas Kemnade , Stefan Riedmueller , Robert Jones , Li Yang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles Message-ID: <20201001073208.GA5208@kozik-lap> References: <20200930190143.27032-1-krzk@kernel.org> <20200930190143.27032-9-krzk@kernel.org> <0a0afea6-8cbb-3e89-5a4f-89660c942ca3@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0a0afea6-8cbb-3e89-5a4f-89660c942ca3@pengutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 01, 2020 at 09:22:03AM +0200, Ahmad Fatoum wrote: > Hello Krzysztof, > > On 9/30/20 9:01 PM, Krzysztof Kozlowski wrote: > > There are four flavors of TechNexion PICO-IMX6 boards. They have their > > own DTSes, even though in Dwarf, Nymph and Pi are exactly the same. > > They also have their own bindings so adjust the compatibles to match the > > bindings. > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Changes since v1: > > 1. None > > --- > > arch/arm/boot/dts/imx6dl-pico-dwarf.dts | 2 +- > > arch/arm/boot/dts/imx6dl-pico-hobbit.dts | 2 +- > > arch/arm/boot/dts/imx6dl-pico-nymph.dts | 2 +- > > arch/arm/boot/dts/imx6dl-pico-pi.dts | 2 +- > > 4 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm/boot/dts/imx6dl-pico-dwarf.dts b/arch/arm/boot/dts/imx6dl-pico-dwarf.dts > > index 659a8e8714ea..d85b15a8c127 100644 > > --- a/arch/arm/boot/dts/imx6dl-pico-dwarf.dts > > +++ b/arch/arm/boot/dts/imx6dl-pico-dwarf.dts > > @@ -13,5 +13,5 @@ > > > > / { > > model = "TechNexion PICO-IMX6 DualLite/Solo Board and Dwarf baseboard"; > > - compatible = "technexion,imx6dl-pico", "fsl,imx6dl"; > > + compatible = "technexion,imx6dl-pico-dwarf", "fsl,imx6dl"; > > Could you change this to have all three compatibles ("technexion,imx6dl-pico-dwarf", "technexion,imx6dl-pico", > "fsl,imx6dl") and likewise for the other files? > That way other firmware that reuses the Linux device tree files and match against the SoM compatible > continues to work after update. > > > }; > > diff --git a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts > > index d7403c5c4337..08fedcbcc91b 100644 > > --- a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts > > +++ b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts > > @@ -13,5 +13,5 @@ > > > > / { > > model = "TechNexion PICO-IMX6 DualLite/Solo Board and Hobbit baseboard"; > > - compatible = "technexion,imx6dl-pico", "fsl,imx6dl"; > > + compatible = "technexion,imx6dl-pico-hobbit", "fsl,imx6dl"; > > }; > > diff --git a/arch/arm/boot/dts/imx6dl-pico-nymph.dts b/arch/arm/boot/dts/imx6dl-pico-nymph.dts > > index b282dbf953aa..32ccfc5d41ce 100644 > > --- a/arch/arm/boot/dts/imx6dl-pico-nymph.dts > > +++ b/arch/arm/boot/dts/imx6dl-pico-nymph.dts > > @@ -13,5 +13,5 @@ > > > > / { > > model = "TechNexion PICO-IMX6 DualLite/Solo Board and Nymph baseboard"; > > - compatible = "technexion,imx6dl-pico", "fsl,imx6dl"; > > + compatible = "technexion,imx6dl-pico-nymph", "fsl,imx6dl"; > > }; > > diff --git a/arch/arm/boot/dts/imx6dl-pico-pi.dts b/arch/arm/boot/dts/imx6dl-pico-pi.dts > > index b7b1c07f96f3..4590e8ad9a91 100644 > > --- a/arch/arm/boot/dts/imx6dl-pico-pi.dts > > +++ b/arch/arm/boot/dts/imx6dl-pico-pi.dts The bindings, added in commit 53b61224ca40 ("dt-bindings: arm: fsl: Add TechNexion boards"), describe that these are the only valid compatibles. "technexion,imx6dl-pico" is not valid and would require changing the bindings, thus breaking compatibility which you want to avoid. The bindings, not what is present in DTS, is considered ABI. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DA3EC4727C for ; Thu, 1 Oct 2020 07:34:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C323F206D9 for ; Thu, 1 Oct 2020 07:34:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FTsvUeKn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C323F206D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LGyfUebZkbvruDxEp0ny0BIsYZCrPKSJTRBzFXibyfE=; b=FTsvUeKnq1VRW2NyMDR9boLWP FghAc3Pi2J+1GiW1IiWW19ZImCM9s2c5epmmuTfuq0uRyatI5aohqLiOF/4gc4EvIJEBQz8RCe4E5 kFHb9QH/FICaxgQfCnkgptNtu84iC20bWFjdBw86O8OSMX++Lg53FYbgmFyjzKgtjfKVfxEFEAX0+ FyMJBDr1khDg+wbEzLO+p/BC1U2iSej5d5rrou+6O9ZfxnsuIU0NOAHEgol7QjztHowPM7+iDaLig YsrWcN4bPxdwRDqGBs4OOkz2iSaTUL6OpscUk8sSWAt5TXiE7vQ4jUX7z983whu37CfgllEYAGqTn RtNt8nPGA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNt4a-0000Ro-Hm; Thu, 01 Oct 2020 07:32:16 +0000 Received: from mail-ej1-f66.google.com ([209.85.218.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNt4X-0000Qx-DN for linux-arm-kernel@lists.infradead.org; Thu, 01 Oct 2020 07:32:14 +0000 Received: by mail-ej1-f66.google.com with SMTP id qp15so5612454ejb.3 for ; Thu, 01 Oct 2020 00:32:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GDPrLOwa2YDIt9rOahcyvMHm5jBbfc6BnJW0QyGmLM8=; b=qDa3bYEGBEjiPMSrB+nQuwhQ4vlsy7qt/dmnd+26hv9U86IlGehf47EIZhIr8/7Yqg nYru0h0dnokVMj1dhqSXnAMYn+fARJVpQNdeOKlRQP4/TL0hgQmLBunGz7r+wAWFoedP YyzeVwCsJMBlwdjaiO5lfgOgwSf0RSAkCHrEWPdncUWPe7mXCU0VFDCnPGD/Q4YXUXA5 ASzn1X/FtnKZ2mZ3Ihe9D6ZLWhqSZpu4Wl1amdPTi7iaCyt8JikSr+CKJnbuSmbjpGw6 yhj7eCeys95vPFCvPYbeBGRRYaKTdKhi8K00ARNatKx8z+YAhxZseX2cA4UECEHJ4L78 sUyQ== X-Gm-Message-State: AOAM5308L79Kmmaay/4+1As4WyPpUsKuqqr4ZxkGc6IHhDqWINbPtSxD Ysf+9OjciVZyKlKm0d3hiDc= X-Google-Smtp-Source: ABdhPJzy3xgC6JU5blEUxdisaf5j4WjB6FYtXHbhypV1gfguZbrHfAJLc/4OCEMClu7A7rt/3kWtsw== X-Received: by 2002:a17:906:4c89:: with SMTP id q9mr6954374eju.290.1601537531522; Thu, 01 Oct 2020 00:32:11 -0700 (PDT) Received: from kozik-lap ([194.230.155.194]) by smtp.googlemail.com with ESMTPSA id p7sm539897edq.5.2020.10.01.00.32.09 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Oct 2020 00:32:10 -0700 (PDT) Date: Thu, 1 Oct 2020 09:32:08 +0200 From: Krzysztof Kozlowski To: Ahmad Fatoum Subject: Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles Message-ID: <20201001073208.GA5208@kozik-lap> References: <20200930190143.27032-1-krzk@kernel.org> <20200930190143.27032-9-krzk@kernel.org> <0a0afea6-8cbb-3e89-5a4f-89660c942ca3@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0a0afea6-8cbb-3e89-5a4f-89660c942ca3@pengutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_033213_478987_CDAE8736 X-CRM114-Status: GOOD ( 23.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Robert Jones , Stefan Riedmueller , Anson Huang , Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, Li Yang , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Andreas Kemnade , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 01, 2020 at 09:22:03AM +0200, Ahmad Fatoum wrote: > Hello Krzysztof, > > On 9/30/20 9:01 PM, Krzysztof Kozlowski wrote: > > There are four flavors of TechNexion PICO-IMX6 boards. They have their > > own DTSes, even though in Dwarf, Nymph and Pi are exactly the same. > > They also have their own bindings so adjust the compatibles to match the > > bindings. > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Changes since v1: > > 1. None > > --- > > arch/arm/boot/dts/imx6dl-pico-dwarf.dts | 2 +- > > arch/arm/boot/dts/imx6dl-pico-hobbit.dts | 2 +- > > arch/arm/boot/dts/imx6dl-pico-nymph.dts | 2 +- > > arch/arm/boot/dts/imx6dl-pico-pi.dts | 2 +- > > 4 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm/boot/dts/imx6dl-pico-dwarf.dts b/arch/arm/boot/dts/imx6dl-pico-dwarf.dts > > index 659a8e8714ea..d85b15a8c127 100644 > > --- a/arch/arm/boot/dts/imx6dl-pico-dwarf.dts > > +++ b/arch/arm/boot/dts/imx6dl-pico-dwarf.dts > > @@ -13,5 +13,5 @@ > > > > / { > > model = "TechNexion PICO-IMX6 DualLite/Solo Board and Dwarf baseboard"; > > - compatible = "technexion,imx6dl-pico", "fsl,imx6dl"; > > + compatible = "technexion,imx6dl-pico-dwarf", "fsl,imx6dl"; > > Could you change this to have all three compatibles ("technexion,imx6dl-pico-dwarf", "technexion,imx6dl-pico", > "fsl,imx6dl") and likewise for the other files? > That way other firmware that reuses the Linux device tree files and match against the SoM compatible > continues to work after update. > > > }; > > diff --git a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts > > index d7403c5c4337..08fedcbcc91b 100644 > > --- a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts > > +++ b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts > > @@ -13,5 +13,5 @@ > > > > / { > > model = "TechNexion PICO-IMX6 DualLite/Solo Board and Hobbit baseboard"; > > - compatible = "technexion,imx6dl-pico", "fsl,imx6dl"; > > + compatible = "technexion,imx6dl-pico-hobbit", "fsl,imx6dl"; > > }; > > diff --git a/arch/arm/boot/dts/imx6dl-pico-nymph.dts b/arch/arm/boot/dts/imx6dl-pico-nymph.dts > > index b282dbf953aa..32ccfc5d41ce 100644 > > --- a/arch/arm/boot/dts/imx6dl-pico-nymph.dts > > +++ b/arch/arm/boot/dts/imx6dl-pico-nymph.dts > > @@ -13,5 +13,5 @@ > > > > / { > > model = "TechNexion PICO-IMX6 DualLite/Solo Board and Nymph baseboard"; > > - compatible = "technexion,imx6dl-pico", "fsl,imx6dl"; > > + compatible = "technexion,imx6dl-pico-nymph", "fsl,imx6dl"; > > }; > > diff --git a/arch/arm/boot/dts/imx6dl-pico-pi.dts b/arch/arm/boot/dts/imx6dl-pico-pi.dts > > index b7b1c07f96f3..4590e8ad9a91 100644 > > --- a/arch/arm/boot/dts/imx6dl-pico-pi.dts > > +++ b/arch/arm/boot/dts/imx6dl-pico-pi.dts The bindings, added in commit 53b61224ca40 ("dt-bindings: arm: fsl: Add TechNexion boards"), describe that these are the only valid compatibles. "technexion,imx6dl-pico" is not valid and would require changing the bindings, thus breaking compatibility which you want to avoid. The bindings, not what is present in DTS, is considered ABI. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel