From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C055C4727C for ; Thu, 1 Oct 2020 09:14:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC5F320BED for ; Thu, 1 Oct 2020 09:14:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TyQxrpE+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730785AbgJAJOr (ORCPT ); Thu, 1 Oct 2020 05:14:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33098 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725938AbgJAJOq (ORCPT ); Thu, 1 Oct 2020 05:14:46 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601543685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZHaZJqQeWrMgGt90n+OaPG8WeULMMfrsVBml/9xpZNg=; b=TyQxrpE+ozBsnRRT6dIBwMLwvlPWhVZMk21XAwx6CpEaKqv902bOnH8ilGgrW4AAsydCxG Mm4Ttyklt34PpZ+YnjjBhQ/8udhGRsCG64ytqa09PWd2Ukf0oNBYLUpC1WCt58aglldM+7 hRazX/9sbBpCANiGO2mQYFhovLdtYOU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-371-jjA16oqsOQii5uyODPVHiQ-1; Thu, 01 Oct 2020 05:14:43 -0400 X-MC-Unique: jjA16oqsOQii5uyODPVHiQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 87F35101FFC4 for ; Thu, 1 Oct 2020 09:14:41 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.40.193.100]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6529B672CD; Thu, 1 Oct 2020 09:14:37 +0000 (UTC) Date: Thu, 1 Oct 2020 11:14:35 +0200 From: Andrew Jones To: Thomas Huth Cc: kvm@vger.kernel.org, pbonzini@redhat.com, lvivier@redhat.com Subject: Re: [PATCH v2 5/7] arm/pmu: Fix inline assembly for Clang Message-ID: <20201001091435.vhpkrogomzqmihpm@kamzik.brq.redhat.com> References: <20201001072234.143703-1-thuth@redhat.com> <20201001072234.143703-6-thuth@redhat.com> <20201001091239.cfuazqd6ear726pd@kamzik.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201001091239.cfuazqd6ear726pd@kamzik.brq.redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Oct 01, 2020 at 11:12:43AM +0200, Andrew Jones wrote: > On Thu, Oct 01, 2020 at 09:22:32AM +0200, Thomas Huth wrote: > > Clang complains here: > > > > arm/pmu.c:201:16: error: value size does not match register size specified by > > the constraint and modifier [-Werror,-Wasm-operand-widths] > > : [pmcr] "r" (pmcr) > > ^ > > arm/pmu.c:194:18: note: use constraint modifier "w" > > " msr pmcr_el0, %[pmcr]\n" > > ^~~~~~~ > > %w[pmcr] > > arm/pmu.c:200:17: error: value size does not match register size specified by > > the constraint and modifier [-Werror,-Wasm-operand-widths] > > : [loop] "+r" (loop) > > ^ > > arm/pmu.c:196:11: note: use constraint modifier "w" > > "1: subs %[loop], %[loop], #1\n" > > ^~~~~~~ > > %w[loop] > > arm/pmu.c:200:17: error: value size does not match register size specified by > > the constraint and modifier [-Werror,-Wasm-operand-widths] > > : [loop] "+r" (loop) > > ^ > > arm/pmu.c:196:20: note: use constraint modifier "w" > > "1: subs %[loop], %[loop], #1\n" > > ^~~~~~~ > > %w[loop] > > arm/pmu.c:284:35: error: value size does not match register size specified > > by the constraint and modifier [-Werror,-Wasm-operand-widths] > > : [addr] "r" (addr), [pmcr] "r" (pmcr), [loop] "r" (loop) > > ^ > > arm/pmu.c:274:28: note: use constraint modifier "w" > > " msr pmcr_el0, %[pmcr]\n" > > ^~~~~~~ > > %w[pmcr] > > arm/pmu.c:284:54: error: value size does not match register size specified > > by the constraint and modifier [-Werror,-Wasm-operand-widths] > > : [addr] "r" (addr), [pmcr] "r" (pmcr), [loop] "r" (loop) > > ^ > > arm/pmu.c:276:23: note: use constraint modifier "w" > > " mov x10, %[loop]\n" > > ^~~~~~~ > > %w[loop] > > > > pmcr should be 64-bit since it is a sysreg, but for loop we can use the > > "w" modifier. > > > > Suggested-by: Drew Jones Not a huge deal, but I use my official first name 'Andrew' on my tags. I know, I like confusing people by flipping back and forth between Andrew and Drew... Thanks, drew a.k.a Andrew > > Signed-off-by: Thomas Huth > > --- > > arm/pmu.c | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > Reviewed-by: Andrew Jones > Tested-by: Andrew Jones