From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E90AFC47423 for ; Thu, 1 Oct 2020 10:37:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD44520796 for ; Thu, 1 Oct 2020 10:37:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601548631; bh=6vvfO+qBwaJ0wWvi5T+l4QVos7F+2AS1thtLY27tfpU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=QcdGgW+cfgOj39Pc0ci1QrxUrQS5XnoUPOMf6tQLMecUdp7HIkOlnrXc2EXQtIkEk xc+yDV+gmlFYL7fwRJO2JpLJJDQlp7uMjwBQgDBwMVUSHxJrBmvZeMiaV5QpSzF3T8 UeY1kqaS0HmHemvwM63Tkqo83s8cUDckOYEIdRFc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731983AbgJAKhK (ORCPT ); Thu, 1 Oct 2020 06:37:10 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:42590 "EHLO mail-ej1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731131AbgJAKhK (ORCPT ); Thu, 1 Oct 2020 06:37:10 -0400 Received: by mail-ej1-f67.google.com with SMTP id q13so7268419ejo.9; Thu, 01 Oct 2020 03:37:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XeATPLtiujNPtbWy8eOfYkG34Rmci3Rho1NFx2mqnxY=; b=HkMiNzaoqHVA27xblu9Ooe6Z+pjjPl1sq0Dt56f1ohLkDvR+kZ+hpyfv94LLcqVoW3 jy/vRnmaYyMYbhpPPS+C94+Z8u6NffZFNma1tY4NPFuJw8uGtosrNc3w7csl25rRUxsL 6hr5fnlKe/RXn6xZNXHX3PX14kEFH1QU+1BKE+p8MHdKiiHaJ0HkQ97vBwtBY1ZainYb VNOdUy6avQpacdHOBWGp4rbWgq9NFtJFSRYbV7pl6RvGQa9VSgU9mYA3rrk08hzEnc0A zspRYBIGHQ+ylLGzo1CoAuSv6q7wXxQhX/O8VIgrSQcNfM+EGCHUFTTEqaIy0kzKghEH zmtw== X-Gm-Message-State: AOAM532aI54vSv47EyqBhAkG/bOIPZ1u7HJ7ktE7w44QM9IWZYO1ZvT4 oSW+WSCWvtZtRULwfaPiNnw= X-Google-Smtp-Source: ABdhPJxL9pxjDS00Vg2RUHbokVDD46x2SLH6Tdd8HfjwLtwogfEvXijc454ys1aaalQGGOItX9p+hA== X-Received: by 2002:a17:906:b790:: with SMTP id dt16mr7064587ejb.33.1601548628154; Thu, 01 Oct 2020 03:37:08 -0700 (PDT) Received: from kozik-lap ([194.230.155.194]) by smtp.googlemail.com with ESMTPSA id q1sm3985967ejy.37.2020.10.01.03.37.06 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Oct 2020 03:37:07 -0700 (PDT) Date: Thu, 1 Oct 2020 12:37:04 +0200 From: Krzysztof Kozlowski To: Ahmad Fatoum Cc: Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Anson Huang , Andreas Kemnade , Stefan Riedmueller , Robert Jones , Li Yang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles Message-ID: <20201001103704.GA26287@kozik-lap> References: <20200930190143.27032-1-krzk@kernel.org> <20200930190143.27032-9-krzk@kernel.org> <0a0afea6-8cbb-3e89-5a4f-89660c942ca3@pengutronix.de> <20201001073208.GA5208@kozik-lap> <027fd826-6822-9e92-0c6c-2ebed63f4a07@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <027fd826-6822-9e92-0c6c-2ebed63f4a07@pengutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 01, 2020 at 12:19:08PM +0200, Ahmad Fatoum wrote: > Hi, > > On 10/1/20 9:32 AM, Krzysztof Kozlowski wrote: > > On Thu, Oct 01, 2020 at 09:22:03AM +0200, Ahmad Fatoum wrote: > >>> diff --git a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts > >>> index d7403c5c4337..08fedcbcc91b 100644 > >>> --- a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts > >>> +++ b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts > >>> @@ -13,5 +13,5 @@ > >>> > >>> / { > >>> model = "TechNexion PICO-IMX6 DualLite/Solo Board and Hobbit baseboard"; > >>> - compatible = "technexion,imx6dl-pico", "fsl,imx6dl"; > >>> + compatible = "technexion,imx6dl-pico-hobbit", "fsl,imx6dl"; > >>> }; > > > > The bindings, added in commit 53b61224ca40 ("dt-bindings: arm: fsl: Add > > TechNexion boards"), describe that these are the only valid compatibles. > > "technexion,imx6dl-pico" is not valid and would require changing the > > bindings, thus breaking compatibility which you want to avoid.> > > The bindings, not what is present in DTS, is considered ABI. > > The existing binding doesn't cover these boards then and needs to be > extended, no? How about following patch? What do you mean it doesn't cover? It was added exactly to handle them: + - technexion,imx6q-pico-dwarf # TechNexion i.MX6Q Pico-Dwarf + - technexion,imx6q-pico-hobbit # TechNexion i.MX6Q Pico-Hobbit + - technexion,imx6q-pico-nymph # TechNexion i.MX6Q Pico-Nymph + - technexion,imx6q-pico-pi # TechNexion i.MX6Q Pico-Pi > > [I guess we need to keep the two-compatible list they were originally > in for compatibility even if it's unused among upstream device trees?] You want to change both the binding (thus breaking the ABI) and update the DTS to reflect new ABI. Then why having a binding at all? I would assume that either binding is correct or DTS. You propose that both are wrong and both need changes... in such case this is clearly broken. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50206C47420 for ; Thu, 1 Oct 2020 10:38:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC13F2085B for ; Thu, 1 Oct 2020 10:38:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IJ4kUgdB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC13F2085B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aNJCKnE285XMtKbgdtc19q37ajk7L1D86sxUTE8qTiw=; b=IJ4kUgdBAwRui57w786PZbYCN 5kGsf4Z01rFN+0lnkKF62DqxSxR0hv7ubucrVzTBWHMTmmHf9XnNKjq83KmFyLWwarXm65BHkbgo1 akpfC2mUZiHK7u2PYT9fYDAVh9okOPgW1o6xhz8vzNL35T3rT8ZLW8eVo18C3kNLlsP6aTqWwBD80 yE5unuzORW9ewd+kCN0y3LRvrvYTbtmwu4NGWCUPc1jqlPNuSm5Etl0McZ2I2q1WAsDbFUe7aZZ0s o5TBHZviPFv+kICToHLsx0zZv+PeE1n4wT+hwUbAMozzJTKs8eYHRI78AgC7zzk3wVZe1O94lwEAl WpdV8uVfQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNvxY-0006IC-JX; Thu, 01 Oct 2020 10:37:12 +0000 Received: from mail-ej1-f67.google.com ([209.85.218.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNvxV-0006H8-O0 for linux-arm-kernel@lists.infradead.org; Thu, 01 Oct 2020 10:37:10 +0000 Received: by mail-ej1-f67.google.com with SMTP id ce10so1227889ejc.5 for ; Thu, 01 Oct 2020 03:37:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XeATPLtiujNPtbWy8eOfYkG34Rmci3Rho1NFx2mqnxY=; b=uFR3NtaMuH2Dk3GnJ+krBLBAPcbRwQUj5EfDE0+tx0sVjxLXbF6J2brosOjS8axD6f Yd55P6SZB5bIKMNi3u3fzpGiOdWElsnHPWm+2voqtjKb/wSv9kxXiLzBGzTUEjPQWMkH ATZnkMObOmZPgXwA+JRXT2wW3NxqzeTiudhdf533eybl9ihIBp7dUTpDDGNFscZ+81Le xezXj8E4QtpP4mHrNyzs0IWD2ld6//erZ6IqjbYSbGQa2nOPp8ysmphp6N6M3MyGXLP8 YAd2c8nfWDv97cv80iKjJ9E5YvoIpPWgaSMyHJ/u7QAa+9cEJRhZD4R0P09pQ8pydCSy MkPg== X-Gm-Message-State: AOAM532cSQ7eRWsxVyRfKVp+ztHchC24LEjpPzhwK1wJlnUZrATcHeXD lLm92XzkRs9FMLY5suoH7swnyvlmXRw= X-Google-Smtp-Source: ABdhPJxL9pxjDS00Vg2RUHbokVDD46x2SLH6Tdd8HfjwLtwogfEvXijc454ys1aaalQGGOItX9p+hA== X-Received: by 2002:a17:906:b790:: with SMTP id dt16mr7064587ejb.33.1601548628154; Thu, 01 Oct 2020 03:37:08 -0700 (PDT) Received: from kozik-lap ([194.230.155.194]) by smtp.googlemail.com with ESMTPSA id q1sm3985967ejy.37.2020.10.01.03.37.06 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Oct 2020 03:37:07 -0700 (PDT) Date: Thu, 1 Oct 2020 12:37:04 +0200 From: Krzysztof Kozlowski To: Ahmad Fatoum Subject: Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles Message-ID: <20201001103704.GA26287@kozik-lap> References: <20200930190143.27032-1-krzk@kernel.org> <20200930190143.27032-9-krzk@kernel.org> <0a0afea6-8cbb-3e89-5a4f-89660c942ca3@pengutronix.de> <20201001073208.GA5208@kozik-lap> <027fd826-6822-9e92-0c6c-2ebed63f4a07@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <027fd826-6822-9e92-0c6c-2ebed63f4a07@pengutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_063709_807336_8A92D5A1 X-CRM114-Status: GOOD ( 19.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Robert Jones , Stefan Riedmueller , Anson Huang , Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, Li Yang , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Andreas Kemnade , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 01, 2020 at 12:19:08PM +0200, Ahmad Fatoum wrote: > Hi, > > On 10/1/20 9:32 AM, Krzysztof Kozlowski wrote: > > On Thu, Oct 01, 2020 at 09:22:03AM +0200, Ahmad Fatoum wrote: > >>> diff --git a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts > >>> index d7403c5c4337..08fedcbcc91b 100644 > >>> --- a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts > >>> +++ b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts > >>> @@ -13,5 +13,5 @@ > >>> > >>> / { > >>> model = "TechNexion PICO-IMX6 DualLite/Solo Board and Hobbit baseboard"; > >>> - compatible = "technexion,imx6dl-pico", "fsl,imx6dl"; > >>> + compatible = "technexion,imx6dl-pico-hobbit", "fsl,imx6dl"; > >>> }; > > > > The bindings, added in commit 53b61224ca40 ("dt-bindings: arm: fsl: Add > > TechNexion boards"), describe that these are the only valid compatibles. > > "technexion,imx6dl-pico" is not valid and would require changing the > > bindings, thus breaking compatibility which you want to avoid.> > > The bindings, not what is present in DTS, is considered ABI. > > The existing binding doesn't cover these boards then and needs to be > extended, no? How about following patch? What do you mean it doesn't cover? It was added exactly to handle them: + - technexion,imx6q-pico-dwarf # TechNexion i.MX6Q Pico-Dwarf + - technexion,imx6q-pico-hobbit # TechNexion i.MX6Q Pico-Hobbit + - technexion,imx6q-pico-nymph # TechNexion i.MX6Q Pico-Nymph + - technexion,imx6q-pico-pi # TechNexion i.MX6Q Pico-Pi > > [I guess we need to keep the two-compatible list they were originally > in for compatibility even if it's unused among upstream device trees?] You want to change both the binding (thus breaking the ABI) and update the DTS to reflect new ABI. Then why having a binding at all? I would assume that either binding is correct or DTS. You propose that both are wrong and both need changes... in such case this is clearly broken. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel