From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5279C4727C for ; Thu, 1 Oct 2020 12:26:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 859492087D for ; Thu, 1 Oct 2020 12:26:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732067AbgJAM0n (ORCPT ); Thu, 1 Oct 2020 08:26:43 -0400 Received: from correo.us.es ([193.147.175.20]:49472 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731888AbgJAM0m (ORCPT ); Thu, 1 Oct 2020 08:26:42 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 913CDB56ED for ; Thu, 1 Oct 2020 14:26:41 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 83905DA73D for ; Thu, 1 Oct 2020 14:26:41 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 79421DA791; Thu, 1 Oct 2020 14:26:41 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 643B7DA78D; Thu, 1 Oct 2020 14:26:39 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 01 Oct 2020 14:26:39 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 46D3242EF9E4; Thu, 1 Oct 2020 14:26:39 +0200 (CEST) Date: Thu, 1 Oct 2020 14:26:38 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Devin Bayer Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH] nft: migrate man page examples with `meter` directive to sets Message-ID: <20201001122638.GA17685@salvia> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Applied with small nitpick. On Thu, Oct 01, 2020 at 11:30:27AM +0200, Devin Bayer wrote: > +# declare a set, bound to table "filter", in family "ip". > +# Timeout and size are mandatory because we will add elements from packet > path. > +# Entries will timeout after one minute, after which they might be > +# re-added if limit condition persists. > +nft add set ip filter blackhole \ > + "{ type ipv4_addr; timeout 1m; size 65536 }" > + > +# declare a set to store the limit per saddr. > +# This must be separate from blackhole since the timeout is different > +nft add set ip filter flood \ > + "{ type ipv4_addr; flags dynamic; timeout 10s; size 128000 }" Missing semi-colons after size. Please, double-check that what I have applied looks correct to you. Thanks.