From: Andrew Lunn <andrew@lunn.ch>
To: Igor Russkikh <irusskikh@marvell.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [EXT] Re: [PATCH net-next 3/3] net: atlantic: implement media detect feature via phy tunables
Date: Thu, 1 Oct 2020 14:56:59 +0200 [thread overview]
Message-ID: <20201001125659.GA4067422@lunn.ch> (raw)
In-Reply-To: <04e72671-aa3e-ac11-ef92-bb17fc633a60@marvell.com>
On Thu, Oct 01, 2020 at 01:18:06PM +0300, Igor Russkikh wrote:
> Hi Andrew,
>
> > Since this is your own PHY, not some magical black box, i assume you
> > actually know what value it is using? It probably even lists it in the
> > data sheet.
> >
> > So just hard code that value in the driver. That has got to be better
> > than saying the incorrect value of 1ms.
>
> You mean always return that value in get_, and ignore what we get in set_ ?
> That could be done, will investigate.
You should validate the set as well. Only two values are valid, 0 to
turn the feature off, and whatever the firmware is hard coded with.
This is where extack would be very useful. When the user initially
tries to set it to 42, you can return -EINVAL, plus a message listing
the acceptable values. The best you can do at the moment is write the
text to the kernel log.
Andrew
next prev parent reply other threads:[~2020-10-01 12:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 16:13 [PATCH net-next 0/3] net: atlantic: phy tunables from mac driver Igor Russkikh
2020-09-29 16:13 ` [PATCH net-next 1/3] ethtool: allow netdev driver to define phy tunables Igor Russkikh
2020-09-29 16:13 ` [PATCH net-next 2/3] net: atlantic: implement phy downshift feature Igor Russkikh
2020-09-29 17:10 ` Andrew Lunn
2020-09-30 8:34 ` Igor Russkikh
2020-09-29 16:13 ` [PATCH net-next 3/3] net: atlantic: implement media detect feature via phy tunables Igor Russkikh
2020-09-29 17:18 ` Andrew Lunn
2020-09-30 8:37 ` Igor Russkikh
2020-09-30 14:22 ` Andrew Lunn
2020-10-01 10:18 ` [EXT] " Igor Russkikh
2020-10-01 12:56 ` Andrew Lunn [this message]
2020-09-29 17:04 ` [PATCH net-next 0/3] net: atlantic: phy tunables from mac driver Andrew Lunn
2020-09-29 17:33 ` Jakub Kicinski
2020-09-29 18:47 ` Andrew Lunn
2020-09-30 0:09 ` Jakub Kicinski
2020-09-30 0:16 ` Andrew Lunn
2020-09-30 15:03 ` ethtool/phy tunables and extack (was Re: [PATCH net-next 0/3] net: atlantic: phy tunables from mac driver) Michal Kubecek
2020-09-30 15:16 ` Andrew Lunn
2020-09-30 15:31 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001125659.GA4067422@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.