From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0C4CC4727C for ; Thu, 1 Oct 2020 14:44:30 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A661720780 for ; Thu, 1 Oct 2020 14:44:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="MdZO4+c0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LtCdyJl5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A661720780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2E8EC18AA; Thu, 1 Oct 2020 16:43:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2E8EC18AA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1601563468; bh=uy+2rX02uoztB5+RXblGcUyRIdIJJk5TokT0f77jF3Q=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MdZO4+c04O8G9dj25IzwNqwax4qq/TLyaYZXeIoy3bMvcdlRozRcZ0MXa95zBpKF5 IHOHhfX3wWF4wqvr8RxHyuP1oq+FebsVcsNAMnOmOeTXIHUCVCqdTLPlXwvjiV2CPi WjR/uFFv6lOBT3uQKxRXUwO2Nn9q4DrrOMhQ8KUo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C99EEF801DB; Thu, 1 Oct 2020 16:43:37 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1308AF80105; Thu, 1 Oct 2020 16:43:36 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E1CECF80105 for ; Thu, 1 Oct 2020 16:43:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E1CECF80105 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LtCdyJl5" Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D1E9820780; Thu, 1 Oct 2020 14:43:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601563408; bh=uy+2rX02uoztB5+RXblGcUyRIdIJJk5TokT0f77jF3Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LtCdyJl5aHgXH4xqBfkoPABYne67ljwDJVZXXOleB1YXDKWwDeuvb35URs+D5WkUg sdYkzN5eS8OeCW7mDuIt1VvH2p1VogtJs7OUAHr0r9qEpjohsbMoltjobLAUyv/1WP wMihtdjxSEAMH2M5nar5+ZGtiWASgjBSTiZT3x3s= Date: Thu, 1 Oct 2020 16:43:29 +0200 From: Greg KH To: Parav Pandit Subject: Re: [PATCH 1/6] Add ancillary bus support Message-ID: <20201001144329.GA2399339@kroah.com> References: <20200930225051.889607-1-david.m.ertman@intel.com> <20200930225051.889607-2-david.m.ertman@intel.com> <20201001110551.GD1939744@kroah.com> <20201001115847.GY816047@nvidia.com> <20201001121423.GA2375307@kroah.com> <20201001143334.GA1103926@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: "alsa-devel@alsa-project.org" , Kiran Patil , "tiwai@suse.de" , "ranjani.sridharan@intel.com" , "pierre-louis.bossart@linux.intel.com" , Ranjani Sridharan , Fred Oh , "broonie@kernel.org" , Jason Gunthorpe , Dave Ertman , Dan Williams , Shiraz Saleem , Parav Pandit X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Oct 01, 2020 at 02:39:06PM +0000, Parav Pandit wrote: > > > Why is this two-step process even needed here? > > > Without this documented, you will have problems. > > And it is also documented in "Ancillary device" section in the Documentation/driver-api/ancillary_bus.rst > Below is the snippet from the patch. > > It is likely worth to add this part of the documentation using standard kernel kdoc format where export function definition of initialize() and add() resides, so that it cannot be missed out. That is what I asked for...