All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petko Manolov <petko.manolov@konsulko.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: usb: pegasus: Proper error handing when setting pegasus' MAC address
Date: Fri, 2 Oct 2020 10:57:42 +0300	[thread overview]
Message-ID: <20201002075742.GA1197@carbon> (raw)
In-Reply-To: <20201001.184218.21920326424555147.davem@davemloft.net>

On 20-10-01 18:42:18, David Miller wrote:
> From: Petko Manolov <petko.manolov@konsulko.com>
> Date: Tue, 29 Sep 2020 14:40:39 +0300
> 
> > -static void set_ethernet_addr(pegasus_t *pegasus)
> > +static int set_ethernet_addr(pegasus_t *pegasus)
> >  {
> 
> You change this to return an 'int' but no callers were updated to check it.
> 
> Furthermore, failure to probe a MAC address can be resolved by choosing a 
> random MAC address.  This handling is preferrable because it allows the 
> interface to still come up successfully.

Thanks for looking into this.  V2 already sent.

      parent reply	other threads:[~2020-10-02  7:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-29 11:40 [PATCH] net: usb: pegasus: Proper error handing when setting pegasus' MAC address Petko Manolov
2020-10-02  1:42 ` David Miller
2020-10-02  7:56   ` [PATCH v2] " Petko Manolov
2020-10-02  7:57   ` Petko Manolov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201002075742.GA1197@carbon \
    --to=petko.manolov@konsulko.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.