From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4E1DC4363D for ; Fri, 2 Oct 2020 18:06:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36BED206DD for ; Fri, 2 Oct 2020 18:06:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="J7kgY6cw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388386AbgJBSGG (ORCPT ); Fri, 2 Oct 2020 14:06:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726224AbgJBSGF (ORCPT ); Fri, 2 Oct 2020 14:06:05 -0400 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A903C0613E2 for ; Fri, 2 Oct 2020 11:06:05 -0700 (PDT) Received: by mail-qk1-x742.google.com with SMTP id v123so2336058qkd.9 for ; Fri, 02 Oct 2020 11:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=+LaXP0gz54Jegk2Sj4FZgrVo6ri43ZoIhALcEdceV7s=; b=J7kgY6cwrb58DOoexGugRCEp3mOA3N2SuE3K7Vkq5DNITA7cVKmdZqs7c/H8mPlIXn o8UTppelOaWj/A+mIwckLvjSUAU505SsEF3y1UzB63e8RdNoL/7u/+lTbA+W+QbJg49u gjsGdY/ede4W2O1vArxPiL2+QKZNSLtPznD4UnaDnr+9U1NqECZIyPugGKiO/byu4Wsr ZiE32MDkyDjSRgUA3y85ay+ogHthqSIXcOgCRKKR9TEo8YPT5+VwXEqNByR4xXZxn6eZ DL3Xo9PmsQDfglZGmXIoeYvA5RBCHAUhpl0ys8t6dV8rIql31yOwXhGQ93xvBlsHWoj8 tkUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+LaXP0gz54Jegk2Sj4FZgrVo6ri43ZoIhALcEdceV7s=; b=WdWwg3zWKK3x3i1lX3VgDr6DY5kUGMkVNvI4vVmUAsxdW4SxwXJUs7M+Eb+5YTj0Aa pV4emzREhRBQci/ql6N58wvwa9TXhaDoSxJezqi0NE+0pFHbD6qVPbWOJpJE6Ruo9yDY NKEoiVcKouLbzvOdw9B0gaJmTcQu29JcldhFQKT+n6dRU8Tpz2oqd4U3UCYIhtX20jad 7uojpo6WudKQF9dCvDl41HnZjo22y044/fWjXLi1ThCIbqanb3K7uGfUDWIj418FMtL4 GTjRIsefYVq4zN2vqpqx1YBJNyV4bnXq1JqYh4Nfh8iykhjIDSYiHvG0az22xQsHum95 ZXvA== X-Gm-Message-State: AOAM530ollmBdJuMFvYou1OZY1Fo3cqGpFZv4HpzSwj8ks099iMTQI46 Nb39F+PbtPPl8E6DJV3fHYfNYA== X-Google-Smtp-Source: ABdhPJxx4jEaLX4t/GDgPp9QrFZRDhny976xDexrly3ltPkHkc73Gz3CvOBBFQXoSMUgBgbH3LKfmw== X-Received: by 2002:ae9:f70d:: with SMTP id s13mr3396635qkg.215.1601661964700; Fri, 02 Oct 2020 11:06:04 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id i62sm1604038qkf.36.2020.10.02.11.06.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2020 11:06:04 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kOPRT-006GH8-H7; Fri, 02 Oct 2020 15:06:03 -0300 Date: Fri, 2 Oct 2020 15:06:03 -0300 From: Jason Gunthorpe To: Daniel Vetter Cc: DRI Development , LKML , Daniel Vetter , Andrew Morton , John Hubbard , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Jan Kara , Dan Williams , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM Message-ID: <20201002180603.GL9916@ziepe.ca> References: <20201002175303.390363-1-daniel.vetter@ffwll.ch> <20201002175303.390363-2-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201002175303.390363-2-daniel.vetter@ffwll.ch> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 02, 2020 at 07:53:03PM +0200, Daniel Vetter wrote: > For $reasons I've stumbled over this code and I'm not sure the change > to the new gup functions in 55a650c35fea ("mm/gup: frame_vector: > convert get_user_pages() --> pin_user_pages()") was entirely correct. > > This here is used for long term buffers (not just quick I/O) like > RDMA, and John notes this in his patch. But I thought the rule for > these is that they need to add FOLL_LONGTERM, which John's patch > didn't do. > > There is already a dax specific check (added in b7f0554a56f2 ("mm: > fail get_vaddr_frames() for filesystem-dax mappings")), so this seems > like the prudent thing to do. > > Signed-off-by: Daniel Vetter > Cc: Andrew Morton > Cc: John Hubbard > Cc: Jérôme Glisse > Cc: Jan Kara > Cc: Dan Williams > Cc: linux-mm@kvack.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-media@vger.kernel.org > Hi all, > > I stumbled over this and figured typing this patch can't hurt. Really > just to maybe learn a few things about how gup/pup is supposed to be > used (we have a bit of that in drivers/gpu), this here isn't really > ralated to anything I'm doing. FOLL_FORCE is a pretty big clue it should be FOLL_LONGTERM, IMHO > I'm also wondering whether the explicit dax check should be removed, > since FOLL_LONGTERM should take care of that already. Yep! Confirms the above! This get_vaddr_frames() thing looks impossible to use properly. How on earth does a driver guarentee "If @start belongs to VM_IO | VM_PFNMAP vma, we don't touch page structures and the caller must make sure pfns aren't reused for anything else while he is using them." The only possible way to do that is if the driver restricts the VMAs to ones it owns and interacts with the vm_private data to refcount something. Since every driver does this wrong anything that uses this is creating terrifying security issues. IMHO this whole API should be deleted :( Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE96C46466 for ; Fri, 2 Oct 2020 18:07:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E740B2085B for ; Fri, 2 Oct 2020 18:07:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FWjluVFL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="J7kgY6cw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E740B2085B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G85ZGXEgpZWrFAMwbqiqE4WAGnEyiUHf+pbE+cbrurU=; b=FWjluVFLz7y43hoN7PoxBQ7YY ZAXKqT3givY6M0QRYaWoa3Wxm02D8QxEdHpUL5FoSptwfywcuCVZUT9aYgSiQKid7lPHoZD0sREBc zhQ29US/dPMlWJkmc+2poKCIYKcdNgX7l5AS9/qf0Z8Pmaz8KjHgXQzx4pCw2g6wY5bSS2g9g0Fpq OgitlfFc2zic5ULZW1pFImY6OrwreTB/LHiEyjqXEwuK8H0jaOJh8BX+zRtiPlng93Hjlv3PPElNh U1z1Cr1ZVFxNZf5jJJ7TgREVTu63xfqL0BRAepHQu0xSBTfpXYgAf13MiDxvQp1MwstsZqCJ1Nrii e4ytW7qDQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOPRZ-0008Vd-9S; Fri, 02 Oct 2020 18:06:09 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOPRW-0008UU-TY for linux-arm-kernel@lists.infradead.org; Fri, 02 Oct 2020 18:06:07 +0000 Received: by mail-qk1-x744.google.com with SMTP id q5so2368150qkc.2 for ; Fri, 02 Oct 2020 11:06:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=+LaXP0gz54Jegk2Sj4FZgrVo6ri43ZoIhALcEdceV7s=; b=J7kgY6cwrb58DOoexGugRCEp3mOA3N2SuE3K7Vkq5DNITA7cVKmdZqs7c/H8mPlIXn o8UTppelOaWj/A+mIwckLvjSUAU505SsEF3y1UzB63e8RdNoL/7u/+lTbA+W+QbJg49u gjsGdY/ede4W2O1vArxPiL2+QKZNSLtPznD4UnaDnr+9U1NqECZIyPugGKiO/byu4Wsr ZiE32MDkyDjSRgUA3y85ay+ogHthqSIXcOgCRKKR9TEo8YPT5+VwXEqNByR4xXZxn6eZ DL3Xo9PmsQDfglZGmXIoeYvA5RBCHAUhpl0ys8t6dV8rIql31yOwXhGQ93xvBlsHWoj8 tkUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+LaXP0gz54Jegk2Sj4FZgrVo6ri43ZoIhALcEdceV7s=; b=InprXPf19krrC5Qee53EeJpQPDdQZe1p/ODhOG96ygjeiNu0zyJTgn9wpTU4PV4AOW llz2L9xOETTuNputtcSPvJQiGADwVS9JmyA+g0U+yh1FtISiHViXVWUR+ufPWf1azomb H3/oKhJ9meSsR+J7y3pL4f0+V/1F6shP/mtCTTuyOGHsKngE43WGxOFYVD7D8x02I9Q5 qS2wCTLSorsxIav3E6qdiGMyOqoUAo8UegQNysjluI4iU7m7/TMR9W/qm1f+QrJyRw1q NsY6gEggIX5DDKnU2eJ/BNXFJkEYlYAu9HpjmmxLYx35WxI2wh+Mizaxf0ghi0OB9uoM opPA== X-Gm-Message-State: AOAM5301mDunVyQSqRgdOYZ5n6F/twQ5PihQmTVvfc48xJv/0tntHEC1 EdvRjRIpis/TPgOCtjYRUtD++47PycNJ7ANL X-Google-Smtp-Source: ABdhPJxx4jEaLX4t/GDgPp9QrFZRDhny976xDexrly3ltPkHkc73Gz3CvOBBFQXoSMUgBgbH3LKfmw== X-Received: by 2002:ae9:f70d:: with SMTP id s13mr3396635qkg.215.1601661964700; Fri, 02 Oct 2020 11:06:04 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id i62sm1604038qkf.36.2020.10.02.11.06.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2020 11:06:04 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kOPRT-006GH8-H7; Fri, 02 Oct 2020 15:06:03 -0300 Date: Fri, 2 Oct 2020 15:06:03 -0300 From: Jason Gunthorpe To: Daniel Vetter Subject: Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM Message-ID: <20201002180603.GL9916@ziepe.ca> References: <20201002175303.390363-1-daniel.vetter@ffwll.ch> <20201002175303.390363-2-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201002175303.390363-2-daniel.vetter@ffwll.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201002_140607_001239_9CE8E7DD X-CRM114-Status: GOOD ( 22.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Jan Kara , John Hubbard , LKML , DRI Development , linux-mm@kvack.org, =?utf-8?B?SsOpcsO0bWU=?= Glisse , Daniel Vetter , Andrew Morton , Dan Williams , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBPY3QgMDIsIDIwMjAgYXQgMDc6NTM6MDNQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBGb3IgJHJlYXNvbnMgSSd2ZSBzdHVtYmxlZCBvdmVyIHRoaXMgY29kZSBhbmQgSSdt IG5vdCBzdXJlIHRoZSBjaGFuZ2UKPiB0byB0aGUgbmV3IGd1cCBmdW5jdGlvbnMgaW4gNTVhNjUw YzM1ZmVhICgibW0vZ3VwOiBmcmFtZV92ZWN0b3I6Cj4gY29udmVydCBnZXRfdXNlcl9wYWdlcygp IC0tPiBwaW5fdXNlcl9wYWdlcygpIikgd2FzIGVudGlyZWx5IGNvcnJlY3QuCj4gCj4gVGhpcyBo ZXJlIGlzIHVzZWQgZm9yIGxvbmcgdGVybSBidWZmZXJzIChub3QganVzdCBxdWljayBJL08pIGxp a2UKPiBSRE1BLCBhbmQgSm9obiBub3RlcyB0aGlzIGluIGhpcyBwYXRjaC4gQnV0IEkgdGhvdWdo dCB0aGUgcnVsZSBmb3IKPiB0aGVzZSBpcyB0aGF0IHRoZXkgbmVlZCB0byBhZGQgRk9MTF9MT05H VEVSTSwgd2hpY2ggSm9obidzIHBhdGNoCj4gZGlkbid0IGRvLgo+IAo+IFRoZXJlIGlzIGFscmVh ZHkgYSBkYXggc3BlY2lmaWMgY2hlY2sgKGFkZGVkIGluIGI3ZjA1NTRhNTZmMiAoIm1tOgo+IGZh aWwgZ2V0X3ZhZGRyX2ZyYW1lcygpIGZvciBmaWxlc3lzdGVtLWRheCBtYXBwaW5ncyIpKSwgc28g dGhpcyBzZWVtcwo+IGxpa2UgdGhlIHBydWRlbnQgdGhpbmcgdG8gZG8uCj4gCj4gU2lnbmVkLW9m Zi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4gQ2M6IEFuZHJl dyBNb3J0b24gPGFrcG1AbGludXgtZm91bmRhdGlvbi5vcmc+Cj4gQ2M6IEpvaG4gSHViYmFyZCA8 amh1YmJhcmRAbnZpZGlhLmNvbT4KPiBDYzogSsOpcsO0bWUgR2xpc3NlIDxqZ2xpc3NlQHJlZGhh dC5jb20+Cj4gQ2M6IEphbiBLYXJhIDxqYWNrQHN1c2UuY3o+Cj4gQ2M6IERhbiBXaWxsaWFtcyA8 ZGFuLmoud2lsbGlhbXNAaW50ZWwuY29tPgo+IENjOiBsaW51eC1tbUBrdmFjay5vcmcKPiBDYzog bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCj4gQ2M6IGxpbnV4LXNhbXN1bmct c29jQHZnZXIua2VybmVsLm9yZwo+IENjOiBsaW51eC1tZWRpYUB2Z2VyLmtlcm5lbC5vcmcKPiBI aSBhbGwsCj4gCj4gSSBzdHVtYmxlZCBvdmVyIHRoaXMgYW5kIGZpZ3VyZWQgdHlwaW5nIHRoaXMg cGF0Y2ggY2FuJ3QgaHVydC4gUmVhbGx5Cj4ganVzdCB0byBtYXliZSBsZWFybiBhIGZldyB0aGlu Z3MgYWJvdXQgaG93IGd1cC9wdXAgaXMgc3VwcG9zZWQgdG8gYmUKPiB1c2VkICh3ZSBoYXZlIGEg Yml0IG9mIHRoYXQgaW4gZHJpdmVycy9ncHUpLCB0aGlzIGhlcmUgaXNuJ3QgcmVhbGx5Cj4gcmFs YXRlZCB0byBhbnl0aGluZyBJJ20gZG9pbmcuCgpGT0xMX0ZPUkNFIGlzIGEgcHJldHR5IGJpZyBj bHVlIGl0IHNob3VsZCBiZSBGT0xMX0xPTkdURVJNLCBJTUhPCgo+IEknbSBhbHNvIHdvbmRlcmlu ZyB3aGV0aGVyIHRoZSBleHBsaWNpdCBkYXggY2hlY2sgc2hvdWxkIGJlIHJlbW92ZWQsCj4gc2lu Y2UgRk9MTF9MT05HVEVSTSBzaG91bGQgdGFrZSBjYXJlIG9mIHRoYXQgYWxyZWFkeS4KClllcCEg Q29uZmlybXMgdGhlIGFib3ZlIQoKVGhpcyBnZXRfdmFkZHJfZnJhbWVzKCkgdGhpbmcgbG9va3Mg aW1wb3NzaWJsZSB0byB1c2UgcHJvcGVybHkuIEhvdyBvbgplYXJ0aCBkb2VzIGEgZHJpdmVyIGd1 YXJlbnRlZQoKICJJZiBAc3RhcnQgYmVsb25ncyB0byBWTV9JTyB8IFZNX1BGTk1BUCB2bWEsIHdl IGRvbid0IHRvdWNoIHBhZ2UKIHN0cnVjdHVyZXMgYW5kIHRoZSBjYWxsZXIgbXVzdCBtYWtlIHN1 cmUgcGZucyBhcmVuJ3QgcmV1c2VkIGZvcgogYW55dGhpbmcgZWxzZSB3aGlsZSBoZSBpcyB1c2lu ZyB0aGVtLiIKClRoZSBvbmx5IHBvc3NpYmxlIHdheSB0byBkbyB0aGF0IGlzIGlmIHRoZSBkcml2 ZXIgcmVzdHJpY3RzIHRoZSBWTUFzCnRvIG9uZXMgaXQgb3ducyBhbmQgaW50ZXJhY3RzIHdpdGgg dGhlIHZtX3ByaXZhdGUgZGF0YSB0byByZWZjb3VudApzb21ldGhpbmcuCgpTaW5jZSBldmVyeSBk cml2ZXIgZG9lcyB0aGlzIHdyb25nIGFueXRoaW5nIHRoYXQgdXNlcyB0aGlzIGlzIGNyZWF0aW5n CnRlcnJpZnlpbmcgc2VjdXJpdHkgaXNzdWVzLgoKSU1ITyB0aGlzIHdob2xlIEFQSSBzaG91bGQg YmUgZGVsZXRlZCA6KAoKSmFzb24KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66DC7C4363D for ; Sat, 3 Oct 2020 09:24:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 241D2206CA for ; Sat, 3 Oct 2020 09:24:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="J7kgY6cw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 241D2206CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CFCB26E342; Sat, 3 Oct 2020 09:23:46 +0000 (UTC) Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD60F6E9B1 for ; Fri, 2 Oct 2020 18:06:05 +0000 (UTC) Received: by mail-qk1-x742.google.com with SMTP id g72so2341601qke.8 for ; Fri, 02 Oct 2020 11:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=+LaXP0gz54Jegk2Sj4FZgrVo6ri43ZoIhALcEdceV7s=; b=J7kgY6cwrb58DOoexGugRCEp3mOA3N2SuE3K7Vkq5DNITA7cVKmdZqs7c/H8mPlIXn o8UTppelOaWj/A+mIwckLvjSUAU505SsEF3y1UzB63e8RdNoL/7u/+lTbA+W+QbJg49u gjsGdY/ede4W2O1vArxPiL2+QKZNSLtPznD4UnaDnr+9U1NqECZIyPugGKiO/byu4Wsr ZiE32MDkyDjSRgUA3y85ay+ogHthqSIXcOgCRKKR9TEo8YPT5+VwXEqNByR4xXZxn6eZ DL3Xo9PmsQDfglZGmXIoeYvA5RBCHAUhpl0ys8t6dV8rIql31yOwXhGQ93xvBlsHWoj8 tkUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+LaXP0gz54Jegk2Sj4FZgrVo6ri43ZoIhALcEdceV7s=; b=H14URRyxbRcjUd6gU9VD38COfgsybZxLgfi/ST1fSU0hKChzpHbCK07IQ2w2wCmR5d 0+G1z7relE79m+ziHTRUGT9MemdUl1AEr0cFt59v/TWAxfbyC9tGwTYMX3xaAP1J2lWh s/cbIn33BfuzURi4Qki+0tF9A04s0AfST2AoDbdAOIL9RyoG4uzAA81C3LHDBO86KeuE yYDiuj0xZZ6MUVrBvjQX+BMhrUxVeMH7vzufNHCBp37/cepzfloIlJygFfFzmSgDoFj0 PxgLJPTZ+dtyjtTWy9BqTmRgffyzF4YxvN5/0UuDG6m4CwqRh+Xy+hcxSSIzAjI8ifZp moMA== X-Gm-Message-State: AOAM532GsN8Ew1ck66eIq000rDI92d6fB3Wd2xcRzKYBpscjqgqKIrQX JrzVVY1y69iCFQH/7q87S2QQUw== X-Google-Smtp-Source: ABdhPJxx4jEaLX4t/GDgPp9QrFZRDhny976xDexrly3ltPkHkc73Gz3CvOBBFQXoSMUgBgbH3LKfmw== X-Received: by 2002:ae9:f70d:: with SMTP id s13mr3396635qkg.215.1601661964700; Fri, 02 Oct 2020 11:06:04 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id i62sm1604038qkf.36.2020.10.02.11.06.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2020 11:06:04 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kOPRT-006GH8-H7; Fri, 02 Oct 2020 15:06:03 -0300 Date: Fri, 2 Oct 2020 15:06:03 -0300 From: Jason Gunthorpe To: Daniel Vetter Subject: Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM Message-ID: <20201002180603.GL9916@ziepe.ca> References: <20201002175303.390363-1-daniel.vetter@ffwll.ch> <20201002175303.390363-2-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201002175303.390363-2-daniel.vetter@ffwll.ch> X-Mailman-Approved-At: Sat, 03 Oct 2020 09:23:39 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Jan Kara , John Hubbard , LKML , DRI Development , linux-mm@kvack.org, =?utf-8?B?SsOpcsO0bWU=?= Glisse , Daniel Vetter , Andrew Morton , Dan Williams , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCBPY3QgMDIsIDIwMjAgYXQgMDc6NTM6MDNQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBGb3IgJHJlYXNvbnMgSSd2ZSBzdHVtYmxlZCBvdmVyIHRoaXMgY29kZSBhbmQgSSdt IG5vdCBzdXJlIHRoZSBjaGFuZ2UKPiB0byB0aGUgbmV3IGd1cCBmdW5jdGlvbnMgaW4gNTVhNjUw YzM1ZmVhICgibW0vZ3VwOiBmcmFtZV92ZWN0b3I6Cj4gY29udmVydCBnZXRfdXNlcl9wYWdlcygp IC0tPiBwaW5fdXNlcl9wYWdlcygpIikgd2FzIGVudGlyZWx5IGNvcnJlY3QuCj4gCj4gVGhpcyBo ZXJlIGlzIHVzZWQgZm9yIGxvbmcgdGVybSBidWZmZXJzIChub3QganVzdCBxdWljayBJL08pIGxp a2UKPiBSRE1BLCBhbmQgSm9obiBub3RlcyB0aGlzIGluIGhpcyBwYXRjaC4gQnV0IEkgdGhvdWdo dCB0aGUgcnVsZSBmb3IKPiB0aGVzZSBpcyB0aGF0IHRoZXkgbmVlZCB0byBhZGQgRk9MTF9MT05H VEVSTSwgd2hpY2ggSm9obidzIHBhdGNoCj4gZGlkbid0IGRvLgo+IAo+IFRoZXJlIGlzIGFscmVh ZHkgYSBkYXggc3BlY2lmaWMgY2hlY2sgKGFkZGVkIGluIGI3ZjA1NTRhNTZmMiAoIm1tOgo+IGZh aWwgZ2V0X3ZhZGRyX2ZyYW1lcygpIGZvciBmaWxlc3lzdGVtLWRheCBtYXBwaW5ncyIpKSwgc28g dGhpcyBzZWVtcwo+IGxpa2UgdGhlIHBydWRlbnQgdGhpbmcgdG8gZG8uCj4gCj4gU2lnbmVkLW9m Zi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4gQ2M6IEFuZHJl dyBNb3J0b24gPGFrcG1AbGludXgtZm91bmRhdGlvbi5vcmc+Cj4gQ2M6IEpvaG4gSHViYmFyZCA8 amh1YmJhcmRAbnZpZGlhLmNvbT4KPiBDYzogSsOpcsO0bWUgR2xpc3NlIDxqZ2xpc3NlQHJlZGhh dC5jb20+Cj4gQ2M6IEphbiBLYXJhIDxqYWNrQHN1c2UuY3o+Cj4gQ2M6IERhbiBXaWxsaWFtcyA8 ZGFuLmoud2lsbGlhbXNAaW50ZWwuY29tPgo+IENjOiBsaW51eC1tbUBrdmFjay5vcmcKPiBDYzog bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCj4gQ2M6IGxpbnV4LXNhbXN1bmct c29jQHZnZXIua2VybmVsLm9yZwo+IENjOiBsaW51eC1tZWRpYUB2Z2VyLmtlcm5lbC5vcmcKPiBI aSBhbGwsCj4gCj4gSSBzdHVtYmxlZCBvdmVyIHRoaXMgYW5kIGZpZ3VyZWQgdHlwaW5nIHRoaXMg cGF0Y2ggY2FuJ3QgaHVydC4gUmVhbGx5Cj4ganVzdCB0byBtYXliZSBsZWFybiBhIGZldyB0aGlu Z3MgYWJvdXQgaG93IGd1cC9wdXAgaXMgc3VwcG9zZWQgdG8gYmUKPiB1c2VkICh3ZSBoYXZlIGEg Yml0IG9mIHRoYXQgaW4gZHJpdmVycy9ncHUpLCB0aGlzIGhlcmUgaXNuJ3QgcmVhbGx5Cj4gcmFs YXRlZCB0byBhbnl0aGluZyBJJ20gZG9pbmcuCgpGT0xMX0ZPUkNFIGlzIGEgcHJldHR5IGJpZyBj bHVlIGl0IHNob3VsZCBiZSBGT0xMX0xPTkdURVJNLCBJTUhPCgo+IEknbSBhbHNvIHdvbmRlcmlu ZyB3aGV0aGVyIHRoZSBleHBsaWNpdCBkYXggY2hlY2sgc2hvdWxkIGJlIHJlbW92ZWQsCj4gc2lu Y2UgRk9MTF9MT05HVEVSTSBzaG91bGQgdGFrZSBjYXJlIG9mIHRoYXQgYWxyZWFkeS4KClllcCEg Q29uZmlybXMgdGhlIGFib3ZlIQoKVGhpcyBnZXRfdmFkZHJfZnJhbWVzKCkgdGhpbmcgbG9va3Mg aW1wb3NzaWJsZSB0byB1c2UgcHJvcGVybHkuIEhvdyBvbgplYXJ0aCBkb2VzIGEgZHJpdmVyIGd1 YXJlbnRlZQoKICJJZiBAc3RhcnQgYmVsb25ncyB0byBWTV9JTyB8IFZNX1BGTk1BUCB2bWEsIHdl IGRvbid0IHRvdWNoIHBhZ2UKIHN0cnVjdHVyZXMgYW5kIHRoZSBjYWxsZXIgbXVzdCBtYWtlIHN1 cmUgcGZucyBhcmVuJ3QgcmV1c2VkIGZvcgogYW55dGhpbmcgZWxzZSB3aGlsZSBoZSBpcyB1c2lu ZyB0aGVtLiIKClRoZSBvbmx5IHBvc3NpYmxlIHdheSB0byBkbyB0aGF0IGlzIGlmIHRoZSBkcml2 ZXIgcmVzdHJpY3RzIHRoZSBWTUFzCnRvIG9uZXMgaXQgb3ducyBhbmQgaW50ZXJhY3RzIHdpdGgg dGhlIHZtX3ByaXZhdGUgZGF0YSB0byByZWZjb3VudApzb21ldGhpbmcuCgpTaW5jZSBldmVyeSBk cml2ZXIgZG9lcyB0aGlzIHdyb25nIGFueXRoaW5nIHRoYXQgdXNlcyB0aGlzIGlzIGNyZWF0aW5n CnRlcnJpZnlpbmcgc2VjdXJpdHkgaXNzdWVzLgoKSU1ITyB0aGlzIHdob2xlIEFQSSBzaG91bGQg YmUgZGVsZXRlZCA6KAoKSmFzb24KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg==