CC: kbuild-all(a)lists.01.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Dave Young <dyoung@redhat.com>
CC: Baoquan He <bhe@redhat.com>
CC: Vivek Goyal <vgoyal@redhat.com>
CC: Alexey Dobriyan <adobriyan@gmail.com>
CC: kexec(a)lists.infradead.org
CC: linux-kernel(a)vger.kernel.org
CC: linux-fsdevel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

fs/proc/vmcore.c:1507:2-7: WARNING: NULL check before some freeing functions is not needed.
fs/proc/vmcore.c:1510:2-7: WARNING: NULL check before some freeing functions is not needed.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Fixes: 5e0c074e5b4b ("coccinelle: ifnullfree: add vfree(), kvfree*() functions")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git for-5.10
head:   44d8870f21529cfa8f50b503b5d949c6d46e6fc1
commit: 5e0c074e5b4be02d57d1b60abc3391afe7edd088 [4/10] coccinelle: ifnullfree: add vfree(), kvfree*() functions
:::::: branch date: 24 hours ago
:::::: commit date: 4 weeks ago

Please take the patch only if it's a positive warning. Thanks!

 vmcore.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- a/fs/proc/vmcore.c
+++ b/fs/proc/vmcore.c
@@ -1503,11 +1503,9 @@ int vmcore_add_device_dump(struct vmcore
 	return 0;
 
 out_err:
-	if (buf)
-		vfree(buf);
+	vfree(buf);
 
-	if (dump)
-		vfree(dump);
+	vfree(dump);
 
 	return ret;
 }