From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2953849215446908920==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: ifnullfree: fix ifnullfree.cocci warnings Date: Sat, 03 Oct 2020 03:44:04 +0800 Message-ID: <20201002194404.GA528@8cbb73b479b5> In-Reply-To: <202010030349.ukMxko0g-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============2953849215446908920== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org TO: Denis Efremov CC: Julia Lawall CC: Dave Young CC: Baoquan He CC: Vivek Goyal CC: Alexey Dobriyan CC: kexec(a)lists.infradead.org CC: linux-kernel(a)vger.kernel.org CC: linux-fsdevel(a)vger.kernel.org From: kernel test robot fs/proc/vmcore.c:1507:2-7: WARNING: NULL check before some freeing function= s is not needed. fs/proc/vmcore.c:1510:2-7: WARNING: NULL check before some freeing function= s is not needed. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci Fixes: 5e0c074e5b4b ("coccinelle: ifnullfree: add vfree(), kvfree*() functi= ons") CC: Denis Efremov Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git f= or-5.10 head: 44d8870f21529cfa8f50b503b5d949c6d46e6fc1 commit: 5e0c074e5b4be02d57d1b60abc3391afe7edd088 [4/10] coccinelle: ifnullf= ree: add vfree(), kvfree*() functions :::::: branch date: 24 hours ago :::::: commit date: 4 weeks ago Please take the patch only if it's a positive warning. Thanks! vmcore.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- a/fs/proc/vmcore.c +++ b/fs/proc/vmcore.c @@ -1503,11 +1503,9 @@ int vmcore_add_device_dump(struct vmcore return 0; = out_err: - if (buf) - vfree(buf); + vfree(buf); = - if (dump) - vfree(dump); + vfree(dump); = return ret; } --===============2953849215446908920==--