From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Eric Biggers <ebiggers@kernel.org>,
linux-ext4@vger.kernel.org, syzkaller-bugs@googlegroups.com,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
syzbot+9f864abad79fae7c17e1@syzkaller.appspotmail.com
Subject: Re: [PATCH] ext4: fix leaking sysfs kobject after failed mount
Date: Sat, 3 Oct 2020 00:56:28 -0400 [thread overview]
Message-ID: <20201003045628.GH23474@mit.edu> (raw)
In-Reply-To: <20200924090859.GF27019@quack2.suse.cz>
On Thu, Sep 24, 2020 at 11:08:59AM +0200, Jan Kara wrote:
> On Tue 22-09-20 09:24:56, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > ext4_unregister_sysfs() only deletes the kobject. The reference to it
> > needs to be put separately, like ext4_put_super() does.
> >
> > This addresses the syzbot report
> > "memory leak in kobject_set_name_vargs (3)"
> > (https://syzkaller.appspot.com/bug?extid=9f864abad79fae7c17e1).
> >
> > Reported-by: syzbot+9f864abad79fae7c17e1@syzkaller.appspotmail.com
> > Fixes: 72ba74508b28 ("ext4: release sysfs kobject when failing to enable quotas on mount")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
>
> Looks good. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Thanks, applied.
- Ted
prev parent reply other threads:[~2020-10-03 4:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 10:02 memory leak in kobject_set_name_vargs (3) syzbot
2020-09-22 16:24 ` [PATCH] ext4: fix leaking sysfs kobject after failed mount Eric Biggers
2020-09-24 9:08 ` Jan Kara
2020-10-03 4:56 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201003045628.GH23474@mit.edu \
--to=tytso@mit.edu \
--cc=ebiggers@kernel.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+9f864abad79fae7c17e1@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.