From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4826937329689361316==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: api: fix device_attr_show.cocci warnings Date: Tue, 06 Oct 2020 15:21:40 +0800 Message-ID: <20201006072140.GA62092@04569d13596d> In-Reply-To: <202010061518.7kTqq0ri-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============4826937329689361316== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Denis Efremov CC: Julia Lawall CC: "Matan Ziv-Av" CC: Darren Hart CC: Andy Shevchenko CC: platform-driver-x86(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/platform/x86/lg-laptop.c:496:8-16: WARNING: use scnprintf or sprintf drivers/platform/x86/lg-laptop.c:322:8-16: WARNING: use scnprintf or sprintf drivers/platform/x86/lg-laptop.c:447:8-16: WARNING: use scnprintf or sprintf drivers/platform/x86/lg-laptop.c:406:8-16: WARNING: use scnprintf or sprintf drivers/platform/x86/lg-laptop.c:364:8-16: WARNING: use scnprintf or sprintf From Documentation/filesystems/sysfs.txt: show() must not use snprintf() when formatting the value to be returned to user space. If you can guarantee that an overflow will never happen you can use sprintf() otherwise you must use scnprintf(). Generated by: scripts/coccinelle/api/device_attr_show.cocci Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script") CC: Denis Efremov Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 7575fdda569b2a2e8be32c1a64ecb05d6f96a500 commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add devic= e_attr_show script :::::: branch date: 12 hours ago :::::: commit date: 9 weeks ago Please take the patch only if it's a positive warning. Thanks! lg-laptop.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --- a/drivers/platform/x86/lg-laptop.c +++ b/drivers/platform/x86/lg-laptop.c @@ -319,7 +319,7 @@ static ssize_t fan_mode_show(struct devi status =3D r->integer.value & 0x01; kfree(r); = - return snprintf(buffer, PAGE_SIZE, "%d\n", status); + return scnprintf(buffer, PAGE_SIZE, "%d\n", status); } = static ssize_t usb_charge_store(struct device *dev, @@ -361,7 +361,7 @@ static ssize_t usb_charge_show(struct de = kfree(r); = - return snprintf(buffer, PAGE_SIZE, "%d\n", status); + return scnprintf(buffer, PAGE_SIZE, "%d\n", status); } = static ssize_t reader_mode_store(struct device *dev, @@ -403,7 +403,7 @@ static ssize_t reader_mode_show(struct d = kfree(r); = - return snprintf(buffer, PAGE_SIZE, "%d\n", status); + return scnprintf(buffer, PAGE_SIZE, "%d\n", status); } = static ssize_t fn_lock_store(struct device *dev, @@ -444,7 +444,7 @@ static ssize_t fn_lock_show(struct devic status =3D !!r->buffer.pointer[0]; kfree(r); = - return snprintf(buffer, PAGE_SIZE, "%d\n", status); + return scnprintf(buffer, PAGE_SIZE, "%d\n", status); } = static ssize_t battery_care_limit_store(struct device *dev, @@ -493,7 +493,7 @@ static ssize_t battery_care_limit_show(s if (status !=3D 80 && status !=3D 100) status =3D 0; = - return snprintf(buffer, PAGE_SIZE, "%d\n", status); + return scnprintf(buffer, PAGE_SIZE, "%d\n", status); } = static DEVICE_ATTR_RW(fan_mode); --===============4826937329689361316==--