Re: [PATCH 0/4] xen/arm: Unbreak ACPI

From: Elliott Mitchell <ehem+xen@m5p.com>
To: Julien Grall <julien@xen.org>
Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>,
	xen-devel@lists.xenproject.org,
	Alex Benn??e <alex.bennee@linaro.org>,
	bertrand.marquis@arm.com, andre.przywara@arm.com,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>, Roger Pau Monn?? <roger.pau@citrix.com>
Subject: Re: [PATCH 0/4] xen/arm: Unbreak ACPI
Date: Fri, 9 Oct 2020 15:36:52 -0700	[thread overview]
Message-ID: <20201009223652.GC65219@mattapan.m5p.com> (raw)
In-Reply-To: <55a4ac3d-dc6f-f2f6-1a98-62d1c555d26e@xen.org>

On Fri, Oct 09, 2020 at 07:15:20PM +0100, Julien Grall wrote:
> On 09/10/2020 15:22, Elliott Mitchell wrote:
> > Finding all the command-line console settings can be a challenge.  I had
> > thought it was supposed to be "console=hvc0 earlycon=hvc0".
> > 
> > With that though I finally have some output which claims to come from the
> > Linux kernel (yay! finally hit this point!).  As we were both guessing,
> > very early kernel panic:
> > 
> > [    0.000000] efi: Getting EFI parameters from FDT:
> > [    0.000000] efi: Can't find 'System Table' in device tree!
> 
> Thank you for sending part of the log. Looking at Linux 5.6 code, the 
> error message is printed by efi_get_fdt_params() (see 
> drivers/firmware/efi.c) when one of the property is missing.
> 
> 'System Table' suggests that Linux wasn't enable to find 
> "linux,uefi-system-table" or "xen,uefi-system-table".
> 
> Xen will only create later. Would it be possible to add some code in 
> __find_uefi_params() to confirm which property Linux thinks is missing?

Trying to rebuild a configuration long after the prior build can be
entertaining.  Finally identified one patch appears to be for 4.19, but
breaks 5.x.  With that and an appropriate adjustment:

[    0.000000] efi: __find_uefi_params(): Missing "linux,uefi-system-table"
[    0.000000] efi: __find_uefi_params(): Missing "linux,uefi-system-table"

Good news is I had been meaning to try a later kernel for a while and
thus tried building a 5.8 kernel.  Once built, the 5.8 kernel booted
successfully.  As such the next issue is the driver for the graphics chip
doesn't function under Xen as of the 5.8 kernel and Xen 4.14.

I can now state I've gotten success with a combination of Julien Grall's
patches and Masami Hiramatsu.  Certainly qualifies for:

Tested-by: Elliott Mitchell <ehem+xen@m5p.com>

For all 5 patches.

-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg@m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445