On Tue, Oct 13, 2020 at 01:46:11PM -0400, Eduardo Habkost wrote: > On Sun, Oct 11, 2020 at 11:18:59PM -0400, Cleber Rosa wrote: > > On Sat, Oct 10, 2020 at 09:54:16AM +0200, Philippe Mathieu-Daudé wrote: > > > On 10/9/20 10:29 PM, Eduardo Habkost wrote: > > > > Add a simple test case that will run QEMU directly (without QMP) > > > > just to check for crashes when using `-object`. > > > > > > > > Signed-off-by: Eduardo Habkost > > > > --- > > > > Changes v1 -> v2: > > > > * "Running command:" log message instead of "Command:" (Cleber) > > > > * Use universal_newlines=True instead of encoding='utf-8' (Cleber) > > > > * Rename devices() to get_devices() (Cleber) > > > > * Use @avocado.fail_on(subprocess.CalledProcessError) (Cleber) > > > > * Reword test_crash() docstring (Cleber) > > > > * Reorder imports > > > > > > Assuming: > > > Based-on: <20201008202713.1416823-1-ehabkost@redhat.com> > > > > > > I get: > > > > > > (1/2) tests/acceptance/object_option.py:ObjectOption.test_help: > > > qemu-system-avr: No machine specified, and there is no default > > > Use -machine help to list supported machines > > > FAIL: CalledProcessError(1, ['./qemu-system-avr', '-object', 'help']) (0.19 > > > s) > > > (2/2) tests/acceptance/object_option.py:ObjectOption.test_crash: > > > qemu-system-avr: No machine specified, and there is no default > > > Use -machine help to list supported machines > > > FAIL: CalledProcessError(1, ['./qemu-system-avr', '-object', 'help']) (0.18 > > > s) > > > > > > > Did you influence (test parameter?) the QEMU binary to be used? > > I'm assuming this was triggered by "make check-acceptance". I The output shows test 1/2 and 2/2, so I don't think it was triggered by "make check-acceptance". > will change the test case to use '-machine none', which should > work on all architectures. > +1, sounds good! - Cleber. > -- > Eduardo