All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>,
	Chris Wilson <chris@chris-wilson.co.uk>
Subject: [igt-dev] [PATCH i-g-t v3 03/23] lib/igt_core: Track child process pid and tid
Date: Fri, 23 Oct 2020 14:41:52 +0200	[thread overview]
Message-ID: <20201023124212.26428-4-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20201023124212.26428-1-zbigniew.kempczynski@intel.com>

Introduce variables which can decrease number of getpid()/gettid()
calls, especially for allocator which must be aware of method
acquiring addresses.

When child is spawned using igt_fork() we can control its initialization
and prepare child_pid implicitly. Tracking child_tid requires our
intervention in the code and do something like this:

if (child_tid == -1)
	child_tid = gettid()

Variable was created for using in TLS so each thread is created
with variable set to -1. This will give each thread it's own "copy"
and there's no risk to use other thread tid. For each forked child
we reassign -1 to child_tid to avoid using already set variable.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Petri Latvala <petri.latvala@intel.com>
---
 lib/igt_core.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/lib/igt_core.c b/lib/igt_core.c
index b358173f..1f725d00 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -58,6 +58,7 @@
 #include <glib.h>
 
 #include "drmtest.h"
+#include "intel_allocator.h"
 #include "intel_chipset.h"
 #include "intel_io.h"
 #include "igt_debugfs.h"
@@ -306,6 +307,10 @@ int num_test_children;
 int test_children_sz;
 bool test_child;
 
+/* For allocator purposes */
+pid_t child_pid  = -1;
+__thread pid_t child_tid  = -1;
+
 enum {
 	/*
 	 * Let the first values be used by individual tests so options don't
@@ -2303,6 +2308,8 @@ bool __igt_fork(void)
 	case 0:
 		test_child = true;
 		pthread_mutex_init(&print_mutex, NULL);
+		child_pid = getpid();
+		child_tid = -1;
 		exit_handler_count = 0;
 		reset_helper_process_list();
 		oom_adjust_for_doom();
-- 
2.26.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2020-10-23 12:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-23 12:41 [igt-dev] [PATCH i-g-t v3 00/23] Introduce IGT allocator Zbigniew Kempczyński
2020-10-23 12:41 ` [igt-dev] [PATCH i-g-t v3 01/23] lib/igt_list: igt_hlist implementation Zbigniew Kempczyński
2020-10-23 12:41 ` [igt-dev] [PATCH i-g-t v3 02/23] lib/igt_map: Introduce igt_map Zbigniew Kempczyński
2020-10-23 12:41 ` Zbigniew Kempczyński [this message]
2020-10-23 12:41 ` [igt-dev] [PATCH i-g-t v3 04/23] lib/intel_allocator_simple: Add simple allocator Zbigniew Kempczyński
2020-10-23 12:41 ` [igt-dev] [PATCH i-g-t v3 05/23] lib/intel_allocator_random: Add random allocator Zbigniew Kempczyński
2020-10-23 12:41 ` [igt-dev] [PATCH i-g-t v3 06/23] lib/intel_allocator: Add intel_allocator core Zbigniew Kempczyński
2020-10-23 12:41 ` [igt-dev] [PATCH i-g-t v3 07/23] lib/intel_allocator: Try to stop smoothly instead of deinit Zbigniew Kempczyński
2020-10-23 12:41 ` [igt-dev] [PATCH i-g-t v3 08/23] lib/intel_allocator_msgchannel: Scale to 4k of parallel clients Zbigniew Kempczyński
2020-10-23 12:41 ` [igt-dev] [PATCH i-g-t v3 09/23] lib/intel_bufops: Removes handle from allocator, change size Zbigniew Kempczyński
2020-10-23 12:41 ` [igt-dev] [PATCH i-g-t v3 10/23] lib/intel_bufops: Add init with handle and size function Zbigniew Kempczyński
2020-10-23 12:42 ` [igt-dev] [PATCH i-g-t v3 11/23] lib/intel_batchbuffer: Integrate intel_bb with allocator Zbigniew Kempczyński
2020-10-23 12:42 ` [igt-dev] [PATCH i-g-t v3 12/23] lib/intel_batchbuffer: Add tracking intel_buf to intel_bb Zbigniew Kempczyński
2020-10-23 12:42 ` [igt-dev] [PATCH i-g-t v3 13/23] lib/intel_aux_pgtable: Get addresses for aux table from an allocator Zbigniew Kempczyński
2020-10-23 12:42 ` [igt-dev] [PATCH i-g-t v3 14/23] lib/igt_fb: Initialize intel_buf with same size as fb Zbigniew Kempczyński
2020-10-23 12:42 ` [igt-dev] [PATCH i-g-t v3 15/23] tests/api_intel_bb: Modify test to verify intel_bb with allocator Zbigniew Kempczyński
2020-10-23 12:42 ` [igt-dev] [PATCH i-g-t v3 16/23] tests/api_intel_bb: Add compressed->compressed copy Zbigniew Kempczyński
2020-10-23 12:42 ` [igt-dev] [PATCH i-g-t v3 17/23] tests/api_intel_allocator: Simple allocator test suite Zbigniew Kempczyński
2020-10-23 12:42 ` [igt-dev] [PATCH i-g-t v3 18/23] tests/gem|kms: Remove intel_bb from fixture Zbigniew Kempczyński
2020-10-23 12:42 ` [igt-dev] [PATCH i-g-t v3 19/23] tests/gem_mmap_offset: Use intel_buf wrapper code instead direct Zbigniew Kempczyński
2020-10-23 12:42 ` [igt-dev] [PATCH i-g-t v3 20/23] tests/gem_ppgtt: Adopt test to use intel_bb with allocator Zbigniew Kempczyński
2020-10-23 12:42 ` [igt-dev] [PATCH i-g-t v3 21/23] tests/gem_render_copy_redux: Adopt to use with intel_bb and allocator Zbigniew Kempczyński
2020-10-23 12:42 ` [igt-dev] [PATCH i-g-t v3 22/23] tests/perf.c: Remove buffer from batch Zbigniew Kempczyński
2020-10-23 12:42 ` [igt-dev] [PATCH i-g-t v3 23/23] tests/gem_linear_blits: Use intel allocator Zbigniew Kempczyński
2020-10-23 13:10 ` [igt-dev] ✓ Fi.CI.BAT: success for Introduce IGT allocator (rev3) Patchwork
2020-10-23 15:29 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-10-26  5:30   ` Zbigniew Kempczyński
2020-10-26  5:43 ` [igt-dev] ✓ Fi.CI.BAT: success for Introduce IGT allocator (rev4) Patchwork
2020-10-26  6:44 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-10-26  8:09   ` Zbigniew Kempczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201023124212.26428-4-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.