All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fino Meng <fino.meng@linux.intel.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: xenomai@xenomai.org
Subject: Re: build scripts for the WIP xenomai porting to kernel 5.4
Date: Mon, 26 Oct 2020 16:26:57 +0800	[thread overview]
Message-ID: <20201026082656.GC17437@linux.intel.com> (raw)
In-Reply-To: <1b80d6cf-cf5a-dbb7-4e82-1958cd82b212@siemens.com>

On Mon, Oct 26, 2020 at 09:20:20AM +0100, Jan Kiszka wrote:
> On 26.10.20 09:12, Fino Meng wrote:
> > On Mon, Oct 26, 2020 at 08:35:10AM +0100, Jan Kiszka wrote:
> >> On 23.10.20 11:04, Fino Meng wrote:
> >>> be aware of RTNET and RTIPC part still have compile error, I didn't
> >>> enable them in .config yet. hope can fix them next week.
> >>
> >> Do you have patches for RTnet and Analogy already? RTIPC is fixed in
> >> next. I'm currently trying to get CI fully running.
> >>
> >> Jan
> > 
> > this morning, I didn't meet error when compile RTnet as module, strange.
> 
> Just fixing that, linux/pci-aspm.h
> 
> > for Analogy I didn't try yet, will try it today.
> > 
> > Happy to know RTIPC is done, I was checking it's code and make it pass compile like this:
> > 
> > diff --git a/kernel/drivers/ipc/bufp.c b/kernel/drivers/ipc/bufp.c
> > index 45c917eb0..024f8f2f1 100644
> > --- a/kernel/drivers/ipc/bufp.c
> > +++ b/kernel/drivers/ipc/bufp.c
> > @@ -830,14 +830,16 @@ static int __bufp_setsockopt(struct bufp_socket *sk,
> >         if (sopt.level == SOL_SOCKET) {
> >                 switch (sopt.optname) {
> > 
> > -               case SO_RCVTIMEO:
> > +               case SO_RCVTIMEO_OLD:
> > +               case SO_RCVTIMEO_NEW:
> 
> *_NEW looks incorrect at this stage, see next.
> 
> >                         ret = rtipc_get_timeval(fd, &tv, sopt.optval, sopt.optlen);
> >                         if (ret)
> >                                 return ret;
> >                         sk->rx_timeout = rtipc_timeval_to_ns(&tv);
> >                         break;
> > 
> > -               case SO_SNDTIMEO:
> > +               case SO_SNDTIMEO_OLD:
> > +               case SO_SNDTIMEO_NEW:
> >                         ret = rtipc_get_timeval(fd, &tv, sopt.optval, sopt.optlen);
> >                         if (ret)
> >                                 return ret;
> > @@ -922,14 +924,16 @@ static int __bufp_getsockopt(struct bufp_socket *sk,
> >         if (sopt.level == SOL_SOCKET) {
> >                 switch (sopt.optname) {
> > 
> > -               case SO_RCVTIMEO:
> > +               case SO_RCVTIMEO_OLD:
> > +               case SO_RCVTIMEO_NEW:
> >                         rtipc_ns_to_timeval(&tv, sk->rx_timeout);
> >                         ret = rtipc_put_timeval(fd, sopt.optval, &tv, len);
> >                         if (ret)
> >                                 return ret;
> >                         break;
> > 
> > -               case SO_SNDTIMEO:
> > +               case SO_SNDTIMEO_OLD:
> > +               case SO_SNDTIMEO_NEW:
> >                         rtipc_ns_to_timeval(&tv, sk->tx_timeout);
> >                         ret = rtipc_put_timeval(fd, sopt.optval, &tv, len);
> >                         if (ret)
> > diff --git a/kernel/drivers/ipc/iddp.c b/kernel/drivers/ipc/iddp.c
> > index 2a80eba65..c926b32ac 100644
> > --- a/kernel/drivers/ipc/iddp.c
> > +++ b/kernel/drivers/ipc/iddp.c
> > @@ -712,14 +712,16 @@ static int __iddp_setsockopt(struct iddp_socket *sk,
> >         if (sopt.level == SOL_SOCKET) {
> >                 switch (sopt.optname) {
> > 
> > -               case SO_RCVTIMEO:
> > +               case SO_RCVTIMEO_OLD:
> > +               case SO_RCVTIMEO_NEW:
> >                         ret = rtipc_get_timeval(fd, &tv, sopt.optval, sopt.optlen);
> > 
> > 
> > I also tested hackbench:
> > 
> > while true ; do sudo taskset -c 1 hackbench -s 512 -l 200 -g 20 -f 50 -P ; done
> > 
> > it output errors, but the board is still alive. 
> > 
> 
> Will check. Was that with my FPU fixes in place already?
> 
> Jan

yes, without the FPU fixes, the board will hang after trigger
hackbench.

BR fino

> 
> -- 
> Siemens AG, T RDA IOT
> Corporate Competence Center Embedded Linux


  parent reply	other threads:[~2020-10-26  8:26 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 13:25 build scripts for the WIP xenomai porting to kernel 5.4 Fino Meng
2020-10-15 14:20 ` Jan Kiszka
2020-10-15 14:30   ` Jan Kiszka
2020-10-16  3:36   ` Fino Meng
2020-10-18 21:41     ` Jan Kiszka
2020-10-21  6:36       ` Jan Kiszka
2020-10-21 11:43         ` Fino Meng
2020-10-22  6:27           ` Jan Kiszka
2020-10-22  7:26             ` Jan Kiszka
2020-10-22  7:38               ` Fino Meng
2020-10-22 11:49               ` Fino Meng
2020-10-22 12:15                 ` Jan Kiszka
2020-10-22 13:25                   ` Fino Meng
2020-10-22 15:22                     ` Jan Kiszka
2020-10-22 16:02                       ` Jan Kiszka
2020-10-23  9:04                       ` Fino Meng
2020-10-23 12:29                         ` Jan Kiszka
2020-10-24  3:59                           ` Fino Meng
2020-10-26  7:35                         ` Jan Kiszka
2020-10-26  8:12                           ` Fino Meng
2020-10-26  8:20                             ` Jan Kiszka
2020-10-26  8:25                               ` Jan Kiszka
2020-10-26  8:26                               ` Fino Meng [this message]
2020-10-26  8:38                                 ` Jan Kiszka
2020-10-26  9:15                                   ` Fino Meng
2020-10-26  9:20                                     ` Jan Kiszka
2020-10-27  5:23                                       ` Fino Meng
2020-10-27  6:01                                         ` Jan Kiszka
2020-10-27  6:44                                           ` Fino Meng
2020-10-27  6:50                                             ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201026082656.GC17437@linux.intel.com \
    --to=fino.meng@linux.intel.com \
    --cc=jan.kiszka@siemens.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.