From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68D63C4363A for ; Tue, 27 Oct 2020 09:05:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0968D206DC for ; Tue, 27 Oct 2020 09:05:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603789558; bh=7+yOpeg6nfOmILq4NF53izHXivqVk2vMFwmPu+UyHoU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=CWYt0rw6uLox0ZhULfZ1PvdQCnSCNRvhQzoiiOpVacmGk49ttbCWb/L1lKobxTC3a WC/ABcP0WHSCnHBnpm0VIUXxYvQcs0SL2AMbjEuYZGhgtNzJH61ehasJRpwbohAP/Y YoGWzg+Y9aIQDigzy030Ti+xUyj+hTq3z7AO0drM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408437AbgJ0JF5 (ORCPT ); Tue, 27 Oct 2020 05:05:57 -0400 Received: from mail-ej1-f68.google.com ([209.85.218.68]:39612 "EHLO mail-ej1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2408402AbgJ0JF5 (ORCPT ); Tue, 27 Oct 2020 05:05:57 -0400 Received: by mail-ej1-f68.google.com with SMTP id bn26so1117382ejb.6; Tue, 27 Oct 2020 02:05:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FSlOTo+zGWamBX2WAxzQkPjeyrJMzym+nDUb6jRYhTI=; b=ReGQNk7KoODhfmu8y7uzrwlYNO2tUuavVfYHiAiFcSJAE1erX40yYg+ogZeWNOWkzt mzNMu0ELXDnP4nR/8t/b7BZxDRaa6SNLtqW2TwRZOBrxTgCi3SsRamZildSqg4GW3R0u FJugDTWRRgQ/Xne8q/exhJ+iBT6X5gNPIGGRq45su+VKPXg5BxAHHLjV5pRWMpNBDO1z OJx2x6F+sjLb0ksJ6dDGOcBVnDG+7CnAzxnHDFKFPQ1OtXbsY31c+I2opClwL/GUW9Cg 6ca7FP4z+NCfT7j/e7Qg8Ru8sZ9Eby4r1Ces01dbseXfY2kCq8Gfy7kcV5obRpPonLeN jfzg== X-Gm-Message-State: AOAM532ng5cJAnu0CqT960jT4cbWE8WlzHFHfJa++iwPDlHabbJSeEMU fidyzpTrh20M8osdOPnrumA= X-Google-Smtp-Source: ABdhPJwpB7zlslYYqry/Tn76sD9QhQfOP3c+c7xncdpzGfAK9wt/B+FS8uKYdnkUGHJeI6sHYSxQSg== X-Received: by 2002:a17:906:aed9:: with SMTP id me25mr1447133ejb.52.1603789555092; Tue, 27 Oct 2020 02:05:55 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id o11sm608711ejd.60.2020.10.27.02.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 02:05:53 -0700 (PDT) Date: Tue, 27 Oct 2020 10:05:50 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 09/52] dt-bindings: memory: tegra30: mc: Document new interconnect property Message-ID: <20201027090550.GI4244@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-10-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201025221735.3062-10-digetx@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Mon, Oct 26, 2020 at 01:16:52AM +0300, Dmitry Osipenko wrote: > Memory controller is interconnected with memory clients and with the > External Memory Controller. Document new interconnect property which > turns memory controller into interconnect provider. > > Acked-by: Rob Herring > Signed-off-by: Dmitry Osipenko > --- > .../bindings/memory-controllers/nvidia,tegra30-mc.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-mc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-mc.yaml > index 84fd57bcf0dc..5436e6d420bc 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-mc.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-mc.yaml > @@ -57,6 +57,9 @@ properties: > "#iommu-cells": > const: 1 > > + "#interconnect-cells": > + const: 1 > + > patternProperties: > "^emc-timings-[0-9]+$": > type: object > @@ -120,6 +123,7 @@ required: > - clock-names > - "#reset-cells" > - "#iommu-cells" > + - "#interconnect-cells" Rob, You were fine with adding a new required property which breaks all existing DTBs? Were these bindings marked as unstable? The patchset does not even say/scream that it breaks the ABI, so this might be quite a surprise for someone... Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B26C55179 for ; Tue, 27 Oct 2020 09:05:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB958206DC for ; Tue, 27 Oct 2020 09:05:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB958206DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0BD9B6EB35; Tue, 27 Oct 2020 09:05:58 +0000 (UTC) Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7AAB26EB35 for ; Tue, 27 Oct 2020 09:05:56 +0000 (UTC) Received: by mail-ej1-f66.google.com with SMTP id p9so1132418eji.4 for ; Tue, 27 Oct 2020 02:05:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FSlOTo+zGWamBX2WAxzQkPjeyrJMzym+nDUb6jRYhTI=; b=dtWktNoTBIVxsvZCIjQ47s4vZ0IyYFhXVxFIK9fhgP1dFfSTKevz1o5SmfsoCfZfGK qrSdUMOid0TRzBq39eGPjqxfIj5HQ8Io0Kj5u9rb8jF+nHG243fQ774WUGNHeEm2n+C7 etNWRg9SL0UBJwmPNgKS1afvBuJcqI9tIZdaTcgbOVLP1WzPxjEzF+Y/+zlO9Jzi6U8N IDSAW0TnH4uodGNqVm6GoBBDDJFMhzwMMj+7pE+FzgTpxkJYKdn7jkGVfSoRKW3A0wGn ODbauOxkpDX0B5j7erSyP2G8e7XtfFTin5QKUaV/LYXH6bLFiOgyJxg8o/WkBxhONC/i Zs9A== X-Gm-Message-State: AOAM531Vq5yUMvgmOdRSrQwL2GEcpp6fu7mvF24P3WiP/YVUYzt/cBAc s2uIc0qdRfWMceUL/ovIJbQ= X-Google-Smtp-Source: ABdhPJwpB7zlslYYqry/Tn76sD9QhQfOP3c+c7xncdpzGfAK9wt/B+FS8uKYdnkUGHJeI6sHYSxQSg== X-Received: by 2002:a17:906:aed9:: with SMTP id me25mr1447133ejb.52.1603789555092; Tue, 27 Oct 2020 02:05:55 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id o11sm608711ejd.60.2020.10.27.02.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 02:05:53 -0700 (PDT) Date: Tue, 27 Oct 2020 10:05:50 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Subject: Re: [PATCH v6 09/52] dt-bindings: memory: tegra30: mc: Document new interconnect property Message-ID: <20201027090550.GI4244@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-10-digetx@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201025221735.3062-10-digetx@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Georgi Djakov , devicetree@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Oct 26, 2020 at 01:16:52AM +0300, Dmitry Osipenko wrote: > Memory controller is interconnected with memory clients and with the > External Memory Controller. Document new interconnect property which > turns memory controller into interconnect provider. > > Acked-by: Rob Herring > Signed-off-by: Dmitry Osipenko > --- > .../bindings/memory-controllers/nvidia,tegra30-mc.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-mc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-mc.yaml > index 84fd57bcf0dc..5436e6d420bc 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-mc.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-mc.yaml > @@ -57,6 +57,9 @@ properties: > "#iommu-cells": > const: 1 > > + "#interconnect-cells": > + const: 1 > + > patternProperties: > "^emc-timings-[0-9]+$": > type: object > @@ -120,6 +123,7 @@ required: > - clock-names > - "#reset-cells" > - "#iommu-cells" > + - "#interconnect-cells" Rob, You were fine with adding a new required property which breaks all existing DTBs? Were these bindings marked as unstable? The patchset does not even say/scream that it breaks the ABI, so this might be quite a surprise for someone... Best regards, Krzysztof _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel