From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D75FEC55179 for ; Tue, 27 Oct 2020 09:15:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6929422265 for ; Tue, 27 Oct 2020 09:15:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603790125; bh=2R+UFOjPms/6PZAP2ltrA/50nPxa4yHJJwVvS33KC2U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=iagOulcHpVq2jXJyjh1qv8EizaMFIUe+kOyc6YDPFeGPOfq7+GQEPFG5MYOKguGZV UA5XoucEQZwAUuo/Lkj3hUoAQxOjrwf1SPkgqVO9ndL1DSgkoLsAl+lDK8ymxNvEMh W/8B9ZiqXly4VXMYViMVNWbDSgveGisol+aDrVJY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2509795AbgJ0JPW (ORCPT ); Tue, 27 Oct 2020 05:15:22 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:33721 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2509791AbgJ0JPW (ORCPT ); Tue, 27 Oct 2020 05:15:22 -0400 Received: by mail-ed1-f65.google.com with SMTP id w23so662362edl.0; Tue, 27 Oct 2020 02:15:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=g6bHoMhiwcmZw1/CSnlFqJcYBMkTv5s8A4syHXJYESk=; b=WKexmU/X4//LWeCWTSIYUeuu6z6zJBRA6UidchYkUAPVS/jG/hcLaQLIaZ5rhhyUeB qJ9b0yENnWnxhkqz1JpKEwMRZ/6F2prty7DjOAd/WxdU1TNhPycufbSec01Uo0UkbMSZ E3p8FLOwVunM5LifOGhuIbOChi1TFRUyZdOMZiIkFCh8KFVFKkIsNJPG+/Vba/uv3Bwh gxfahtaBE8/0ft4mpEhGqTCzHa54JX6BQwnOz5/frkKbVuP/dByTe6SfYrRUdcNouW+t 4k7/Y+0UO6zf5mNGJHkgjRj8QsUjvZG+9a8hrlJIy3S+nTU4RvDU9Znh6BHmtG2FFFEd kmNw== X-Gm-Message-State: AOAM530HrmhEsEcMivb0zLHEElXNGKDBJKtyIqlQAqcYahUk+wF7xtFK fG8e0dcmFpRvRUoNSlnCNQc= X-Google-Smtp-Source: ABdhPJxd6ufTfpcGWYE02ffhR1QhXCCQSQWXm5hhrDvcb+FyIyVie9373Y/Qw2lKZrkAXRmUqyj8Fg== X-Received: by 2002:aa7:de95:: with SMTP id j21mr1204973edv.199.1603790119475; Tue, 27 Oct 2020 02:15:19 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id t5sm546479edw.45.2020.10.27.02.15.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 02:15:18 -0700 (PDT) Date: Tue, 27 Oct 2020 10:15:16 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 22/52] ARM: tegra: Add interconnect properties to Tegra30 device-tree Message-ID: <20201027091516.GA10762@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-23-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201025221735.3062-23-digetx@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Mon, Oct 26, 2020 at 01:17:05AM +0300, Dmitry Osipenko wrote: > Add interconnect properties to the Memory Controller, External Memory > Controller and the Display Controller nodes in order to describe hardware > interconnection. > > Signed-off-by: Dmitry Osipenko > --- > arch/arm/boot/dts/tegra30.dtsi | 27 ++++++++++++++++++++++++++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi > index aeae8c092d41..2caf6cc6f4b1 100644 > --- a/arch/arm/boot/dts/tegra30.dtsi > +++ b/arch/arm/boot/dts/tegra30.dtsi > @@ -210,6 +210,17 @@ dc@54200000 { > > nvidia,head = <0>; > > + interconnects = <&mc TEGRA30_MC_DISPLAY0A &emc>, Does not compile. > + <&mc TEGRA30_MC_DISPLAY0B &emc>, > + <&mc TEGRA30_MC_DISPLAY1B &emc>, > + <&mc TEGRA30_MC_DISPLAY0C &emc>, > + <&mc TEGRA30_MC_DISPLAYHC &emc>; > + interconnect-names = "wina", > + "winb", > + "winb-vfilter", > + "winc", > + "cursor"; > + > rgb { > status = "disabled"; > }; > @@ -229,6 +240,17 @@ dc@54240000 { > > nvidia,head = <1>; > > + interconnects = <&mc TEGRA30_MC_DISPLAY0AB &emc>, > + <&mc TEGRA30_MC_DISPLAY0BB &emc>, > + <&mc TEGRA30_MC_DISPLAY1BB &emc>, > + <&mc TEGRA30_MC_DISPLAY0CB &emc>, > + <&mc TEGRA30_MC_DISPLAYHCB &emc>; > + interconnect-names = "wina", > + "winb", > + "winb-vfilter", > + "winc", > + "cursor"; > + > rgb { > status = "disabled"; > }; > @@ -748,15 +770,18 @@ mc: memory-controller@7000f000 { > > #iommu-cells = <1>; > #reset-cells = <1>; > + #interconnect-cells = <1>; > }; > > - memory-controller@7000f400 { > + emc: memory-controller@7000f400 { > compatible = "nvidia,tegra30-emc"; > reg = <0x7000f400 0x400>; > interrupts = ; > clocks = <&tegra_car TEGRA30_CLK_EMC>; > > nvidia,memory-controller = <&mc>; > + No need for blank line. Best regards, Krzysztof > + #interconnect-cells = <0>; > }; > > fuse@7000f800 { > -- > 2.27.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DB22C55179 for ; Tue, 27 Oct 2020 09:15:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7A3B20735 for ; Tue, 27 Oct 2020 09:15:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7A3B20735 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 46D8789020; Tue, 27 Oct 2020 09:15:22 +0000 (UTC) Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id DDD1D89020 for ; Tue, 27 Oct 2020 09:15:20 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id w25so657593edx.2 for ; Tue, 27 Oct 2020 02:15:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=g6bHoMhiwcmZw1/CSnlFqJcYBMkTv5s8A4syHXJYESk=; b=V5nxYpjJAwZgI1O2+PY7hAqJnB2R0qtKEXoUvN4/JI1idDWtaKfpR9U69LMxzmu85X xSNC9+8ZnQH00GfZ+xtYh3IlMY+FgTFswtOlf2BG5X0E6C8qPGgjZh2QI/Uj8HHRfoLX c+sujjf4Ro1g3AD+p1md4m5HOtPf1In8IQVtTXxeri1q5mBClGJn/zXWLZ7I2Lgx006d Zx/88/9NCxPeYZ4cREIlQ47alMd/1VuY7Lt2vDvLqdvRPV9WgKCB54A/iz3A8l+Xhp6r MFwhNarBnTwlVTc4WZ74is18nLvz+bPYRrHlVbr6L99e+HJoWOoqUdBYT6apbpa7byKb 4/pA== X-Gm-Message-State: AOAM530NCb37jK0dPuunUWREM8jFhR8hfwXWFjPxZ9YTN5bTpnvj4SCF ZQkqf/z9kQPPps6r3SjnUbM= X-Google-Smtp-Source: ABdhPJxd6ufTfpcGWYE02ffhR1QhXCCQSQWXm5hhrDvcb+FyIyVie9373Y/Qw2lKZrkAXRmUqyj8Fg== X-Received: by 2002:aa7:de95:: with SMTP id j21mr1204973edv.199.1603790119475; Tue, 27 Oct 2020 02:15:19 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id t5sm546479edw.45.2020.10.27.02.15.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 02:15:18 -0700 (PDT) Date: Tue, 27 Oct 2020 10:15:16 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Subject: Re: [PATCH v6 22/52] ARM: tegra: Add interconnect properties to Tegra30 device-tree Message-ID: <20201027091516.GA10762@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-23-digetx@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201025221735.3062-23-digetx@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Georgi Djakov , devicetree@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Oct 26, 2020 at 01:17:05AM +0300, Dmitry Osipenko wrote: > Add interconnect properties to the Memory Controller, External Memory > Controller and the Display Controller nodes in order to describe hardware > interconnection. > > Signed-off-by: Dmitry Osipenko > --- > arch/arm/boot/dts/tegra30.dtsi | 27 ++++++++++++++++++++++++++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi > index aeae8c092d41..2caf6cc6f4b1 100644 > --- a/arch/arm/boot/dts/tegra30.dtsi > +++ b/arch/arm/boot/dts/tegra30.dtsi > @@ -210,6 +210,17 @@ dc@54200000 { > > nvidia,head = <0>; > > + interconnects = <&mc TEGRA30_MC_DISPLAY0A &emc>, Does not compile. > + <&mc TEGRA30_MC_DISPLAY0B &emc>, > + <&mc TEGRA30_MC_DISPLAY1B &emc>, > + <&mc TEGRA30_MC_DISPLAY0C &emc>, > + <&mc TEGRA30_MC_DISPLAYHC &emc>; > + interconnect-names = "wina", > + "winb", > + "winb-vfilter", > + "winc", > + "cursor"; > + > rgb { > status = "disabled"; > }; > @@ -229,6 +240,17 @@ dc@54240000 { > > nvidia,head = <1>; > > + interconnects = <&mc TEGRA30_MC_DISPLAY0AB &emc>, > + <&mc TEGRA30_MC_DISPLAY0BB &emc>, > + <&mc TEGRA30_MC_DISPLAY1BB &emc>, > + <&mc TEGRA30_MC_DISPLAY0CB &emc>, > + <&mc TEGRA30_MC_DISPLAYHCB &emc>; > + interconnect-names = "wina", > + "winb", > + "winb-vfilter", > + "winc", > + "cursor"; > + > rgb { > status = "disabled"; > }; > @@ -748,15 +770,18 @@ mc: memory-controller@7000f000 { > > #iommu-cells = <1>; > #reset-cells = <1>; > + #interconnect-cells = <1>; > }; > > - memory-controller@7000f400 { > + emc: memory-controller@7000f400 { > compatible = "nvidia,tegra30-emc"; > reg = <0x7000f400 0x400>; > interrupts = ; > clocks = <&tegra_car TEGRA30_CLK_EMC>; > > nvidia,memory-controller = <&mc>; > + No need for blank line. Best regards, Krzysztof > + #interconnect-cells = <0>; > }; > > fuse@7000f800 { > -- > 2.27.0 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel