From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45E50C55179 for ; Tue, 27 Oct 2020 09:16:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8DC72225C for ; Tue, 27 Oct 2020 09:16:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603790174; bh=TIsBSZnnDXDbKQnyWZXy4mORSFd6b2TbwjhmPf+uy50=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=dMSdC7YzBWhPoX3n4kVALOJ9fYjpTRVeb4ZPF/X9XDV0STQrJ8Aly9iU2JaXHXlGW wv5n8bH8R1rsGEisp0RgD++9XBDI2LTS44OfluU87X9b1+RL2Z+KgZ7y4ycoKmuJzO niSNZQubjELsdW31mO++4RFytRXpxf7RGAPeF878= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2441369AbgJ0JQL (ORCPT ); Tue, 27 Oct 2020 05:16:11 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:37174 "EHLO mail-ej1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732757AbgJ0JQK (ORCPT ); Tue, 27 Oct 2020 05:16:10 -0400 Received: by mail-ej1-f65.google.com with SMTP id p9so1173115eji.4; Tue, 27 Oct 2020 02:16:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=te7LW0h+WnaT74s0iZ3ktDJyLfJVDjSeiQCufT7c3zs=; b=Olyh7l13uhhpf7vVrVSAP7vCeXNcYHXAVyqtgU3LTOa+tW/5gBrieWqrqu1Dks1L51 LV8U1d5H/1h8uHcKthAnrE9Glkejp++yoYoFkFLUhyo7odbZGibpwHlafA3UihujlI0c hnNgLFRHFEAor4XTl/G95QNH88G7RKaPuVUJCbKnlmhzQ50GLXcbIxCHTTjPbXCKbcCm HFVd0fQZvieDnSeAriYwq+Zs8yTLkXBxSUkcaZJNYoTtftpx93WzGJDsyoSmryUxlims VXchZXHTm/afcwJXmkYeKaDQL9XjUiowX7rDEm73hPSNp3nRx3jAAMDRUbETh31BEV+j zPfQ== X-Gm-Message-State: AOAM532q2J2UnLTF/Xd5oiJK23X8JW7OP76LftpwQ700ghLbH3Zy0stb x2Jgn+H/tB/KB5iP15O39Zg= X-Google-Smtp-Source: ABdhPJxqcWEhoSvTes/dDepoyWlh45x7YW1FAkIDTwxisa/25Ndd/8eT62q8W8j1JicJvbmdEsdQ+A== X-Received: by 2002:a17:906:eb18:: with SMTP id mb24mr1427378ejb.172.1603790167918; Tue, 27 Oct 2020 02:16:07 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id qt11sm632422ejb.16.2020.10.27.02.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 02:16:06 -0700 (PDT) Date: Tue, 27 Oct 2020 10:16:04 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 23/52] ARM: tegra: Add interconnect properties to Tegra124 device-tree Message-ID: <20201027091604.GB10762@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-24-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201025221735.3062-24-digetx@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Mon, Oct 26, 2020 at 01:17:06AM +0300, Dmitry Osipenko wrote: > Add interconnect properties to the Memory Controller, External Memory > Controller and the Display Controller nodes in order to describe hardware > interconnection. > > Signed-off-by: Dmitry Osipenko > --- > arch/arm/boot/dts/tegra124.dtsi | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi > index 64f488ba1e72..1801e30b1d3a 100644 > --- a/arch/arm/boot/dts/tegra124.dtsi > +++ b/arch/arm/boot/dts/tegra124.dtsi > @@ -113,6 +113,19 @@ dc@54200000 { > iommus = <&mc TEGRA_SWGROUP_DC>; > > nvidia,head = <0>; > + > + interconnects = <&mc TEGRA124_MC_DISPLAY0A &emc>, This does not compile. > + <&mc TEGRA124_MC_DISPLAY0B &emc>, > + <&mc TEGRA124_MC_DISPLAY0C &emc>, > + <&mc TEGRA124_MC_DISPLAYHC &emc>, > + <&mc TEGRA124_MC_DISPLAYD &emc>, > + <&mc TEGRA124_MC_DISPLAYT &emc>; > + interconnect-names = "wina", > + "winb", > + "winc", > + "cursor", > + "wind", > + "wint"; > }; > > dc@54240000 { > @@ -127,6 +140,15 @@ dc@54240000 { > iommus = <&mc TEGRA_SWGROUP_DCB>; > > nvidia,head = <1>; > + > + interconnects = <&mc TEGRA124_MC_DISPLAY0AB &emc>, > + <&mc TEGRA124_MC_DISPLAY0BB &emc>, > + <&mc TEGRA124_MC_DISPLAY0CB &emc>, > + <&mc TEGRA124_MC_DISPLAYHCB &emc>; > + interconnect-names = "wina", > + "winb", > + "winc", > + "cursor"; > }; > > hdmi: hdmi@54280000 { > @@ -628,6 +650,7 @@ mc: memory-controller@70019000 { > > #iommu-cells = <1>; > #reset-cells = <1>; > + #interconnect-cells = <1>; > }; > > emc: external-memory-controller@7001b000 { > @@ -637,6 +660,8 @@ emc: external-memory-controller@7001b000 { > clock-names = "emc"; > > nvidia,memory-controller = <&mc>; > + No need for blank line. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60DD3C388F9 for ; Tue, 27 Oct 2020 09:16:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E915D222D9 for ; Tue, 27 Oct 2020 09:16:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E915D222D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2C1816EB3D; Tue, 27 Oct 2020 09:16:11 +0000 (UTC) Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4B81E6EB3E for ; Tue, 27 Oct 2020 09:16:09 +0000 (UTC) Received: by mail-ej1-f67.google.com with SMTP id z5so1148937ejw.7 for ; Tue, 27 Oct 2020 02:16:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=te7LW0h+WnaT74s0iZ3ktDJyLfJVDjSeiQCufT7c3zs=; b=q6/pE60AKW0Qn0Pxz2vNzLPMVghi9TWGrnB1guG5zuYtVcjPuPQi2q9ZS8kLztzwko 6aETyUyqM2CViKh6tTEe0osyGsXii+ntx0sqWoHcLSVLh3TAmW6SL4KlpwwZxy3dQ9I1 DMzWMmiUTdsFLf6Tn4X8GLjvGOj15TRcXXdpwJGSftEn/8r8pNh7ePyxK3uHAJkM+1/Q CI5qKDpb58r05dfy8+pBk2Sr6h3g5bWMq2QZXvZGcLXfmkRcHhstLrrdc4f4ljshiVCD qVKKvr41eXMpryAkpjbXDRuUgxyFIRAIOD9MxgH6ZWPZcZ1rjCsIvbBgQgzonygi6uIV Q6Ig== X-Gm-Message-State: AOAM532uv3WBuo7Mq10gV1J0LHoMIHCvRzp0rpJDbD+QrWNJAMP3IGhi 1H4ht1Dyy39c5DpXxAfVTDw= X-Google-Smtp-Source: ABdhPJxqcWEhoSvTes/dDepoyWlh45x7YW1FAkIDTwxisa/25Ndd/8eT62q8W8j1JicJvbmdEsdQ+A== X-Received: by 2002:a17:906:eb18:: with SMTP id mb24mr1427378ejb.172.1603790167918; Tue, 27 Oct 2020 02:16:07 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id qt11sm632422ejb.16.2020.10.27.02.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 02:16:06 -0700 (PDT) Date: Tue, 27 Oct 2020 10:16:04 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Subject: Re: [PATCH v6 23/52] ARM: tegra: Add interconnect properties to Tegra124 device-tree Message-ID: <20201027091604.GB10762@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-24-digetx@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201025221735.3062-24-digetx@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Georgi Djakov , devicetree@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Oct 26, 2020 at 01:17:06AM +0300, Dmitry Osipenko wrote: > Add interconnect properties to the Memory Controller, External Memory > Controller and the Display Controller nodes in order to describe hardware > interconnection. > > Signed-off-by: Dmitry Osipenko > --- > arch/arm/boot/dts/tegra124.dtsi | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi > index 64f488ba1e72..1801e30b1d3a 100644 > --- a/arch/arm/boot/dts/tegra124.dtsi > +++ b/arch/arm/boot/dts/tegra124.dtsi > @@ -113,6 +113,19 @@ dc@54200000 { > iommus = <&mc TEGRA_SWGROUP_DC>; > > nvidia,head = <0>; > + > + interconnects = <&mc TEGRA124_MC_DISPLAY0A &emc>, This does not compile. > + <&mc TEGRA124_MC_DISPLAY0B &emc>, > + <&mc TEGRA124_MC_DISPLAY0C &emc>, > + <&mc TEGRA124_MC_DISPLAYHC &emc>, > + <&mc TEGRA124_MC_DISPLAYD &emc>, > + <&mc TEGRA124_MC_DISPLAYT &emc>; > + interconnect-names = "wina", > + "winb", > + "winc", > + "cursor", > + "wind", > + "wint"; > }; > > dc@54240000 { > @@ -127,6 +140,15 @@ dc@54240000 { > iommus = <&mc TEGRA_SWGROUP_DCB>; > > nvidia,head = <1>; > + > + interconnects = <&mc TEGRA124_MC_DISPLAY0AB &emc>, > + <&mc TEGRA124_MC_DISPLAY0BB &emc>, > + <&mc TEGRA124_MC_DISPLAY0CB &emc>, > + <&mc TEGRA124_MC_DISPLAYHCB &emc>; > + interconnect-names = "wina", > + "winb", > + "winc", > + "cursor"; > }; > > hdmi: hdmi@54280000 { > @@ -628,6 +650,7 @@ mc: memory-controller@70019000 { > > #iommu-cells = <1>; > #reset-cells = <1>; > + #interconnect-cells = <1>; > }; > > emc: external-memory-controller@7001b000 { > @@ -637,6 +660,8 @@ emc: external-memory-controller@7001b000 { > clock-names = "emc"; > > nvidia,memory-controller = <&mc>; > + No need for blank line. Best regards, Krzysztof _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel