From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56069C388F9 for ; Tue, 27 Oct 2020 10:27:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0846822281 for ; Tue, 27 Oct 2020 10:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603794439; bh=lYLO5Fe+o6OEdoG9129m1u7DZ86BqyXgk0VfVwNX4zs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=taN+sapSlqiWSXspEApr/gk3O7mCHxm+tLtkZYfQW0c22iicEqzcH8DZbbR4ky5Cm aXTfrKwwHo1C1j/B1PLXcFSA3kb8v7Y0OCNKDLei4dewBp/UjC/IljFdxFuYyGbFZq RzO+6rsJr9UUxtzHpszh2MaktHZVOgNr12EEqbXk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2898110AbgJ0K1O (ORCPT ); Tue, 27 Oct 2020 06:27:14 -0400 Received: from mail-ej1-f66.google.com ([209.85.218.66]:37915 "EHLO mail-ej1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2898088AbgJ0K1N (ORCPT ); Tue, 27 Oct 2020 06:27:13 -0400 Received: by mail-ej1-f66.google.com with SMTP id ce10so1452429ejc.5; Tue, 27 Oct 2020 03:27:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GA4OG+9SkS1dLHEsjc3Yoh5BLzXMpIvERF6qvUQNUY4=; b=YAAHhQsyCGuwceyID1pvebu0hBqjx9cqJdplZSmf1a54PjabEYmiPCoVqUHlk8AGjn LyGPJzXzIFZzLfz+UhQRRV4fsuqrIbx9cz+K+Ufn2MUNKoOTL7HWLeF+6z2gHi1rgqKX hBOSPVPPYkbgEU3OEzxEmzSEaJ0wh2FY68d9cWKFA9TrWu/AUtRP9GJ/TRgwgAbRvoCe SMr9VML3FaOil9SExdLJcAmCBljc9sG2Yjpgh3lhewmOuvzTEVbTSO1mhUMsVisONR5k 9nSZZ8GPQ5LbCvNG1HzGf+Eiz5/eJu8Nkd2kotLskUd2/ohOS8D88a+rR13MQIN7V3/d 9rmg== X-Gm-Message-State: AOAM530UDQHtRqCQAPkkZrjkT2p80p1K6KxEwA0Y0MrPe/6998JPN6YM 1A5HuqWUmVNszmrcbpijMuo= X-Google-Smtp-Source: ABdhPJwIxxoNhNQ2HMjdRGaVcneAee1se1I+5gUMBtanj7k+CUK0Tcdt0/GUf0w3biz06LUetV9mlw== X-Received: by 2002:a17:906:1e45:: with SMTP id i5mr1606932ejj.203.1603794431491; Tue, 27 Oct 2020 03:27:11 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id u8sm752822ejt.46.2020.10.27.03.27.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 03:27:10 -0700 (PDT) Date: Tue, 27 Oct 2020 11:27:07 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 41/52] memory: tegra124-emc: Use devm_platform_ioremap_resource() Message-ID: <20201027102707.GC17089@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-42-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201025221735.3062-42-digetx@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Mon, Oct 26, 2020 at 01:17:24AM +0300, Dmitry Osipenko wrote: > Use devm_platform_ioremap_resource() helper which makes code a bit > cleaner. Such cleanups (and few other in this patchset) should be at beginning of patchset or even as part of a separate one. I think there is not much stopping anyone from applying these... except that you put them in the middle of big dependency. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F104C4363A for ; Tue, 27 Oct 2020 10:27:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48C1C22282 for ; Tue, 27 Oct 2020 10:27:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48C1C22282 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 70DF96E1FB; Tue, 27 Oct 2020 10:27:14 +0000 (UTC) Received: from mail-ej1-f68.google.com (mail-ej1-f68.google.com [209.85.218.68]) by gabe.freedesktop.org (Postfix) with ESMTPS id CEF426E1FB for ; Tue, 27 Oct 2020 10:27:12 +0000 (UTC) Received: by mail-ej1-f68.google.com with SMTP id s15so1427628ejf.8 for ; Tue, 27 Oct 2020 03:27:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GA4OG+9SkS1dLHEsjc3Yoh5BLzXMpIvERF6qvUQNUY4=; b=SRlu2T9rnYdIQAByqdrqWno0XQLW5cE929q/Ocl+4pO/SRj6LtZVexX+VQrZlh0VyW ZzVy7Ilqg0YwxcMqddKyxRvvC96O4VtvbgFe6AMa59Fdl7miud1s45J8abYo9Enytofd LVGLjrx5uM6SzGBusENAapGX1DWWSyVbCITgcQlNj9oFLyiSgI6qOcIorYnDIMs1mZNo CBwrEkd8zFP5yng2jYu8HNgyfk8+1/Cg6x/rVhGHAK8h+5znG9w5OBlwMsZME5xBoQDO 9Pw7GKmCl/TQlWuapt2XSDBntCAa+pTtUPRnsqOF0VW+mM47ZKmD43/86x0PazEvq3Q+ /mdQ== X-Gm-Message-State: AOAM530yQT6EnjYZqK/d9dVgfuUkCpqT0eL1nLokLpfG/E0+IIs3jCSC 6QkpvHU2gQeAI4SFHhe1zas= X-Google-Smtp-Source: ABdhPJwIxxoNhNQ2HMjdRGaVcneAee1se1I+5gUMBtanj7k+CUK0Tcdt0/GUf0w3biz06LUetV9mlw== X-Received: by 2002:a17:906:1e45:: with SMTP id i5mr1606932ejj.203.1603794431491; Tue, 27 Oct 2020 03:27:11 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id u8sm752822ejt.46.2020.10.27.03.27.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 03:27:10 -0700 (PDT) Date: Tue, 27 Oct 2020 11:27:07 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Subject: Re: [PATCH v6 41/52] memory: tegra124-emc: Use devm_platform_ioremap_resource() Message-ID: <20201027102707.GC17089@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-42-digetx@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201025221735.3062-42-digetx@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Georgi Djakov , devicetree@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Oct 26, 2020 at 01:17:24AM +0300, Dmitry Osipenko wrote: > Use devm_platform_ioremap_resource() helper which makes code a bit > cleaner. Such cleanups (and few other in this patchset) should be at beginning of patchset or even as part of a separate one. I think there is not much stopping anyone from applying these... except that you put them in the middle of big dependency. Best regards, Krzysztof _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel