From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A295C4363A for ; Tue, 27 Oct 2020 19:34:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EC4321D42 for ; Tue, 27 Oct 2020 19:34:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603827269; bh=W7z9oO4f0DaOqLVArVQpsTTVXB9kh0QtP2XTIc9SBAo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=HuPlJ72aO7bIbWlY9isXJ2QIgjlvNf4AioWp3zh5ZSpe+k4WEBVaYx675GS/FayEz Vg9i5H7I2zmLL2LbZRwjyjngt/VExznsQ/3xFlq+Sf0IPfq28A5Ur3oFUUyN7Fb2Kc 337dQkNXKoy/OHbmibnrXXuCGs0tGTgxAM3Qk8mc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1830118AbgJ0TeZ convert rfc822-to-8bit (ORCPT ); Tue, 27 Oct 2020 15:34:25 -0400 Received: from mail-ej1-f68.google.com ([209.85.218.68]:39449 "EHLO mail-ej1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2504048AbgJ0TeX (ORCPT ); Tue, 27 Oct 2020 15:34:23 -0400 Received: by mail-ej1-f68.google.com with SMTP id bn26so3903666ejb.6; Tue, 27 Oct 2020 12:34:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=nHvaL4wmpHKYi5m3WZBTUj9Yr645AuMpS/Lwjl+uNoA=; b=Z8496DmppCAr4Yo5LIfJT/Vy0N1RbQYfNm8zh9+tEay4I32IFICZBcBfkPajRlp80L z3AOMg03b4SLuUVml97mEKrZNNePC7in84d05dq/djr9frMVaD7U1ESwKGsjL4EDpRcT 1hBl0iYHv3iQHpg9DBm52jtnFuYhNyOEbKLkb5GEy9AOPfqC2wkgVO/BhXWhV58wjlvB Fj1xorF5VPzlrZ9En9ZUAoITyPKnpKrS5ZFvcbKhgfyyXwg+08i6+bAtMaiTRpYjVvFE jhf5GceHUDMEWRxcl+Q4yLwqt+cZ2YRkHrSsBr8FBbzcnlCuuXA5rQLLkKPm1nwjEg1E hGLQ== X-Gm-Message-State: AOAM530tEIzzlEfNWIS2YdprBhJT4D+xVS8dbscNeE3qlzY5JfDuiICb t3hXpnswX5yCwJWUGwTrgOkUEO6E6r36FS4X X-Google-Smtp-Source: ABdhPJzSfsy7j2DNep0zqEKUKGZS6bAlWA30JvZmU2UWtQoUwNW/pB7XvrPTG1y6Gt14VNHQQIvGHQ== X-Received: by 2002:a17:906:b204:: with SMTP id p4mr4185530ejz.214.1603827260969; Tue, 27 Oct 2020 12:34:20 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id r24sm1487476eds.67.2020.10.27.12.34.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 12:34:19 -0700 (PDT) Date: Tue, 27 Oct 2020 20:34:17 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 05/52] dt-bindings: memory: tegra20: mc: Document new interconnect property Message-ID: <20201027193417.GB140636@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-6-digetx@gmail.com> <20201027085548.GE4244@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Tue, Oct 27, 2020 at 10:17:48PM +0300, Dmitry Osipenko wrote: > 27.10.2020 11:55, Krzysztof Kozlowski пишет: > > On Mon, Oct 26, 2020 at 01:16:48AM +0300, Dmitry Osipenko wrote: > >> Memory controller is interconnected with memory clients and with the > >> External Memory Controller. Document new interconnect property which > >> turns memory controller into interconnect provider. > >> > >> Acked-by: Rob Herring > >> Signed-off-by: Dmitry Osipenko > >> --- > >> .../bindings/memory-controllers/nvidia,tegra20-mc.txt | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-mc.txt b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-mc.txt > >> index e55328237df4..739b7c6f2e26 100644 > >> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-mc.txt > >> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-mc.txt > >> @@ -16,6 +16,8 @@ Required properties: > >> IOMMU specifier needed to encode an address. GART supports only a single > >> address space that is shared by all devices, therefore no additional > >> information needed for the address encoding. > >> +- #interconnect-cells : Should be 1. This cell represents memory client. > >> + The assignments may be found in header file . > > > > This is a list of required properties so you break the ABI. All existing > > DTBs will be affected. > > This is optional property for the older DTBs, but for newer DTs it's > mandatory. We do not consider here "older" or "newer" DTBs, but existing ones in the world using this binding. If it was optional so far, it cannot be made mandatory without changing the ABI. Which is an ABI break. > IIUC, it should be defined as a required property in the > binding. > > Please see tegra_mc_interconnect_setup() in "memory: tegra-mc: Add > interconnect framework", which check presence of the ICC DT property. The implementation indeed does not enforce it (except adding error msg, about which I commented). Therefore it should be an optional property. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B474C4363A for ; Tue, 27 Oct 2020 19:34:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B3C821D42 for ; Tue, 27 Oct 2020 19:34:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B3C821D42 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F8A089870; Tue, 27 Oct 2020 19:34:23 +0000 (UTC) Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6859C89870 for ; Tue, 27 Oct 2020 19:34:22 +0000 (UTC) Received: by mail-ej1-f66.google.com with SMTP id p9so3920788eji.4 for ; Tue, 27 Oct 2020 12:34:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=nHvaL4wmpHKYi5m3WZBTUj9Yr645AuMpS/Lwjl+uNoA=; b=IhG2BKFAyvrqAhFypgGh8vWasA+qO1fv/nufuMusUNc9a+4KaWnslbiMMI8CXzUbcn td93GoPlbz8ZsHY2RH+awKjr9B5Wxi9ySH26aBe8QV1Tq38JHQSi1B7gB0LEvgdrf3Dv 8efwDDzxGUpNJngyLurQqXnQ+a9gc5ZGLnL9cSvBcsdhuTcKY81b3QoTPo9eZJutbMdT pm5a3VPkmVpO6BcmflirsrhABzilIZk4iXF7b6ic4Tw5ubIsVWm5d7YhPIZj9ELH67h8 jsLg1mLlyUZ7LxgB6bwRHEnZFefytJSBJzTS5wefjgN1M+FFNEKQ7zOGl0sqynaa0M3T ZzRQ== X-Gm-Message-State: AOAM5313BOTZLPDG2Bhk6/FcNrkxQWTYgzy2V4NbQhWHGvYcGwHF9Pa0 KF3Q95QQAtcmpxDF0dIINKI= X-Google-Smtp-Source: ABdhPJzSfsy7j2DNep0zqEKUKGZS6bAlWA30JvZmU2UWtQoUwNW/pB7XvrPTG1y6Gt14VNHQQIvGHQ== X-Received: by 2002:a17:906:b204:: with SMTP id p4mr4185530ejz.214.1603827260969; Tue, 27 Oct 2020 12:34:20 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id r24sm1487476eds.67.2020.10.27.12.34.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 12:34:19 -0700 (PDT) Date: Tue, 27 Oct 2020 20:34:17 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Subject: Re: [PATCH v6 05/52] dt-bindings: memory: tegra20: mc: Document new interconnect property Message-ID: <20201027193417.GB140636@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-6-digetx@gmail.com> <20201027085548.GE4244@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Georgi Djakov , devicetree@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCBPY3QgMjcsIDIwMjAgYXQgMTA6MTc6NDhQTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtv IHdyb3RlOgo+IDI3LjEwLjIwMjAgMTE6NTUsIEtyenlzenRvZiBLb3psb3dza2kg0L/QuNGI0LXR gjoKPiA+IE9uIE1vbiwgT2N0IDI2LCAyMDIwIGF0IDAxOjE2OjQ4QU0gKzAzMDAsIERtaXRyeSBP c2lwZW5rbyB3cm90ZToKPiA+PiBNZW1vcnkgY29udHJvbGxlciBpcyBpbnRlcmNvbm5lY3RlZCB3 aXRoIG1lbW9yeSBjbGllbnRzIGFuZCB3aXRoIHRoZQo+ID4+IEV4dGVybmFsIE1lbW9yeSBDb250 cm9sbGVyLiBEb2N1bWVudCBuZXcgaW50ZXJjb25uZWN0IHByb3BlcnR5IHdoaWNoCj4gPj4gdHVy bnMgbWVtb3J5IGNvbnRyb2xsZXIgaW50byBpbnRlcmNvbm5lY3QgcHJvdmlkZXIuCj4gPj4KPiA+ PiBBY2tlZC1ieTogUm9iIEhlcnJpbmcgPHJvYmhAa2VybmVsLm9yZz4KPiA+PiBTaWduZWQtb2Zm LWJ5OiBEbWl0cnkgT3NpcGVua28gPGRpZ2V0eEBnbWFpbC5jb20+Cj4gPj4gLS0tCj4gPj4gIC4u Li9iaW5kaW5ncy9tZW1vcnktY29udHJvbGxlcnMvbnZpZGlhLHRlZ3JhMjAtbWMudHh0ICAgICAg ICAgIHwgMyArKysKPiA+PiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQo+ID4+Cj4g Pj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZW1vcnkt Y29udHJvbGxlcnMvbnZpZGlhLHRlZ3JhMjAtbWMudHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL21lbW9yeS1jb250cm9sbGVycy9udmlkaWEsdGVncmEyMC1tYy50eHQKPiA+ PiBpbmRleCBlNTUzMjgyMzdkZjQuLjczOWI3YzZmMmUyNiAxMDA2NDQKPiA+PiAtLS0gYS9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWVtb3J5LWNvbnRyb2xsZXJzL252aWRpYSx0 ZWdyYTIwLW1jLnR4dAo+ID4+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy9tZW1vcnktY29udHJvbGxlcnMvbnZpZGlhLHRlZ3JhMjAtbWMudHh0Cj4gPj4gQEAgLTE2LDYg KzE2LDggQEAgUmVxdWlyZWQgcHJvcGVydGllczoKPiA+PiAgICBJT01NVSBzcGVjaWZpZXIgbmVl ZGVkIHRvIGVuY29kZSBhbiBhZGRyZXNzLiBHQVJUIHN1cHBvcnRzIG9ubHkgYSBzaW5nbGUKPiA+ PiAgICBhZGRyZXNzIHNwYWNlIHRoYXQgaXMgc2hhcmVkIGJ5IGFsbCBkZXZpY2VzLCB0aGVyZWZv cmUgbm8gYWRkaXRpb25hbAo+ID4+ICAgIGluZm9ybWF0aW9uIG5lZWRlZCBmb3IgdGhlIGFkZHJl c3MgZW5jb2RpbmcuCj4gPj4gKy0gI2ludGVyY29ubmVjdC1jZWxscyA6IFNob3VsZCBiZSAxLiBU aGlzIGNlbGwgcmVwcmVzZW50cyBtZW1vcnkgY2xpZW50Lgo+ID4+ICsgIFRoZSBhc3NpZ25tZW50 cyBtYXkgYmUgZm91bmQgaW4gaGVhZGVyIGZpbGUgPGR0LWJpbmRpbmdzL21lbW9yeS90ZWdyYTIw LW1jLmg+Lgo+ID4gCj4gPiBUaGlzIGlzIGEgbGlzdCBvZiByZXF1aXJlZCBwcm9wZXJ0aWVzIHNv IHlvdSBicmVhayB0aGUgQUJJLiBBbGwgZXhpc3RpbmcKPiA+IERUQnMgd2lsbCBiZSBhZmZlY3Rl ZC4KPiAKPiBUaGlzIGlzIG9wdGlvbmFsIHByb3BlcnR5IGZvciB0aGUgb2xkZXIgRFRCcywgYnV0 IGZvciBuZXdlciBEVHMgaXQncwo+IG1hbmRhdG9yeS4KCldlIGRvIG5vdCBjb25zaWRlciBoZXJl ICJvbGRlciIgb3IgIm5ld2VyIiBEVEJzLCBidXQgZXhpc3Rpbmcgb25lcyBpbgp0aGUgd29ybGQg dXNpbmcgdGhpcyBiaW5kaW5nLgoKSWYgaXQgd2FzIG9wdGlvbmFsIHNvIGZhciwgaXQgY2Fubm90 IGJlIG1hZGUgbWFuZGF0b3J5IHdpdGhvdXQgY2hhbmdpbmcKdGhlIEFCSS4gV2hpY2ggaXMgYW4g QUJJIGJyZWFrLgoKPiBJSVVDLCBpdCBzaG91bGQgYmUgZGVmaW5lZCBhcyBhIHJlcXVpcmVkIHBy b3BlcnR5IGluIHRoZQo+IGJpbmRpbmcuCj4gCj4gUGxlYXNlIHNlZSB0ZWdyYV9tY19pbnRlcmNv bm5lY3Rfc2V0dXAoKSBpbiAibWVtb3J5OiB0ZWdyYS1tYzogQWRkCj4gaW50ZXJjb25uZWN0IGZy YW1ld29yayIsIHdoaWNoIGNoZWNrIHByZXNlbmNlIG9mIHRoZSBJQ0MgRFQgcHJvcGVydHkuCgpU aGUgaW1wbGVtZW50YXRpb24gaW5kZWVkIGRvZXMgbm90IGVuZm9yY2UgaXQgKGV4Y2VwdCBhZGRp bmcgZXJyb3IgbXNnLAphYm91dCB3aGljaCBJIGNvbW1lbnRlZCkuIFRoZXJlZm9yZSBpdCBzaG91 bGQgYmUgYW4gb3B0aW9uYWwgcHJvcGVydHkuCgpCZXN0IHJlZ2FyZHMsCktyenlzenRvZgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==