All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Johan Hovold <johan@kernel.org>,
	linux-usb@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: [PATCH] USB: serial: cyberjack: fix write-URB completion race
Date: Wed, 4 Nov 2020 11:13:35 +0100	[thread overview]
Message-ID: <20201104101335.GR4085@localhost> (raw)
In-Reply-To: <20201028093827.GC1953863@kroah.com>

On Wed, Oct 28, 2020 at 10:38:27AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Oct 26, 2020 at 09:25:48AM +0100, Johan Hovold wrote:
> > The write-URB busy flag was being cleared before the completion handler
> > was done with the URB, something which could lead to corrupt transfers
> > due to a racing write request if the URB is resubmitted.
> > 
> > Fixes: 507ca9bc0476 ("[PATCH] USB: add ability for usb-serial drivers to determine if their write urb is currently being used.")
> > Cc: stable <stable@vger.kernel.org>     # 2.6.13
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> >  drivers/usb/serial/cyberjack.c | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thanks, applied for 5.10-rc.

Johan

      reply	other threads:[~2020-11-04 10:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26  8:25 [PATCH] USB: serial: cyberjack: fix write-URB completion race Johan Hovold
2020-10-28  9:38 ` Greg KH
2020-11-04 10:13   ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201104101335.GR4085@localhost \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.