From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8ADDC5519F for ; Fri, 20 Nov 2020 08:48:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5AB642224C for ; Fri, 20 Nov 2020 08:48:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="vQQkZSJ2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727312AbgKTIrx (ORCPT ); Fri, 20 Nov 2020 03:47:53 -0500 Received: from mx2.suse.de ([195.135.220.15]:37016 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727087AbgKTIrw (ORCPT ); Fri, 20 Nov 2020 03:47:52 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1605862071; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ne2Avj6pW7QhAkPMQhJ1kGPytq/nN9ye3Utj+34UF5o=; b=vQQkZSJ2ooVHAE/UeNSDrpa0kIxqFyhcazCo3f1cxOe0H8LHXtTCsb33uRGR7XYsDXvvaO ihl/3/UJk5/y2doTc5Q7iN2ftZl1BkFjT4Zka5X+8iaU3ulnImlMUHuhmp+RXkSRV7zpgT IHUEWLIQBPogg+skXx9tw+dgWF58WQ8= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6C970AD21; Fri, 20 Nov 2020 08:47:51 +0000 (UTC) Date: Fri, 20 Nov 2020 09:47:50 +0100 From: Michal Hocko To: Muchun Song Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Oscar Salvador , "Song Bao Hua (Barry Song)" , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Subject: Re: [External] Re: [PATCH v5 03/21] mm/hugetlb: Introduce a new config HUGETLB_PAGE_FREE_VMEMMAP Message-ID: <20201120084750.GK3200@dhcp22.suse.cz> References: <20201120064325.34492-1-songmuchun@bytedance.com> <20201120064325.34492-4-songmuchun@bytedance.com> <20201120074950.GB3200@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 20-11-20 16:35:16, Muchun Song wrote: [...] > > That being said, unless there are huge advantages to introduce a > > config option I would rather not add it because our config space is huge > > already and the more we add the more future code maintainance that will > > add. If you want the config just for dependency checks then fine by me. > > Yeah, it is only for dependency checks :) OK, I must have misread the definition to think that it requires user to enable explicitly. Anyway this feature cannot be really on by default due to overhead. So the command line option default has to be flipped. -- Michal Hocko SUSE Labs