From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 910B1C56202 for ; Fri, 20 Nov 2020 10:51:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4148C22226 for ; Fri, 20 Nov 2020 10:51:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727479AbgKTKuu (ORCPT ); Fri, 20 Nov 2020 05:50:50 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:37086 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726541AbgKTKuu (ORCPT ); Fri, 20 Nov 2020 05:50:50 -0500 Received: by mail-ed1-f68.google.com with SMTP id cq7so9045635edb.4; Fri, 20 Nov 2020 02:50:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=It+D4YQDqmKcdjcjbq/4hP36Dz2LcB1jnl1T6CqVtu4=; b=gh16UBw8lEI6YYRrFggXiW693pnhtsnijta5KbRWtif4aE7iAgNfVDHaokIl8BpcCE PZe7fRnVJpHYy0iqIyvvXm64rP2laOyTJAcKS4XxkBg6lL67+cM+XE7fXNGoP/d9Twmr z+ulh1OsuAuISKvrZA2/lf60wT71KPRizS6229lH+mJ90Zei40v2nRu4/wVI+V5fHeOa 4ucT+P2s6LfL9eX+xYlRjLprzgxvLKKAZ5pVT3lKY0AatxQDtmeVYvNxQWLrVcXF0oan TIoaY+Yuixi6NE1WLvYJapSZb0Vn7tT3dMvuuxwivlJrW7u7hQNQXP5VpV9ONT2pob5j /mZw== X-Gm-Message-State: AOAM530mi/6zYlAP4za608qdmUfcS9DJ+gHtUT2tcdBr1lrVHkprUSkZ U/Hf5dwRaKY1C7KAZF3uCYw= X-Google-Smtp-Source: ABdhPJwOgFAFmzsp7sleJCO2BGhXf7meuzi4Aj0kJqXk//7z8BdixlPZGgWt+vnNhCvpXWAuFhnSeA== X-Received: by 2002:aa7:c512:: with SMTP id o18mr34240215edq.357.1605869447554; Fri, 20 Nov 2020 02:50:47 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id j6sm923497edy.87.2020.11.20.02.50.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2020 02:50:46 -0800 (PST) Date: Fri, 20 Nov 2020 11:50:45 +0100 From: Krzysztof Kozlowski To: Alice Guo Cc: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-imx@nxp.com, peng.fan@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Message-ID: <20201120105045.GA18581@kozik-lap> References: <20201120101112.31819-1-alice.guo@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201120101112.31819-1-alice.guo@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20, 2020 at 06:11:09PM +0800, Alice Guo wrote: > Add DT Binding doc for the Unique ID of i.MX 8M series. > > v2: remove the subject prefix "LF-2571-1" > v3: put it into Documentation/devicetree/bindings/arm/fsl.yaml > modify the description of nvmem-cells > use "make ARCH=arm64 dtbs_check" to test it and fix errors > v4: use allOf to limit new version DTS files for i.MX8M to include > "fsl,imx8mm/n/p/q-soc", nvmem-cells and nvmem-cells-names > > Signed-off-by: Alice Guo > --- > .../devicetree/bindings/arm/fsl.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index 67980dcef66d..d8048323a290 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -918,6 +918,57 @@ properties: > - fsl,s32v234-evb # S32V234-EVB2 Customer Evaluation Board > - const: fsl,s32v234 > > + soc: > + type: object > + properties: > + compatible: > + oneOf: > + - description: new version compatible for i.MX8M SoCs > + items: > + - enum: > + - fsl,imx8mm-soc > + - fsl,imx8mn-soc > + - fsl,imx8mp-soc > + - fsl,imx8mq-soc > + - const: simple-bus > + > + - description: old version compatible for i.MX8M SoCs > + items: > + - const: simple-bus > + > + nvmem-cells: > + maxItems: 1 > + description: Phandle to the SOC Unique ID provided by a nvmem node > + > + nvmem-cells-names: > + const: soc_unique_id > + > + allOf: Nothing changed here comparing to previous version. Still does not work. The allOf should not be part of soc node because the "if" below won't match. Instead, it should be against root node. Best regards, Krzysztof > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx8mm > + - fsl,imx8mn > + - fsl,imx8mp > + - fsl,imx8mq > + > + then: > + properties: > + compatible: > + items: > + - enum: > + - fsl,imx8mm-soc > + - fsl,imx8mn-soc > + - fsl,imx8mp-soc > + - fsl,imx8mq-soc > + - const: simple-bus > + > + required: > + - nvmem-cells > + - nvmem-cells-names > + > additionalProperties: true > > ... > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D23D7C63777 for ; Fri, 20 Nov 2020 10:51:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E1BE22255 for ; Fri, 20 Nov 2020 10:51:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gsHBu4VK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E1BE22255 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dcpdy3BOGcxwp/Wb+IGePjLYoe3sx6Ue+hA/kr8If68=; b=gsHBu4VKx3U7dWCk6KcGVEAcI BF5KCQlnNwkcTj38rhzpfWlSjOb8QWvLp1nBKgHWrxsRjjGVSpiB+QmDCSBZ/5WrjxinNRPqnX6TP wEmB1HUKdbpuzSac85WwGlITgumPMWETqOXpvpuPekoced94w5ZuhIAd5zj1rqdlqYp2zrEx4y8CV vhYuZgztAtMCrRCkgi5rBJX2Ag3DiqElyQRlqyaRB9nHa3L1KPQ30mH+2LWA89OfOXfhOWzUk8PDR GXfE7m72kiq09QlFQwvVv9QZDBeaBrZv9uy+hmjX1Y8l/b57Ce58ViD8nIYK3I7QpGx3VEJ9BcYPc beb+8/1Jg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg40A-0003lM-Mc; Fri, 20 Nov 2020 10:50:50 +0000 Received: from mail-ed1-f65.google.com ([209.85.208.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg408-0003l0-OV for linux-arm-kernel@lists.infradead.org; Fri, 20 Nov 2020 10:50:49 +0000 Received: by mail-ed1-f65.google.com with SMTP id v22so9028728edt.9 for ; Fri, 20 Nov 2020 02:50:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=It+D4YQDqmKcdjcjbq/4hP36Dz2LcB1jnl1T6CqVtu4=; b=NnOxXM9CTm7Mz9GqZXN20svNU9ktxs7+H8ppMgyw+CZWQAkBr/0C9D5UWaDkDZOvp4 gF7xT/HB27Z9F/1KLlAgjKj0OBzSIoBaliq5bCVY2qkBOGm+nJnY1DFfXVntBH9Hpo5s ZZ/ZXbRqjD/QYdgbSPcoTuPN5ttRduq8R7+0o16+ZuEitbja2iGPNdERAI7AdZ5ySFrx 425sf4TvcVFqBflFsgi4zQ7UdC6UiNke0F5/+895jgz06S8w5uXdvh4Xl8aAzs0hVIL1 57A7iLojLeiVvAxXzX29jSxMBtuSbpC53AHeCC0pUYhtKK6clQkKHCM/aUZmNE3izzzv +dNQ== X-Gm-Message-State: AOAM531Jw3f6OtIT8xNFZJHs10zwUs5A3JGcMaBcEKr/1H5XeNug1tyt sP+ltlsLis+7USU/8CTgwI4= X-Google-Smtp-Source: ABdhPJwOgFAFmzsp7sleJCO2BGhXf7meuzi4Aj0kJqXk//7z8BdixlPZGgWt+vnNhCvpXWAuFhnSeA== X-Received: by 2002:aa7:c512:: with SMTP id o18mr34240215edq.357.1605869447554; Fri, 20 Nov 2020 02:50:47 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id j6sm923497edy.87.2020.11.20.02.50.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2020 02:50:46 -0800 (PST) Date: Fri, 20 Nov 2020 11:50:45 +0100 From: Krzysztof Kozlowski To: Alice Guo Subject: Re: [PATCH v4 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Message-ID: <20201120105045.GA18581@kozik-lap> References: <20201120101112.31819-1-alice.guo@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201120101112.31819-1-alice.guo@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_055048_832296_BAD4F1BC X-CRM114-Status: GOOD ( 20.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, peng.fan@nxp.com, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-imx@nxp.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 20, 2020 at 06:11:09PM +0800, Alice Guo wrote: > Add DT Binding doc for the Unique ID of i.MX 8M series. > > v2: remove the subject prefix "LF-2571-1" > v3: put it into Documentation/devicetree/bindings/arm/fsl.yaml > modify the description of nvmem-cells > use "make ARCH=arm64 dtbs_check" to test it and fix errors > v4: use allOf to limit new version DTS files for i.MX8M to include > "fsl,imx8mm/n/p/q-soc", nvmem-cells and nvmem-cells-names > > Signed-off-by: Alice Guo > --- > .../devicetree/bindings/arm/fsl.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index 67980dcef66d..d8048323a290 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -918,6 +918,57 @@ properties: > - fsl,s32v234-evb # S32V234-EVB2 Customer Evaluation Board > - const: fsl,s32v234 > > + soc: > + type: object > + properties: > + compatible: > + oneOf: > + - description: new version compatible for i.MX8M SoCs > + items: > + - enum: > + - fsl,imx8mm-soc > + - fsl,imx8mn-soc > + - fsl,imx8mp-soc > + - fsl,imx8mq-soc > + - const: simple-bus > + > + - description: old version compatible for i.MX8M SoCs > + items: > + - const: simple-bus > + > + nvmem-cells: > + maxItems: 1 > + description: Phandle to the SOC Unique ID provided by a nvmem node > + > + nvmem-cells-names: > + const: soc_unique_id > + > + allOf: Nothing changed here comparing to previous version. Still does not work. The allOf should not be part of soc node because the "if" below won't match. Instead, it should be against root node. Best regards, Krzysztof > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx8mm > + - fsl,imx8mn > + - fsl,imx8mp > + - fsl,imx8mq > + > + then: > + properties: > + compatible: > + items: > + - enum: > + - fsl,imx8mm-soc > + - fsl,imx8mn-soc > + - fsl,imx8mp-soc > + - fsl,imx8mq-soc > + - const: simple-bus > + > + required: > + - nvmem-cells > + - nvmem-cells-names > + > additionalProperties: true > > ... > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel