From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DD1FC2D0E4 for ; Fri, 20 Nov 2020 18:28:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6DEE224181 for ; Fri, 20 Nov 2020 18:28:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Yn/IucBx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DEE224181 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kgB8h-0000OR-Br for qemu-devel@archiver.kernel.org; Fri, 20 Nov 2020 13:28:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgB84-0008PS-AM for qemu-devel@nongnu.org; Fri, 20 Nov 2020 13:27:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57802) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kgB82-0006fO-Ln for qemu-devel@nongnu.org; Fri, 20 Nov 2020 13:27:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605896845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ImORlDLpR/FV8Jy4iw3dG5bIWhm5oKemdMTuA/Iq04Y=; b=Yn/IucBxYX4o8ZE8JM9KfPBO+c5fJrJn53fX2kPGnTJlJkF9j0z0CpPx4ZwX63xwzh+tBH qe65F/vnupkWxlwptIVBZVzjjWiH/91Q/caaf/8v2KSWCW9xIaYSbygSFo/mYld5WzLCiv jnDocrCw7f8TRbnQnQLnMm58OsWsAUg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-559-2cEiLL7VO5eW723bRHPMdw-1; Fri, 20 Nov 2020 13:27:23 -0500 X-MC-Unique: 2cEiLL7VO5eW723bRHPMdw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D2D351876547; Fri, 20 Nov 2020 18:27:22 +0000 (UTC) Received: from localhost (ovpn-115-101.rdu2.redhat.com [10.10.115.101]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6A12B60C15; Fri, 20 Nov 2020 18:27:22 +0000 (UTC) Date: Fri, 20 Nov 2020 13:27:20 -0500 From: Eduardo Habkost To: Markus Armbruster Subject: Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals Message-ID: <20201120182720.GF2271382@habkost.net> References: <20201116224143.1284278-1-ehabkost@redhat.com> <20201116224143.1284278-4-ehabkost@redhat.com> <20201117144246.GD1235237@habkost.net> <87mtzdd4p7.fsf@dusky.pond.sub.org> <20201119182158.GX1509407@habkost.net> <877dqg8ukz.fsf@dusky.pond.sub.org> MIME-Version: 1.0 In-Reply-To: <877dqg8ukz.fsf@dusky.pond.sub.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= , QEMU Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Nov 20, 2020 at 06:29:16AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Thu, Nov 19, 2020 at 11:24:52AM +0100, Markus Armbruster wrote: > >> Marc-André Lureau writes: > >> > >> > On Tue, Nov 17, 2020 at 6:42 PM Eduardo Habkost wrote: > >> > > >> >> On Tue, Nov 17, 2020 at 12:37:56PM +0400, Marc-André Lureau wrote: > >> >> > On Tue, Nov 17, 2020 at 2:43 AM Eduardo Habkost > >> >> wrote: > >> >> > > >> >> > > Provide a separate QNumValue type that can be used for QNum value > >> >> > > literals without the referencing counting and memory allocation > >> >> > > features provided by QObject. > >> >> > > > >> >> > > Signed-off-by: Eduardo Habkost > >> >> > > --- > >> >> > > Changes v1 -> v2: > >> >> > > * Fix "make check" failure, by updating check-qnum unit test to > >> >> > > use the new struct fields > >> >> > > --- > >> >> > > include/qapi/qmp/qnum.h | 40 +++++++++++++++++++-- > >> >> > > qobject/qnum.c | 78 ++++++++++++++++++++--------------------- > >> >> > > tests/check-qnum.c | 14 ++++---- > >> >> > > 3 files changed, 84 insertions(+), 48 deletions(-) > >> >> > > > >> >> > > diff --git a/include/qapi/qmp/qnum.h b/include/qapi/qmp/qnum.h > >> >> > > index 55c27b1c24..62fbdfda68 100644 > >> >> > > --- a/include/qapi/qmp/qnum.h > >> >> > > +++ b/include/qapi/qmp/qnum.h > >> >> > > @@ -46,20 +46,56 @@ typedef enum { > >> >> > > * in range: qnum_get_try_int() / qnum_get_try_uint() check range and > >> >> > > * convert under the hood. > >> >> > > */ > >> >> > > -struct QNum { > >> >> > > - struct QObjectBase_ base; > >> >> > > + > >> >> > > +/** > >> >> > > + * struct QNumValue: the value of a QNum > >> >> > > + * > >> >> > > + * QNumValue literals can be constructed using the `QNUM_VAL_INT`, > >> >> > > + * `QNUM_VAL_UINT`, and `QNUM_VAL_DOUBLE` macros. > >> >> > > + */ > >> >> > > +typedef struct QNumValue { > >> >> > > + /* private: */ > >> > >> Do we care? > > > > Are you asking if we want to make them private, or if we want to > > document them as private (assuming they are). > > > > The answer to the latter is yes ("private:" is an indication to > > kernel-doc). The answer to the former seems to be "no", based on > > your other comments. > > > > Or maybe `kind` should be public and `u` should be private? > > You're factoring out a part of struct QNum into new struct QNumValue. > struct QNum is not private before the patch. I see no need to start > making it or parts of it private now. I don't want to change the rules, just to document the existing implicit rules. If you say QNum.u was never private, I won't argue. > > When the structure of a data type is to be kept away from its users, I > prefer to keep it out of the public header, so the compiler enforces the > encapsulation. I prefer that too, except that it is impossible when users of the API need the compiler to know the struct size. -- Eduardo