From: Julian Wiedmann <jwi@linux.ibm.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block <linux-block@vger.kernel.org>,
Julian Wiedmann <jwi@linux.ibm.com>
Subject: [PATCH 1/2] block: update documentation for blk_rq_timeout()
Date: Mon, 23 Nov 2020 09:12:15 +0100 [thread overview]
Message-ID: <20201123081216.64025-1-jwi@linux.ibm.com> (raw)
Requests don't have their own timers anymore, they share the queue's
timer instead.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
---
block/blk-timeout.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/blk-timeout.c b/block/blk-timeout.c
index 1b8de0417fc1..61430575cb58 100644
--- a/block/blk-timeout.c
+++ b/block/blk-timeout.c
@@ -122,8 +122,8 @@ unsigned long blk_rq_timeout(unsigned long timeout)
* @req: request that is about to start running.
*
* Notes:
- * Each request has its own timer, and as it is added to the queue, we
- * set up the timer. When the request completes, we cancel the timer.
+ * Each request has its own timeout. As a request is added to the queue,
+ * we start/adjust the queue's timer to keep track of the earliest timeout.
*/
void blk_add_timer(struct request *req)
{
--
2.17.1
next reply other threads:[~2020-11-23 8:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 8:12 Julian Wiedmann [this message]
2020-11-23 8:12 ` [PATCH 2/2] block: fix kerneldoc typos Julian Wiedmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123081216.64025-1-jwi@linux.ibm.com \
--to=jwi@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.