From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 157EEC2D0E4 for ; Tue, 24 Nov 2020 09:32:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CC222073C for ; Tue, 24 Nov 2020 09:32:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="L2lebaDG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731230AbgKXJcE (ORCPT ); Tue, 24 Nov 2020 04:32:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727901AbgKXJcE (ORCPT ); Tue, 24 Nov 2020 04:32:04 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 277C9C0613D6 for ; Tue, 24 Nov 2020 01:32:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0K5F7/ZiP054kVMvygqikQzypdat/4zA+V+MGZJ7QUM=; b=L2lebaDGYgDQN9mVMiE7RSMrJS FXW1whT6dFiIAsjidpgrhJBBIDsp6Fv3vWAV9fnbNygQ+x0Ll1iWHZqWPnoXK/FaLy1KgpPSNOPI1 JvVqd+PG/u8Dhoy6j1d/cAhn/fTSeZZirqkCe2O6YkPBoWh9zGaZhEiuKIsdKzUPnBpf8qnQPTvUz HvApGjICBIYYpD8U4tTUzBBO6zNWdOBKHiucW9I01OeP1/IQqKuCeFXMcVrV+DOnQk7bygbWC01zg V4OB/vdqTF9OTNuQnOYWLxnNdKNgiNAv+pTYxt/Myl52oZufBb3fQwhpRoIpNsTu/WkV0/qJl2SRz 53q1z7MQ==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1khUfy-00081k-Hh; Tue, 24 Nov 2020 09:31:54 +0000 Date: Tue, 24 Nov 2020 09:31:54 +0000 From: Christoph Hellwig To: Leon Romanovsky Cc: Doug Ledford , Jason Gunthorpe , Parav Pandit , linux-rdma@vger.kernel.org Subject: Re: [PATCH rdma-next] IB/mlx5: Use ib_dma APIs instead of open access to parent device Message-ID: <20201124093154.GA29715@infradead.org> References: <20201123082400.351371-1-leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201123082400.351371-1-leon@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Nov 23, 2020 at 10:24:00AM +0200, Leon Romanovsky wrote: > diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c > index 090e204ef1e1..d24ac339c053 100644 > --- a/drivers/infiniband/hw/mlx5/mr.c > +++ b/drivers/infiniband/hw/mlx5/mr.c > @@ -42,7 +42,7 @@ > #include "mlx5_ib.h" > > /* > - * We can't use an array for xlt_emergency_page because dma_map_single doesn't > + * We can't use an array for xlt_emergency_page because ib_dma_map_single doesn't Please avoid the pointlessly overly long line. > + ib_dma_sync_single_for_cpu(&dev->ib_dev, sg.addr, sg.length, DMA_TO_DEVICE); And here and much more.